Skip to content

Commit 7d2cfcd

Browse files
committed
Error CBO coupling between object.
1 parent f524e64 commit 7d2cfcd

File tree

1 file changed

+34
-26
lines changed

1 file changed

+34
-26
lines changed

app/code/Magento/Sales/Controller/Adminhtml/Order/AddressSave.php

Lines changed: 34 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,15 @@
77

88
namespace Magento\Sales\Controller\Adminhtml\Order;
99

10-
class AddressSave extends \Magento\Sales\Controller\Adminhtml\Order
10+
use Magento\Sales\Controller\Adminhtml\Order;
11+
use Magento\Backend\App\Action;
12+
use Magento\Sales\Api\OrderManagementInterface;
13+
use Magento\Sales\Api\OrderRepositoryInterface;
14+
use Magento\Directory\Model\RegionFactory;
15+
use Psr\Log\LoggerInterface;
16+
use Magento\Framework;
17+
18+
class AddressSave extends Order
1119
{
1220
/**
1321
* Authorization level of a basic admin session
@@ -17,40 +25,40 @@ class AddressSave extends \Magento\Sales\Controller\Adminhtml\Order
1725
const ADMIN_RESOURCE = 'Magento_Sales::actions_edit';
1826

1927
/**
20-
* @var \Magento\Directory\Model\RegionFactory
28+
* @var RegionFactory
2129
*/
2230
private $regionFactory;
2331

2432
/**
25-
* @param \Magento\Backend\App\Action\Context $context
26-
* @param \Magento\Framework\Registry $coreRegistry
27-
* @param \Magento\Framework\App\Response\Http\FileFactory $fileFactory
28-
* @param \Magento\Framework\Translate\InlineInterface $translateInline
29-
* @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
30-
* @param \Magento\Framework\Controller\Result\JsonFactory $resultJsonFactory
31-
* @param \Magento\Framework\View\Result\LayoutFactory $resultLayoutFactory
32-
* @param \Magento\Framework\Controller\Result\RawFactory $resultRawFactory
33-
* @param \Magento\Sales\Api\OrderManagementInterface $orderManagement
34-
* @param \Magento\Sales\Api\OrderRepositoryInterface $orderRepository
35-
* @param \Psr\Log\LoggerInterface $logger
36-
* @param \Magento\Directory\Model\RegionFactory $regionFactory
33+
* @param Action\Context $context
34+
* @param Framework\Registry $coreRegistry
35+
* @param Framework\App\Response\Http\FileFactory $fileFactory
36+
* @param Framework\Translate\InlineInterface $translateInline
37+
* @param Framework\View\Result\PageFactory $resultPageFactory
38+
* @param Framework\Controller\Result\JsonFactory $resultJsonFactory
39+
* @param Framework\View\Result\LayoutFactory $resultLayoutFactory
40+
* @param Framework\Controller\Result\RawFactory $resultRawFactory
41+
* @param OrderManagementInterface $orderManagement
42+
* @param OrderRepositoryInterface $orderRepository
43+
* @param LoggerInterface $logger
44+
* @param RegionFactory $regionFactory
3745
*
3846
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
3947
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
4048
*/
4149
public function __construct(
42-
\Magento\Backend\App\Action\Context $context,
43-
\Magento\Framework\Registry $coreRegistry,
44-
\Magento\Framework\App\Response\Http\FileFactory $fileFactory,
45-
\Magento\Framework\Translate\InlineInterface $translateInline,
46-
\Magento\Framework\View\Result\PageFactory $resultPageFactory,
47-
\Magento\Framework\Controller\Result\JsonFactory $resultJsonFactory,
48-
\Magento\Framework\View\Result\LayoutFactory $resultLayoutFactory,
49-
\Magento\Framework\Controller\Result\RawFactory $resultRawFactory,
50-
\Magento\Sales\Api\OrderManagementInterface $orderManagement,
51-
\Magento\Sales\Api\OrderRepositoryInterface $orderRepository,
52-
\Psr\Log\LoggerInterface $logger,
53-
\Magento\Directory\Model\RegionFactory $regionFactory
50+
Action\Context $context,
51+
Framework\Registry $coreRegistry,
52+
Framework\App\Response\Http\FileFactory $fileFactory,
53+
Framework\Translate\InlineInterface $translateInline,
54+
Framework\View\Result\PageFactory $resultPageFactory,
55+
Framework\Controller\Result\JsonFactory $resultJsonFactory,
56+
Framework\View\Result\LayoutFactory $resultLayoutFactory,
57+
Framework\Controller\Result\RawFactory $resultRawFactory,
58+
OrderManagementInterface $orderManagement,
59+
OrderRepositoryInterface $orderRepository,
60+
LoggerInterface $logger,
61+
RegionFactory $regionFactory
5462
) {
5563
$this->regionFactory = $regionFactory;
5664
parent::__construct(

0 commit comments

Comments
 (0)