MAGETWO-36376: Magento\Quote\Api\GuestCartItemRepository

 - removed delete methods from non-guest versions CartItemRepositoryInterface and Repository

Author: Cari Spruiell

app/code/Magento/Quote/Api/CartItemRepositoryInterface.php

@@ -27,15 +27,6 @@ public function getList($cartId);
      */
     public function save(\Magento\Quote\Api\Data\CartItemInterface $cartItem);
 
-    /**
-     * Delete cart item
-     *
-     * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem
-     * @return void
-     * @throws \Magento\Framework\Exception\CouldNotSaveException
-     */
-    public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem);
-
     /**
      * Removes the specified item from the specified cart.
      *

app/code/Magento/Quote/Model/Quote/Item/Repository.php

@@ -107,10 +107,8 @@ public function save(\Magento\Quote\Api\Data\CartItemInterface $cartItem)
     /**
      * {@inheritdoc}
      */
-    public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem)
+    public function deleteById($cartId, $itemId)
     {
-        $cartId = $cartItem->getQuoteId();
-        $itemId = $cartItem->getItemId();
         /**
          * Quote.
          *
@@ -129,18 +127,7 @@ public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem)
         } catch (\Exception $e) {
             throw new CouldNotSaveException(__('Could not remove item from quote'));
         }
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function deleteById($cartId, $itemId)
-    {
-        $item = $this->itemDataFactory->create()
-            ->setQuoteId($cartId)
-            ->setItemId($itemId);
 
-        $this->delete($item);
         return true;
     }
 

app/code/Magento/Quote/Test/Unit/Model/GuestCart/GuestCartItemRepositoryTest.php

@@ -130,15 +130,4 @@ public function testDeleteById()
             ->willReturn(true);
         $this->assertTrue($this->guestCartItemRepository->deleteById($this->maskedCartId, $itemId));
     }
-
-    /**
-     * @return void
-     */
-    public function testDelete()
-    {
-        $this->cartItemRepositoryMock->expects($this->once())
-            ->method('delete')
-            ->with($this->quoteItemMock);
-        $this->guestCartItemRepository->delete($this->quoteItemMock);
-    }
 }

app/code/Magento/Quote/Test/Unit/Model/Quote/Item/RepositoryTest.php

@@ -7,7 +7,7 @@
 
 namespace Magento\Quote\Test\Unit\Model\Quote\Item;
 
-use \Magento\Quote\Model\Quote\Item\Repository;
+use Magento\Quote\Model\Quote\Item\Repository;
 
 class RepositoryTest extends \PHPUnit_Framework_TestCase
 {
@@ -292,15 +292,13 @@ public function testDeleteWithInvalidQuoteItem()
     {
         $cartId = 11;
         $itemId = 5;
-        $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId);
-        $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId);
         $this->quoteRepositoryMock->expects($this->once())
             ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
         $this->quoteMock->expects($this->once())
             ->method('getItemById')->with($itemId)->will($this->returnValue(false));
         $this->quoteMock->expects($this->never())->method('removeItem');
 
-        $this->repository->delete($this->dataMock);
+        $this->repository->deleteById($cartId, $itemId);
     }
 
     /**
@@ -312,8 +310,6 @@ public function testDeleteWithCouldNotSaveException()
     {
         $cartId = 11;
         $itemId = 5;
-        $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId);
-        $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId);
         $this->quoteRepositoryMock->expects($this->once())
             ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
         $this->quoteMock->expects($this->once())
@@ -328,27 +324,7 @@ public function testDeleteWithCouldNotSaveException()
             ->with($this->quoteMock)
             ->willThrowException($exception);
 
-        $this->repository->delete($this->dataMock);
-    }
-
-    /**
-     * @return void
-     */
-    public function testDelete()
-    {
-        $cartId = 11;
-        $itemId = 5;
-        $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId);
-        $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId);
-        $this->quoteRepositoryMock->expects($this->once())
-            ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
-        $this->quoteMock->expects($this->once())
-            ->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock));
-        $this->quoteMock->expects($this->once())->method('removeItem');
-        $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
-        $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
-
-        $this->repository->delete($this->dataMock);
+        $this->repository->deleteById($cartId, $itemId);
     }
 
     /**
@@ -363,13 +339,6 @@ public function testDeleteByIdForCustomer()
             ->with($customerId)
             ->will($this->returnValue($this->quoteMock));
         $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
-        $this->itemDataFactoryMock->expects($this->once())->method('create')->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('setQuoteId')
-            ->with($cartId)->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('setItemId')
-            ->with($itemId)->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId);
-        $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId);
         $this->quoteRepositoryMock->expects($this->once())
             ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
         $this->quoteMock->expects($this->once())
@@ -424,13 +393,6 @@ public function testDeleteById()
     {
         $cartId = 11;
         $itemId = 5;
-        $this->itemDataFactoryMock->expects($this->once())->method('create')->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('setQuoteId')
-            ->with($cartId)->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('setItemId')
-            ->with($itemId)->willReturn($this->dataMock);
-        $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId);
-        $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId);
         $this->quoteRepositoryMock->expects($this->once())
             ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
         $this->quoteMock->expects($this->once())