Skip to content

Commit 7c3be5e

Browse files
🔃 [EngCom] Public Pull Requests - 2.1-develop
Accepted Public Pull Requests:
2 parents 57442e5 + 4115fec commit 7c3be5e

File tree

6 files changed

+28
-13
lines changed

6 files changed

+28
-13
lines changed

app/code/Magento/Customer/etc/config.xml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,15 @@ T: {{var telephone}}
8181
{{depend vat_id}}<br/>VAT: {{var vat_id}}{{/depend}}]]></html>
8282
<pdf><![CDATA[{{depend prefix}}{{var prefix}} {{/depend}}{{var firstname}} {{depend middlename}}{{var middlename}} {{/depend}}{{var lastname}}{{depend suffix}} {{var suffix}}{{/depend}}|
8383
{{depend company}}{{var company}}|{{/depend}}
84-
{{if street1}}{{var street1}}
85-
{{/if}}
84+
{{if street1}}{{var street1}}|{{/if}}
8685
{{depend street2}}{{var street2}}|{{/depend}}
8786
{{depend street3}}{{var street3}}|{{/depend}}
8887
{{depend street4}}{{var street4}}|{{/depend}}
89-
{{if city}}{{var city}},|{{/if}}
90-
{{if region}}{{var region}}, {{/if}}{{if postcode}}{{var postcode}}{{/if}}|
88+
{{if city}}{{var city}}, {{/if}}{{if region}}{{var region}}, {{/if}}{{if postcode}}{{var postcode}}{{/if}}|
9189
{{var country}}|
92-
{{depend telephone}}T: {{var telephone}}{{/depend}}|
93-
{{depend fax}}<br/>F: {{var fax}}{{/depend}}|
94-
{{depend vat_id}}<br/>VAT: {{var vat_id}}{{/depend}}|]]></pdf>
90+
{{depend telephone}}T: {{var telephone}}|{{/depend}}
91+
{{depend fax}}F: {{var fax}}|{{/depend}}|
92+
{{depend vat_id}}VAT: {{var vat_id}}{{/depend}}|]]></pdf>
9593
</address_templates>
9694
</customer>
9795
<general>

app/code/Magento/Robots/Controller/Index/Index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public function execute()
4343
/** @var Page $resultPage */
4444
$resultPage = $this->resultPageFactory->create(true);
4545
$resultPage->addHandle('robots_index_index');
46+
$resultPage->setHeader('Content-Type', 'text/plain');
4647
return $resultPage;
4748
}
4849
}

app/code/Magento/Robots/Test/Unit/Controller/Index/IndexTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ public function testExecute()
5151
$resultPageMock->expects($this->once())
5252
->method('addHandle')
5353
->with('robots_index_index');
54+
$resultPageMock->expects($this->once())
55+
->method('setHeader')
56+
->with('Content-Type', 'text/plain');
5457

5558
$this->resultPageFactory->expects($this->any())
5659
->method('create')

app/code/Magento/Theme/view/frontend/templates/html/print.phtml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@
55
*/
66
?>
77
<script>
8-
jQuery(function() {
9-
window.print();
10-
});
8+
require(
9+
[
10+
'jquery'
11+
],
12+
function($) {
13+
$(function() {
14+
window.print();
15+
});
16+
}
17+
);
1118
</script>

app/code/Magento/Ui/view/base/web/js/form/form.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ define([
3838
* @returns {Object}
3939
*/
4040
function collectData(items) {
41-
var result = {};
41+
var result = {},
42+
name;
4243

4344
items = Array.prototype.slice.call(items);
4445

@@ -54,6 +55,11 @@ define([
5455
}
5556
break;
5657

58+
case 'select-multiple':
59+
name = item.name.substring(0, item.name.length - 2); //remove [] from the name ending
60+
result[name] = _.pluck(item.selectedOptions, 'value');
61+
break;
62+
5763
default:
5864
result[item.name] = item.value;
5965
}

dev/tests/integration/testsuite/Magento/Customer/Block/Address/Renderer/DefaultRendererTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function renderArrayDataProvider()
5656
[
5757
$addressAttributes,
5858
AttributeDataFactory::OUTPUT_FORMAT_PDF,
59-
"John Smith|\n\nGreen str, 67\n\n\n\n\nCityM,|\nAlabama, 75477|\nUnited States|\nT: 3468676|\n|\n|"
59+
"John Smith|\n\nGreen str, 67|\n\n\n\nCityM, Alabama, 75477|\nUnited States|\nT: 3468676|\n|\n|"
6060
],
6161
[
6262
$addressAttributes,
@@ -112,7 +112,7 @@ public function renderDataProvider()
112112
[
113113
$address,
114114
AttributeDataFactory::OUTPUT_FORMAT_PDF,
115-
"John Smith|\n\nGreen str, 67\n\n\n\n\nCityM,|\nAlabama, 75477|
115+
"John Smith|\n\nGreen str, 67|\n\n\n\nCityM, Alabama, 75477|
116116
United States|\nT: 3468676|\n|\n|"
117117
],
118118
[

0 commit comments

Comments
 (0)