graphQl: removed set shipping addresses chain, using di preference instead

Author: vitaliyboyko

app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressesOnCart/SingleShippingAddressProcessor.php renamed to app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressOnCart.php

@@ -5,7 +5,7 @@
  */
 declare(strict_types=1);
 
-namespace Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCart;
+namespace Magento\QuoteGraphQl\Model\Cart;
 
 use Magento\Authorization\Model\UserContextInterface;
 use Magento\Customer\Api\Data\AddressInterface;
@@ -16,12 +16,11 @@
 use Magento\Quote\Model\Quote\Address;
 use Magento\Quote\Model\ShippingAddressManagementInterface;
 use Magento\Customer\Api\AddressRepositoryInterface;
-use Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCartInterface;
 
 /**
  * Set single shipping address for a specified shopping cart
  */
-class SingleShippingAddressProcessor implements SetShippingAddressesOnCartInterface
+class SetShippingAddressOnCart implements SetShippingAddressesOnCartInterface
 {
     /**
      * @var ShippingAddressManagementInterface
@@ -59,7 +58,9 @@ public function __construct(
     public function execute(ContextInterface $context, CartInterface $cart, array $shippingAddresses): void
     {
         if (count($shippingAddresses) > 1) {
-            return;
+            throw new GraphQlInputException(
+                __('Multiple addresses do not allowed here!')
+            );
         }
         $shippingAddress = current($shippingAddresses);
         $customerAddressId = $shippingAddress['customer_address_id'] ?? null;

app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php

@@ -8,7 +8,9 @@
         "magento/module-quote": "*",
         "magento/module-catalog": "*",
         "magento/module-store": "*",
-        "magento/module-checkout": "*"
+        "magento/module-checkout": "*",
+        "magento/module-customer": "*",
+        "magento/module-authorization": "*"
     },
     "suggest": {
         "magento/module-graph-ql": "*"

app/code/Magento/QuoteGraphQl/composer.json

@@ -7,14 +7,7 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
     <preference for="Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCartInterface"
-                type="Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCart" />
-    <type name="Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCartInterface">
-        <arguments>
-            <argument name="shippingAddressProcessors" xsi:type="array">
-                <item name="singleShippingAddress" xsi:type="object">Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCart\SingleShippingAddressProcessor</item>
-            </argument>
-        </arguments>
-    </type>
+                type="Magento\QuoteGraphQl\Model\Cart\SetShippingAddressOnCart" />
     <virtualType name="multishippingPaymentSpecification" type="Magento\Payment\Model\Method\Specification\Composite">
         <arguments>
             <argument name="specifications" xsi:type="array">

app/code/Magento/QuoteGraphQl/etc/graphql/di.xml

@@ -143,6 +143,52 @@ public function testSetSavedShippingAddressOnCartByGuest()
         $this->graphQlQuery($query);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
+     * @magentoConfigFixture default_store multishipping/options/checkout_multiple 0
+     */
+    public function testSetMultipleShippingAddressesOnCartByGuest()
+    {
+        $this->quoteResource->load(
+            $this->quote,
+            'test_order_with_simple_product_without_address',
+            'reserved_order_id'
+        );
+        $maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$this->quote->getId());
+
+        $query = <<<QUERY
+mutation {
+  setShippingAddressesOnCart(
+    input: {
+      cart_id: "$maskedQuoteId"
+      shipping_addresses: [
+        {
+          customer_address_id: 1
+        },
+        {
+          customer_address_id: 1
+        }
+      ]
+    }
+  ) {
+    cart {
+      addresses {
+        firstname
+        lastname
+        company
+        street
+        city
+        postcode
+        telephone
+      }
+    }
+  }
+}
+QUERY;
+        self::expectExceptionMessage('Multiple addresses do not allowed here!');
+        $this->graphQlQuery($query);
+    }
+
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
      */