MC-19226: Cart Promotions :: Store promotions detail on the quote

- Reverted Db and API changes

Author: Prabhu Ram

app/code/Magento/Quote/etc/db_schema.xml

@@ -175,7 +175,6 @@
         <column xsi:type="text" name="applied_taxes" nullable="true" comment="Applied Taxes"/>
         <column xsi:type="varchar" name="discount_description" nullable="true" length="255"
                 comment="Discount Description"/>
-        <column xsi:type="text" name="discounts" nullable="true" comment="Individual serialized discounts"/>
         <column xsi:type="decimal" name="shipping_discount_amount" scale="4" precision="20" unsigned="false"
                 nullable="true" comment="Shipping Discount Amount"/>
         <column xsi:type="decimal" name="base_shipping_discount_amount" scale="4" precision="20" unsigned="false"
@@ -235,7 +234,6 @@
         <column xsi:type="varchar" name="name" nullable="true" length="255" comment="Name"/>
         <column xsi:type="text" name="description" nullable="true" comment="Description"/>
         <column xsi:type="text" name="applied_rule_ids" nullable="true" comment="Applied Rule Ids"/>
-        <column xsi:type="text" name="discounts" nullable="true" comment="Individual serialized discounts"/>
         <column xsi:type="text" name="additional_data" nullable="true" comment="Additional Data"/>
         <column xsi:type="smallint" name="is_qty_decimal" padding="5" unsigned="true" nullable="true" identity="false"
                 comment="Is Qty Decimal"/>

app/code/Magento/SalesRule/Api/Data/DiscountDataInterface.php

@@ -9,52 +9,28 @@
 namespace Magento\SalesRule\Api\Data;
 
 /**
- * @api
+ * Rule discount Interface
  */
 interface RuleDiscountInterface
 {
     /**
      * Get Discount Data
      *
-     * @return \Magento\SalesRule\Api\Data\DiscountDataInterface
+     * @return mixed | \Magento\SalesRule\Model\Rule\Action\Discount\Data
      */
-    public function getDiscountData(): DiscountDataInterface;
-
-    /**
-     * Set discount data
-     *
-     * @param DiscountDataInterface $discountData
-     * @return $this
-     */
-    public function setDiscountData(DiscountDataInterface $discountData);
-
-    /**
-     * Set Rule Label
-     *
-     * @param string $ruleLabel
-     * @return $this
-     */
-    public function setRuleLabel(string $ruleLabel);
+    public function getDiscountData();
 
     /**
      * Get Rule Label
      *
      * @return string
      */
-    public function getRuleLabel(): ?string;
-
-    /**
-     * Set Rule Id
-     *
-     * @param int $ruleID
-     * @return $this
-     */
-    public function setRuleID(int $ruleID);
+    public function getRuleLabel();
 
     /**
      * Get Rule ID
      *
      * @return int
      */
-    public function getRuleID(): ?int;
+    public function getRuleID();
 }

app/code/Magento/SalesRule/Api/Data/RuleDiscountInterface.php

@@ -7,8 +7,8 @@
 
 namespace Magento\SalesRule\Model\Data;
 
+use Magento\SalesRule\Model\Rule\Action\Discount\Data;
 use Magento\SalesRule\Api\Data\RuleDiscountInterface;
-use Magento\SalesRule\Api\Data\DiscountDataInterface;
 use Magento\Framework\Api\ExtensionAttributesInterface;
 
 /**
@@ -23,9 +23,9 @@ class RuleDiscount extends \Magento\Framework\Api\AbstractExtensibleObject imple
     /**
      * Get Discount Data
      *
-     * @return DiscountDataInterface
+     * @return Data
      */
-    public function getDiscountData(): DiscountDataInterface
+    public function getDiscountData()
     {
         return $this->_get(self::KEY_DISCOUNT_DATA);
     }
@@ -35,54 +35,21 @@ public function getDiscountData(): DiscountDataInterface
      *
      * @return string
      */
-    public function getRuleLabel(): ?string
+    public function getRuleLabel()
     {
         return $this->_get(self::KEY_RULE_LABEL);
     }
 
-    /**
-     * Set Discount Data
-     *
-     * @param DiscountDataInterface $discountData
-     * @return RuleDiscount
-     */
-    public function setDiscountData(DiscountDataInterface $discountData)
-    {
-        return $this->setData(self::KEY_DISCOUNT_DATA, $discountData);
-    }
-
-    /**
-     * Set Rule Label
-     *
-     * @param string $ruleLabel
-     * @return RuleDiscount
-     */
-    public function setRuleLabel(string $ruleLabel)
-    {
-        return $this->setData(self::KEY_RULE_LABEL, $ruleLabel);
-    }
-
     /**
      * Get Rule ID
      *
      * @return int
      */
-    public function getRuleID(): ?int
+    public function getRuleID()
     {
         return $this->_get(self::KEY_RULE_ID);
     }
 
-    /**
-     * Set Rule ID
-     *
-     * @param int $ruleID
-     * @return RuleDiscount
-     */
-    public function setRuleID(int $ruleID)
-    {
-        return $this->setData(self::KEY_RULE_ID, $ruleID);
-    }
-
     /**
      * Retrieve existing extension attributes object or create a new one.
      *