Skip to content

Commit 7b3e705

Browse files
committed
MAGETWO-66480: [GITHUB] URL key for specified store already exists #6671
- refactoring - fixing copyright
1 parent 879cee4 commit 7b3e705

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

app/code/Magento/ImportExport/Controller/Adminhtml/Import/Start.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
use Magento\ImportExport\Controller\Adminhtml\ImportResult as ImportResultController;
99
use Magento\Framework\Controller\ResultFactory;
10-
use Magento\Framework\Message\ExceptionMessageLookupFactory;
11-
use Magento\Framework\App\ObjectManager;
1210

1311
class Start extends ImportResultController
1412
{
@@ -28,7 +26,7 @@ class Start extends ImportResultController
2826
* @param \Magento\ImportExport\Model\History $historyModel
2927
* @param \Magento\ImportExport\Helper\Report $reportHelper
3028
* @param \Magento\ImportExport\Model\Import $importModel
31-
* @param \Magento\Framework\Message\ExceptionMessageFactoryInterface $exceptionMessageFactory
29+
* @param \Magento\Framework\Message\ExceptionMessageFactoryInterface|null $exceptionMessageFactory
3230
*/
3331
public function __construct(
3432
\Magento\Backend\App\Action\Context $context,
@@ -40,8 +38,7 @@ public function __construct(
4038
) {
4139
parent::__construct($context, $reportProcessor, $historyModel, $reportHelper);
4240
$this->importModel = $importModel;
43-
$this->exceptionMessageFactory = $exceptionMessageFactory ?: ObjectManager::getInstance()
44-
->get(ExceptionMessageLookupFactory::class);
41+
$this->exceptionMessageFactory = $exceptionMessageFactory;
4542
}
4643

4744
/**
@@ -68,7 +65,6 @@ public function execute()
6865
try {
6966
$this->importModel->importSource();
7067
} catch (\Exception $e) {
71-
/** @var \Magento\Framework\View\Element\Messages $resultMessageBlock */
7268
$resultMessageBlock = $resultLayout->getLayout()->getBlock('messages');
7369
$message = $this->exceptionMessageFactory->createMessage($e);
7470
$html = $resultMessageBlock->addMessage($message)->toHtml();
@@ -94,7 +90,6 @@ public function execute()
9490
return $resultLayout;
9591
}
9692

97-
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
9893
$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
9994
$resultRedirect->setPath('adminhtml/*/index');
10095
return $resultRedirect;

lib/internal/Magento/Framework/Message/Test/Unit/ExceptionMessageLookupFactoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2013-2017 Magento, Inc. All rights reserved.
3+
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

0 commit comments

Comments
 (0)