Skip to content

Commit 7b29532

Browse files
committed
MAGETWO-70978: Stored XSS in Admin Shipment track
1 parent 0f61d2d commit 7b29532

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/Shipping/view/frontend/templates/tracking/details.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ $fields = [
2121
];
2222
$number = is_object($track) ? $track->getTracking() : $track['number'];
2323
?>
24-
<table class="data table order tracking" id="tracking-table-popup-<?= /* @noEscape */ $number ?>">
24+
<table class="data table order tracking" id="tracking-table-popup-<?= $block->escapeHtml($number) ?>">
2525
<caption class="table-caption"><?= $block->escapeHtml(__('Order tracking')) ?></caption>
2626
<tbody>
2727
<?php if (is_object($track)): ?>

app/code/Magento/Shipping/view/frontend/templates/tracking/progress.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ $parentBlock = $block->getParentBlock();
1111
$track = $block->getData('track');
1212
?>
1313
<div class="table-wrapper">
14-
<table class="data table order tracking" id="track-history-table-<?= /* @noEscape */ $track->getTracking() ?>">
14+
<table class="data table order tracking" id="track-history-table-<?= $block->escapeHtml($track->getTracking()) ?>">
1515
<caption class="table-caption"><?= $block->escapeHtml(__('Track history')) ?></caption>
1616
<thead>
1717
<tr>

0 commit comments

Comments
 (0)