Skip to content

Commit 7b078de

Browse files
committed
ENGCOM-3214: Add Value, ReadFactory and WriteFactory to Magento Framework's public API
1 parent 6416179 commit 7b078de

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,6 @@
712712
'Magento\Sales\Block\Reorder\Sidebar',
713713
'\Magento\Sales\CustomerData\LastOrderedItems::SIDEBAR_ORDER_LIMIT',
714714
],
715-
['ENTITY', 'Magento\Framework\App\Config\ValueInterface'],
716715
['XML_PATH_ALLOW_CURRENCIES_INSTALLED', 'Magento\Framework\Locale\CurrencyInterface'],
717716
[
718717
'DEFAULT_CURRENCY',

lib/internal/Magento/Framework/App/Config/Value.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* Config data model
1010
*
1111
* This model is temporarily marked as API since {@see \Magento\Framework\App\Config\ValueInterface} doesn't fit
12-
* developers' needs of extensibility. In 2.4 we are going to introduce a new iterface which should cover all needs
12+
* developers' needs of extensibility. In 2.4 we are going to introduce a new interface which should cover all needs
1313
* and deprecate the mentioned together with the model
1414
*
1515
* @method string getScope()
@@ -113,9 +113,9 @@ public function getFieldsetDataValue($key)
113113
}
114114

115115
/**
116-
* @inheritdoc
116+
* Processing object after save data
117117
*
118-
* @inheritdoc. In addition, it sets status 'invalidate' for config caches
118+
* {@inheritdoc}. In addition, it sets status 'invalidate' for config caches
119119
*
120120
* @return $this
121121
*/
@@ -129,9 +129,9 @@ public function afterSave()
129129
}
130130

131131
/**
132-
* @inheritdoc
132+
* Processing object after delete data
133133
*
134-
* @inheritdoc. In addition, it sets status 'invalidate' for config caches
134+
* {@inheritdoc}. In addition, it sets status 'invalidate' for config caches
135135
*
136136
* @return $this
137137
*/

lib/internal/Magento/Framework/App/Config/ValueInterface.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ interface ValueInterface
1818
{
1919
/**
2020
* Table name
21+
*
22+
* @deprecated since it is not used
2123
*/
2224
const ENTITY = 'config_data';
2325

0 commit comments

Comments
 (0)