Skip to content

Commit 7ae870b

Browse files
gabrieldagamagabrieldagama
authored
ENGCOM-9137: [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32226 
2 parents b04414b + bba967b commit 7ae870b

7 files changed

+151
-0
lines changed

‎app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminAddCommentOnCreateOrderPageActionGroup.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminAddCommentOnCreateOrderPageActionGroup">
12+
<annotations>
13+
<description>Add Comment On Create Order Page</description>
14+
</annotations>
15+
<arguments>
16+
<argument name="comment" type="string"/>
17+
</arguments>
18+
19+
<fillField selector="{{AdminCreateOrderCommentsSection.orderComments}}" userInput="{{comment}}" stepKey="provideComment"/>
20+
21+
</actionGroup>
22+
</actionGroups>

‎app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminCheckIfCustomerIsNotifiedOfOrderCommentActionGroup.xml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminCheckIfCustomerIsNotifiedOfOrderCommentActionGroup">
12+
<annotations>
13+
<description>Check if customer is notified/not Notified of Order Comment</description>
14+
</annotations>
15+
<arguments>
16+
<argument name="orderComment" type="string"/>
17+
<argument name="expectedStatus" type="string"/>
18+
</arguments>
19+
<grabTextFrom selector="{{AdminOrderNotesSection.customerNotifiedStatusOfOrderNoteByText(orderComment)}}" stepKey="grabStatusOfOrderNote"/>
20+
<assertEquals message="Assert Order Note status is correct" stepKey="assertCustomerIsNotified">
21+
<actualResult type="const">$grabStatusOfOrderNote</actualResult>
22+
<expectedResult type="string">{{expectedStatus}}</expectedResult>
23+
</assertEquals>
24+
25+
</actionGroup>
26+
</actionGroups>

‎app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminSelectFlatRateShippingMethodOnCreateOrderPageActionGroup.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminSelectFlatRateShippingMethodOnCreateOrderPageActionGroup" extends="AdminSelectFlatRateShippingMethodActionGroup">
12+
<annotations>
13+
<description>Clicks the Get shipping methods and rates link if it is displayed and Selects the Flat Rate Shipping Method</description>
14+
</annotations>
15+
<remove keyForRemoval="openShippingMethod"/>
16+
<conditionalClick selector="{{AdminInvoicePaymentShippingSection.getShippingMethodAndRates}}" dependentSelector="{{AdminInvoicePaymentShippingSection.getShippingMethodAndRates}}" visible="true" stepKey="openShippingMethodIfCollapsed" before="waitForShippingMethods"/>
17+
</actionGroup>
18+
</actionGroups>

‎app/code/Magento/Sales/Test/Mftf/Section/AdminCreateOrderCommentsSection.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
11+
<section name="AdminCreateOrderCommentsSection">
12+
<element name="orderComments" type="input" selector="textarea#order-comment"/>
13+
</section>
14+
</sections>

‎app/code/Magento/Sales/Test/Mftf/Section/AdminOrderFormTotalSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@
1212
<element name="subtotalRow" type="text" selector="#order-totals>table tr.row-totals:nth-of-type({{row}}) span.price" parameterized="true"/>
1313
<element name="total" type="text" selector="//tr[contains(@class,'row-totals')]/td[contains(text(), '{{total}}')]/following-sibling::td/span[contains(@class, 'price')]" parameterized="true"/>
1414
<element name="grandTotal" type="text" selector="//tr[contains(@class,'row-totals')]/td/strong[contains(text(), 'Grand Total')]/parent::td/following-sibling::td//span[contains(@class, 'price')]"/>
15+
<element name="appendComments" type="checkbox" selector="input#notify_customer"/>
1516
</section>
1617
</sections>

‎app/code/Magento/Sales/Test/Mftf/Section/AdminOrderNotesSection.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
11+
<section name="AdminOrderNotesSection">
12+
<element name="customerNotifiedStatusOfOrderNoteByText" type="text" selector="//div[@class='note-list-comment' and contains(text(),'{{text}}')]//preceding-sibling::span[@class='note-list-customer']/span" parameterized="true"/>
13+
</section>
14+
</sections>

‎app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderWithCheckedAppendCommentCheckboxTest.xml

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
11+
<test name="AdminCreateOrderWithCheckedAppendCommentCheckboxTest">
12+
<annotations>
13+
<stories value="Create Order With Checked Append Comment checkbox"/>
14+
<title value="Check if checked Append Comment checkbox isn't reset after shippinhg method selecting"/>
15+
<description value="Check if checked Append Comment checkbox isn't reset after shippinhg method selectiong"/>
16+
<severity value="MAJOR"/>
17+
<group value="sales"/>
18+
</annotations>
19+
<before>
20+
<actionGroup ref="AdminLoginActionGroup" stepKey="LoginAsAdmin"/>
21+
<createData entity="Simple_US_Customer" stepKey="createCustomer"/>
22+
<createData entity="_defaultCategory" stepKey="createCategory"/>
23+
<createData entity="defaultSimpleProduct" stepKey="createProduct">
24+
<requiredEntity createDataKey="createCategory"/>
25+
</createData>
26+
<magentoCLI command="config:set {{enabledCheckMoneyOrder.label}} {{enabledCheckMoneyOrder.value}}" stepKey="enableCheckMoneyOrder"/>
27+
<createData entity="FlatRateShippingMethodConfig" stepKey="enableFlatRate"/>
28+
</before>
29+
<after>
30+
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
31+
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
32+
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
33+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
34+
</after>
35+
36+
<actionGroup ref="NavigateToNewOrderPageExistingCustomerActionGroup" stepKey="navigateToNewOrderPage">
37+
<argument name="customer" value="$createCustomer$"/>
38+
</actionGroup>
39+
<actionGroup ref="AddSimpleProductToOrderActionGroup" stepKey="addProduct">
40+
<argument name="product" value="$createProduct$"/>
41+
</actionGroup>
42+
<actionGroup ref="AdminAddCommentOnCreateOrderPageActionGroup" stepKey="provideComment">
43+
<argument name="comment" value="Test Order Comment"/>
44+
</actionGroup>
45+
<seeCheckboxIsChecked selector="{{AdminOrderFormTotalSection.appendComments}}" stepKey="checkAppendCommentsCheckboxIsCheckedAfterCommentProvided"/>
46+
<scrollTo selector="{{AdminOrderFormPaymentSection.header}}" stepKey="scrollUp"/>
47+
<actionGroup ref="AdminSelectFlatRateShippingMethodOnCreateOrderPageActionGroup" stepKey="selectFlatRate"/>
48+
<actionGroup ref="SelectCheckMoneyPaymentMethodActionGroup" stepKey="selectPaymentMethod"/>
49+
<seeCheckboxIsChecked selector="{{AdminOrderFormTotalSection.appendComments}}" stepKey="checkAppendCommentsCheckboxIsCheckedAfterShippingSelected"/>
50+
<actionGroup ref="AdminSubmitOrderActionGroup" stepKey="submitOrder"/>
51+
<actionGroup ref="AdminCheckIfCustomerIsNotifiedOfOrderCommentActionGroup" stepKey="assertCustomerIsNotified">
52+
<argument name="orderComment" value="Test Order Comment"/>
53+
<argument name="expectedStatus" value="Notified"/>
54+
</actionGroup>
55+
</test>
56+
</tests>

0 commit comments

Comments
 (0)