MAGETWO-95215: [GraphQL] Performance issue in filters realization

Valeriy Nayda · Valeriy Nayda · commit 7acbb9aafc28 · 2018-10-10T13:23:47.000+03:00
diff --git a/lib/internal/Magento/Framework/GraphQl/Query/Fields.php b/lib/internal/Magento/Framework/GraphQl/Query/Fields.php
@@ -21,7 +21,7 @@ class Fields
     private $fieldsUsedInQuery = [];
 
     /**
-     * Prints AST to string. Capable of printing GraphQL queries and Type definition language.
+     * Set Query for extracting list of fields.
      *
      * @param string $query
      * @return void
@@ -42,6 +42,7 @@ public function setQuery($query)
                 ]
             );
         } catch (\Exception $e) {
+            // If a syntax error is encountered do not collect fields
         }
         if (isset($queryFields['IntrospectionQuery'])) {
             // It must be possible to query any fields during introspection query

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Fields`
`21`	`21`	`private $fieldsUsedInQuery = [];`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * Prints AST to string. Capable of printing GraphQL queries and Type definition language.`
	`24`	`+ * Set Query for extracting list of fields.`
`25`	`25`	`*`
`26`	`26`	`* @param string $query`
`27`	`27`	`* @return void`
`@@ -42,6 +42,7 @@ public function setQuery($query)`
`42`	`42`	`]`
`43`	`43`	`);`
`44`	`44`	`} catch (\Exception $e) {`
	`45`	`+ // If a syntax error is encountered do not collect fields`
`45`	`46`	`}`
`46`	`47`	`if (isset($queryFields['IntrospectionQuery'])) {`
`47`	`48`	`// It must be possible to query any fields during introspection query`