MAGETWO-89675: Build Stabilization

Fix isolation of JSUnit tests

Author: danmooney2

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/adminhtml/js/components/product-ui-select-test.js

@@ -13,8 +13,7 @@ define([
     'use strict';
 
     describe('Magento_Catalog/js/components/product-ui-select', function () {
-        var obj,
-            jQueryMethodsOverridden = {};
+        var obj;
 
         beforeEach(function () {
             obj = new Constr({
@@ -24,14 +23,6 @@ define([
                 options: [],
                 value: ''
             });
-
-            jQueryMethodsOverridden = {};
-        });
-
-        afterEach(function () {
-            _.each(jQueryMethodsOverridden, function (value, key) {
-                $.fn[key] = value;
-            });
         });
 
         describe('"validateInitialValue" method', function () {
@@ -40,8 +31,7 @@ define([
             });
 
             it('Should call not call ajax if value is empty', function () {
-                jQueryMethodsOverridden.ajax = $.ajax;
-                spyOn($, 'ajax');
+                $.ajax = jasmine.createSpy();
 
                 spyOn(obj, 'validationLoading');
                 spyOn(obj, 'value').and.returnValue('');
@@ -60,8 +50,7 @@ define([
                     value: 'hello world'
                 };
 
-                jQueryMethodsOverridden.ajax = $.ajax;
-                spyOn($, 'ajax').and.callFake(function (request) {
+                $.ajax = jasmine.createSpy().and.callFake(function (request) {
                     successCallback = request.success.bind(obj);
                     completeCallback = request.complete.bind(obj);
                 });

dev/tests/js/jasmine/tests/app/code/Magento/Review/view/frontend/web/js/process-review.test.js

@@ -31,7 +31,7 @@ define([
         it('Should automatically load reviews after page load if review tab is active', function () {
             element.addClass('active');
 
-            spyOn($, 'ajax').and.callFake(function () {
+            $.ajax = jasmine.createSpy().and.callFake(function () {
                 var d = $.Deferred();
 
                 d.promise().complete = function () {};
@@ -45,7 +45,7 @@ define([
         });
 
         it('Should not automatically load reviews after page load if review tab is not active', function () {
-            spyOn($, 'ajax').and.callFake(function () {
+            $.ajax = jasmine.createSpy().and.callFake(function () {
                 var d = $.Deferred();
 
                 d.promise().complete = function () {};
@@ -59,7 +59,7 @@ define([
         });
 
         it('Should load reviews if non active review tab was opened', function () {
-            spyOn($, 'ajax').and.callFake(function () {
+            $.ajax = jasmine.createSpy().and.callFake(function () {
                 var d = $.Deferred();
 
                 d.promise().complete = function () {};

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/ui-select.test.js

@@ -14,8 +14,7 @@ define([
     'use strict';
 
     describe('Magento_Ui/js/form/element/ui-select', function () {
-        var obj,
-            jQueryMethodsOverridden = {};
+        var obj;
 
         beforeEach(function () {
             obj = new Constr({
@@ -26,14 +25,6 @@ define([
 
             obj.value = ko.observableArray([]);
             obj.cacheOptions.plain = [];
-
-            jQueryMethodsOverridden = {};
-        });
-
-        afterEach(function () {
-            _.each(jQueryMethodsOverridden, function (value, key) {
-                $.fn[key] = value;
-            });
         });
 
         describe('"initialize" method', function () {
@@ -657,9 +648,7 @@ define([
                     }
                 };
 
-                jQueryMethodsOverridden.ajax = $.ajax;
-
-                spyOn($, 'ajax').and.callFake(function (request) {
+                $.ajax = jasmine.createSpy().and.callFake(function (request) {
                     ajaxRequest = request.success.bind(obj);
                 });