Skip to content

Commit 7a69458

Browse files
committed
MTA-1431: Create stable test plans for domains
- CR Changes
1 parent 1fd6b8a commit 7a69458

File tree

6 files changed

+15
-19
lines changed

6 files changed

+15
-19
lines changed

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class ProductForm extends FormTabs
9999
*/
100100
public function fill(FixtureInterface $product, SimpleElement $element = null, FixtureInterface $category = null)
101101
{
102-
$this->waitLoadPage();
102+
$this->waitPageToLoad();
103103
$dataConfig = $product->getDataConfig();
104104
$typeId = isset($dataConfig['type_id']) ? $dataConfig['type_id'] : null;
105105

@@ -187,15 +187,22 @@ protected function showAdvancedSettings()
187187
}
188188

189189
/**
190-
* Wait for load page.
190+
* Wait page to load.
191191
*
192192
* @return void
193193
*/
194-
protected function waitLoadPage()
194+
protected function waitPageToLoad()
195195
{
196196
$browser = $this->browser;
197197
$element = $this->advancedSettingContent;
198-
$this->waitForElementVisible($this->advancedSettingTrigger);
198+
$advancedSettingTrigger = $this->advancedSettingTrigger;
199+
200+
$this->_rootElement->waitUntil(
201+
function () use ($browser, $advancedSettingTrigger) {
202+
return $browser->find($advancedSettingTrigger)->isVisible() == true ? true : null;
203+
}
204+
);
205+
199206
$this->_rootElement->waitUntil(
200207
function () use ($browser, $element) {
201208
return $browser->find($element)->isVisible() == false ? true : null;

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class CreateProductAttributeEntityFromProductPageTest extends Scenario
3737
/* tags */
3838
const MVP = 'yes';
3939
const DOMAIN = 'MX';
40-
const STABLE = 'no';
40+
const TO_MAINTAIN = 'yes';
4141
/* end tags */
4242

4343
/**

dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerGroupEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
99
<testCase name="Magento\Customer\Test\TestCase\UpdateCustomerGroupEntityTest">
1010
<variation name="UpdateCustomerGroupEntityTestVariation1">
11-
<data name="tag" xsi:type="string">to_maintain:yes</data>
11+
<data name="tag" xsi:type="string">stable:no</data>
1212
<data name="customerGroup/data/tax_class_id/dataSet" xsi:type="string">retail_customer</data>
1313
<data name="customerGroup/data/customer_group_code" xsi:type="string">GroupName%isolation%</data>
1414
<constraint name="Magento\Customer\Test\Constraint\AssertCustomerGroupSuccessSaveMessage" />

dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/CustomerReviewReportEntityTest.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use Magento\Catalog\Test\Page\Product\CatalogProductView;
1212
use Magento\Cms\Test\Page\CmsIndex;
1313
use Magento\Customer\Test\Fixture\Customer;
14-
use Magento\Customer\Test\Page\CustomerAccountLogin;
1514
use Magento\Customer\Test\Page\CustomerAccountLogout;
1615
use Magento\Reports\Test\Page\Adminhtml\ProductReportReview;
1716
use Magento\Review\Test\Fixture\Review;
@@ -81,13 +80,6 @@ class CustomerReviewReportEntityTest extends Injectable
8180
*/
8281
protected $catalogCategoryView;
8382

84-
/**
85-
* Customer frontend login page
86-
*
87-
* @var CustomerAccountLogin
88-
*/
89-
protected $customerAccountLogin;
90-
9183
/**
9284
* Prepare data
9385
*
@@ -109,7 +101,6 @@ public function __prepare(FixtureFactory $fixtureFactory)
109101
* @param CatalogProductView $pageCatalogProductView
110102
* @param CmsIndex $cmsIndex
111103
* @param CatalogCategoryView $catalogCategoryView
112-
* @param CustomerAccountLogin $customerAccountLogin
113104
* @param CustomerAccountLogout $customerAccountLogout
114105
* @return void
115106
*/
@@ -118,14 +109,12 @@ public function __inject(
118109
CatalogProductView $pageCatalogProductView,
119110
CmsIndex $cmsIndex,
120111
CatalogCategoryView $catalogCategoryView,
121-
CustomerAccountLogin $customerAccountLogin,
122112
CustomerAccountLogout $customerAccountLogout
123113
) {
124114
$this->productReportReview = $productReportReview;
125115
$this->pageCatalogProductView = $pageCatalogProductView;
126116
$this->cmsIndex = $cmsIndex;
127117
$this->catalogCategoryView = $catalogCategoryView;
128-
$this->customerAccountLogin = $customerAccountLogin;
129118
$this->customerAccountLogout = $customerAccountLogout;
130119
}
131120

dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/ViewedProductsReportEntityTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class ViewedProductsReportEntityTest extends Injectable
5858
protected $browser;
5959

6060
/**
61-
* Browser interface
61+
* Catalog product index page
6262
*
6363
* @var CatalogProductIndex
6464
*/

dev/tests/functional/tests/app/Magento/Tax/Test/TestCase/CreateTaxRuleEntityTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class CreateTaxRuleEntityTest extends Injectable
2929
const MVP = 'yes';
3030
const DOMAIN = 'CS';
3131
const TEST_TYPE = 'acceptance_test';
32-
const TO_MAINTAIN = 'yes';
32+
const STABLE = 'no';
3333
/* end tags */
3434

3535
/**

0 commit comments

Comments
 (0)