ENGCOM-1666: fix: cache count() results for loops #15507

Author: Stanislav Idolov

app/code/Magento/Paypal/Model/Report/Settlement.php

@@ -416,7 +416,8 @@ public function parseCsv($localCsv, $format = 'new')
     private function getBodyItems(array $line, array $sectionColumns, array $rowMap)
     {
         $bodyItem = [];
-        for ($i = 1, $count = count($line); $i < $count; $i++) {
+        $lineCount = count($line);
+        for ($i = 1, $count = $lineCount; $i < $count; $i++) {
             if(isset($rowMap[$sectionColumns[$i]])) {
                 if (in_array($rowMap[$sectionColumns[$i]], $this->dateTimeColumns)) {
                     $line[$i] = $this->formatDateTimeColumns($line[$i]);

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/AddCompareProductsTest.php

@@ -76,7 +76,8 @@ public function tearDown()
     {
         $this->cmsIndex->open();
         $this->cmsIndex->getLinksBlock()->openLink("Compare Products");
-        for ($i = 1; $i <= count($this->products); $i++) {
+        $productsCount = count($this->products);
+        for ($i = 1; $i <= $productsCount; $i++) {
             $this->catalogProductCompare->getCompareProductsBlock()->removeProduct();
         }
     }

dev/tests/functional/tests/app/Magento/Checkout/Test/TestCase/ShoppingCartPerCustomerTest.php

@@ -95,7 +95,8 @@ public function test(
 
         $customers = [];
         $cartFixtures = [];
-        for ($i = 0; $i < count($checkoutData); $i++) {
+        $checkoutDataCount = count($checkoutData);
+        for ($i = 0; $i < $checkoutDataCount; $i++) {
             $customers[$i] = $this->fixtureFactory->createByCode('customer', ['dataset' => $customerDataset]);
             $customers[$i]->persist();
 

dev/tests/functional/tests/app/Magento/Multishipping/Test/TestStep/FillShippingInformationStep.php

@@ -58,7 +58,8 @@ public function __construct(
     public function run()
     {
         $shippingMethods = [];
-        for ($i = 0; $i < count($this->customer->getAddress()); $i++) {
+        $addressCount = $this->customer->getAddress();
+        for ($i = 0; $i < $addressCount; $i++) {
             $shippingMethods[] = $this->shippingMethod;
         }
         $this->shippingInformation->getShippingBlock()->selectShippingMethod($shippingMethods);

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertProductsQtyAfterOrderCancel.php

@@ -52,7 +52,8 @@ public function processAssert(
         AssertProductForm $assertProductForm,
         AssertConfigurableProductForm $assertConfigurableProductForm
     ) {
-        for ($i = 0; $i < count($order->getEntityId()['products']); $i++) {
+        $productsCount = count($order->getEntityId()['products']);
+        for ($i = 0; $i < $productsCount; $i++) {
             $product = $order->getEntityId()['products'][$i];
             $productData = $product->getData();
             if ($product instanceof BundleProduct) {

dev/tests/integration/testsuite/Magento/Catalog/Model/Layer/Filter/Price/AlgorithmBaseTest.php

@@ -112,7 +112,8 @@ public function testPricesSegmentation($categoryId, array $entityIds, array $int
         $items = $model->calculateSeparators($interval);
         $this->assertEquals(array_keys($intervalItems), array_keys($items));
 
-        for ($i = 0; $i < count($intervalItems); ++$i) {
+        $intervalItemsCount = count($intervalItems);
+        for ($i = 0; $i < $intervalItemsCount; ++$i) {
             $this->assertInternalType('array', $items[$i]);
             $this->assertEquals($intervalItems[$i]['from'], $items[$i]['from']);
             $this->assertEquals($intervalItems[$i]['to'], $items[$i]['to']);

dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/ConstantUsageSniffTest.php

@@ -67,7 +67,8 @@ private function tokenizeString($fileContent)
         $lineNumber = 1;
         $tokens = token_get_all($fileContent);
         $snifferTokens = [];
-        for ($i = 0; $i < count($tokens); $i++) {
+        $tokensCount = count($tokens);
+        for ($i = 0; $i < $tokensCount; $i++) {
             $content = is_array($tokens[$i]) ? $tokens[$i][1] : $tokens[$i];
             $snifferTokens[$i]['line'] = $lineNumber;
             $snifferTokens[$i]['content'] = $content;

dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php

@@ -501,8 +501,9 @@ private function _checkConstantWithClasspath($constant, $class, $replacement, $c
     {
         $classPathParts = explode('\\', $class);
         $classPartialPath = '';
-        for ($i = count($classPathParts) - 1; $i >= 0; $i--) {
-            if ($i === (count($classPathParts) - 1)) {
+        $classPathPartsCount = count($classPathParts);
+        for ($i = $classPathPartsCount - 1; $i >= 0; $i--) {
+            if ($i === ($classPathPartsCount - 1)) {
                 $classPartialPath = $classPathParts[$i] . $classPartialPath;
             } else {
                 $classPartialPath = $classPathParts[$i] . '\\' . $classPartialPath;

lib/internal/Magento/Framework/App/Test/Unit/Language/DictionaryTest.php

@@ -52,7 +52,8 @@ public function testDictionaryGetter()
         }
 
         $file = $this->getMockForAbstractClass(\Magento\Framework\Filesystem\File\ReadInterface::class);
-        for ($i = 0; $i < count($data); $i++) {
+        $dataCount = count($data);
+        for ($i = 0; $i < $dataCount; $i++) {
             $file->expects($this->at($i))->method('readCsv')->will($this->returnValue($data[$i]));
         }
         $file->expects($this->at($i))->method('readCsv')->will($this->returnValue(false));

lib/internal/Magento/Framework/Archive.php

@@ -96,14 +96,15 @@ public function pack($source, $destination = 'packed.tgz', $skipRoot = false)
     {
         $archivers = $this->_getArchivers($destination);
         $interimSource = '';
-        for ($i = 0; $i < count($archivers); $i++) {
-            if ($i == count($archivers) - 1) {
+        $archiversCount = count($archivers);
+        for ($i = 0; $i < $archiversCount; $i++) {
+            if ($i == $archiversCount - 1) {
                 $packed = $destination;
             } else {
                 $packed = dirname($destination) . '/~tmp-' . microtime(true) . $archivers[$i] . '.' . $archivers[$i];
             }
             $source = $this->_getArchiver($archivers[$i])->pack($source, $packed, $skipRoot);
-            if ($interimSource && $i < count($archivers)) {
+            if ($interimSource && $i < $archiversCount) {
                 unlink($interimSource);
             }
             $interimSource = $source;