MAGETWO-52737: Deleting category's image on custom store view - deletes category's images for all store views

Author: slopukhov

app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php

@@ -82,8 +82,12 @@ protected function _filterCategoryPostData(array $rawData)
         $data = $rawData;
         // @todo It is a workaround to prevent saving this data in category model and it has to be refactored in future
         if (isset($data['image']) && is_array($data['image'])) {
-            $data['image_additional_data'] = $data['image'];
-            unset($data['image']);
+            if (is_array($data['image']) && !empty($data['image']['delete'])) {
+                $data['image'] = null;
+            } else {
+                $data['image_new_data'] = $data['image'];
+                unset($data['image']);
+            }
         }
         return $data;
     }

app/code/Magento/Catalog/Model/Category/Attribute/Backend/Image.php

@@ -94,13 +94,7 @@ private function getImageUploader()
      */
     public function afterSave($object)
     {
-        $value = $object->getData($this->getAttribute()->getName() . '_additional_data');
-
-        if (is_array($value) && !empty($value['delete'])) {
-            $object->setData($this->getAttribute()->getName(), '');
-            $this->getAttribute()->getEntity()->saveAttribute($object, $this->getAttribute()->getName());
-            return $this;
-        }
+        $value = $object->getData($this->getAttribute()->getName() . '_new_data');
 
         if (isset($value[0]['name']) && isset($value[0]['tmp_name'])) {
             try {
@@ -111,9 +105,6 @@ public function afterSave($object)
             } catch (\Exception $e) {
                 $this->_logger->critical($e);
             }
-        } elseif (isset($value[0]['name'])) {
-            $object->setData($this->getAttribute()->getName(), $value[0]['name']);
-            $this->getAttribute()->getEntity()->saveAttribute($object, $this->getAttribute()->getName());
         }
         return $this;
     }

app/code/Magento/Catalog/Model/CategoryRepository.php

@@ -91,8 +91,12 @@ public function save(\Magento\Catalog\Api\Data\CategoryInterface $category)
             );
 
             if (isset($existingData['image']) && is_array($existingData['image'])) {
-                $existingData['image_additional_data'] = $existingData['image'];
-                unset($existingData['image']);
+                if (is_array($existingData['image']) && !empty($existingData['image']['delete'])) {
+                    $existingData['image'] = null;
+                } else {
+                    $existingData['image_new_data'] = $existingData['image'];
+                    unset($existingData['image']);
+                }
             }
         } else {
             $parentId = $category->getParentId() ?: $this->storeManager->getStore()->getRootCategoryId();

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Category/SaveTest.php

@@ -433,7 +433,7 @@ public function testExecute($categoryId, $storeId, $parentId)
             ->method('getPostValue')
             ->willReturn($postData);
         $addData = $postData;
-        $addData['image_additional_data'] = ['delete' => true];
+        $addData['image_new_data'] = ['delete' => true];
         $categoryMock->expects($this->once())
             ->method('addData')
             ->with($addData);

app/code/Magento/Catalog/Test/Unit/Model/CategoryRepositoryTest.php

@@ -173,7 +173,7 @@ public function filterExtraFieldsOnUpdateCategoryDataProvider()
                 ['level' => '1', 'path' => '1/2', 'image' => ['categoryImage'], 'name' => 'category'],
                 [
                     'store_id' => 1,
-                    'image_additional_data' => ['categoryImage'],
+                    'image_new_data' => ['categoryImage'],
                     'name' => 'category',
                     'entity_id' => null
                 ]