Skip to content

Commit 788a8aa

Browse files
committed
MC-17139: Multiple Unstable MFTF Tests The Are Slowing Down PRs
- Skipping unstable MFTF tests - Adding waits after adding product to cart
1 parent 8840bf2 commit 788a8aa

File tree

29 files changed

+42
-0
lines changed

29 files changed

+42
-0
lines changed

app/code/Magento/AuthorizenetAcceptjs/Test/Mftf/Test/FullCaptureAuthorizenetAcceptjsTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
<waitForPageLoad stepKey="waitForProductPage"/>
5555
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart"/>
5656
<waitForPageLoad stepKey="waitForCartToFill"/>
57+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
5758

5859
<!--Checkout steps-->
5960
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="GoToCheckoutFromMinicartActionGroup"/>

app/code/Magento/AuthorizenetAcceptjs/Test/Mftf/Test/GuestCheckoutVirtualProductAuthorizenetAcceptjsTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,10 @@
5555
<waitForPageLoad stepKey="waitForProductPage"/>
5656
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart"/>
5757
<waitForPageLoad stepKey="waitForCartToFill"/>
58+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
5859
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCartAgain"/>
5960
<waitForPageLoad stepKey="waitForCartToFillAgain"/>
61+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage2"/>
6062

6163
<!--Checkout steps-->
6264
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="GoToCheckoutFromMinicartActionGroup"/>

app/code/Magento/Braintree/Test/Mftf/Test/BraintreeCreditCardOnCheckoutTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
<waitForPageLoad stepKey="waitForPageLoad"/>
5050
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart"/>
5151
<waitForPageLoad stepKey="waitForPageLoad1"/>
52+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
5253
<!--Proceed to checkout-->
5354
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="GoToCheckoutFromMinicartActionGroup"/>
5455

@@ -74,6 +75,7 @@
7475
<waitForPageLoad stepKey="waitForPageLoad6"/>
7576
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart1"/>
7677
<waitForPageLoad stepKey="waitForPageLoad7"/>
78+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage2"/>
7779
<!--Proceed to checkout-->
7880
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="GoToCheckoutFromMinicartActionGroup1"/>
7981
<click selector="{{CheckoutPaymentSection.addressAction('New Address')}}" stepKey="clickOnNewAddress"/>

app/code/Magento/Captcha/Test/Mftf/Test/CaptchaFormsDisplayingTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@
9292
<amOnPage url="{{StorefrontProductPage.url($$createSimpleProduct.sku$$)}}" stepKey="openProductPage"/>
9393
<waitForPageLoad stepKey="waitForPageLoad"/>
9494
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addToCart" />
95+
<waitForPageLoad stepKey="waitForAddToCart"/>
96+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
9597
<waitForText userInput="You added $$createSimpleProduct.name$$ to your shopping cart." stepKey="waitForText"/>
9698
<click selector="{{StorefrontMinicartSection.showCart}}" stepKey="clickCart"/>
9799
<click selector="{{StorefrontMinicartSection.goToCheckout}}" stepKey="goToCheckout"/>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontAddProductToCartWithQtyActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<fillField selector="{{StorefrontProductPageSection.qtyInput}}" userInput="{{productQty}}" stepKey="fillProduct1Quantity"/>
1717
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="clickOnAddToCartButton"/>
1818
<waitForPageLoad stepKey="waitForProductToAddInCart"/>
19+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
1920
<seeElement selector="{{StorefrontProductPageSection.successMsg}}" stepKey="seeSuccessSaveMessage"/>
2021
</actionGroup>
2122
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontAddToCartCustomOptionsProductPageActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
</arguments>
1515
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addToCart"/>
1616
<waitForPageLoad stepKey="waitForPageLoad"/>
17+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
1718
<see selector="{{StorefrontMessagesSection.success}}" userInput="You added {{productName}} to your shopping cart." stepKey="seeAddToCartSuccessMessage"/>
1819
</actionGroup>
1920
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontClickAddToCartOnProductPageActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="StorefrontClickAddToCartOnProductPageActionGroup">
1111
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addToCart" />
12+
<waitForPageLoad stepKey="waitForAddToCart"/>
1213
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage" />
1314
</actionGroup>
1415
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontProductPageActionGroup.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@
1313
<argument name="productName"/>
1414
</arguments>
1515
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addToCart"/>
16+
<waitForPageLoad stepKey="waitForAddToCart"/>
1617
<waitForElementNotVisible selector="{{StorefrontProductActionSection.addToCartButtonTitleIsAdding}}" stepKey="waitForElementNotVisibleAddToCartButtonTitleIsAdding"/>
1718
<waitForElementNotVisible selector="{{StorefrontProductActionSection.addToCartButtonTitleIsAdded}}" stepKey="waitForElementNotVisibleAddToCartButtonTitleIsAdded"/>
1819
<waitForPageLoad stepKey="waitForPageLoad"/>
20+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
1921
<see selector="{{StorefrontMessagesSection.success}}" userInput="You added {{productName}} to your shopping cart." stepKey="seeAddToCartSuccessMessage"/>
2022
</actionGroup>
2123

app/code/Magento/Catalog/Test/Mftf/Test/AdminAddInStockProductToTheCartTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
<fillField selector="{{StorefrontProductPageSection.qtyInput}}" userInput="1" stepKey="fillProductQuantity"/>
7878
<click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="clickOnAddToCartButton"/>
7979
<waitForPageLoad stepKey="waitForProductToAddInCart"/>
80+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
8081
<seeElement selector="{{StorefrontProductPageSection.successMsg}}" stepKey="seeSuccessSaveMessage"/>
8182
<seeElement selector="{{StorefrontMinicartSection.quantity(1)}}" stepKey="seeAddedProductQuantityInCart"/>
8283
<click selector="{{StorefrontMinicartSection.showCart}}" stepKey="clickOnMiniCart"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductPriceToVerifyDataOverridingOnStoreViewLevelTest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@
5252

5353
<!-- Assign simple product to created store view -->
5454
<click selector="{{AdminCategoryMainActionsSection.CategoryStoreViewDropdownToggle}}" stepKey="clickCategoryStoreViewDropdownToggle"/>
55+
<waitForPageLoad stepKey="waitForPageLoad"/>
56+
<waitForElementVisible selector="{{AdminCategoryMainActionsSection.CategoryStoreViewOption(customStoreFR.name)}}" stepKey="waitForSelectCategoryStoreViewOption"/>
5557
<click selector="{{AdminCategoryMainActionsSection.CategoryStoreViewOption(customStoreFR.name)}}" stepKey="selectCategoryStoreViewOption"/>
58+
<waitForPageLoad stepKey="waitForPageLoad1"/>
59+
<waitForElementVisible selector="{{AdminProductFormChangeStoreSection.acceptButton}}" stepKey="waitForAcceptButton"/>
5660
<click selector="{{AdminProductFormChangeStoreSection.acceptButton}}" stepKey="clickAcceptButton"/>
5761
<waitForPageLoad stepKey="waitForPageToLoad"/>
5862

0 commit comments

Comments
 (0)