Covering the model classes by Unit Tests

eduard13 · eduard13 · commit 7811896f1740 · 2020-01-28T09:14:14.000+02:00
diff --git a/app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php b/app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php
@@ -26,8 +26,6 @@
  */
 class ConfigManagerTest extends TestCase
 {
-    const STUB_CRONTAB_AREA = 'crontab';
-
     /**
      * @var ConfigManager
      */
@@ -81,7 +79,7 @@ public function testThrownExceptionForCrontabArea()
     {
         $this->stateMock->expects($this->any())
             ->method('getAreaCode')
-            ->willReturn(static::STUB_CRONTAB_AREA);
+            ->willReturn(Area::AREA_CRONTAB);
 
         $this->model->getConfigured();
     }
diff --git a/app/code/Magento/Csp/Test/Unit/Model/PolicyRendererPoolTest.php b/app/code/Magento/Csp/Test/Unit/Model/PolicyRendererPoolTest.php
@@ -23,7 +23,7 @@
  */
 class PolicyRendererPoolTest extends TestCase
 {
-    const STUB_POLICY_ID = 'header';
+    private const STUB_POLICY_ID = 'header';
 
     /**
      * @var PolicyRendererPool

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@`
`26`	`26`	`*/`
`27`	`27`	`class ConfigManagerTest extends TestCase`
`28`	`28`	`{`
`29`		`- const STUB_CRONTAB_AREA = 'crontab';`
`30`		`-`
`31`	`29`	`/**`
`32`	`30`	`* @var ConfigManager`
`33`	`31`	`*/`
`@@ -81,7 +79,7 @@ public function testThrownExceptionForCrontabArea()`
`81`	`79`	`{`
`82`	`80`	`$this->stateMock->expects($this->any())`
`83`	`81`	`->method('getAreaCode')`
`84`		`- ->willReturn(static::STUB_CRONTAB_AREA);`
	`82`	`+ ->willReturn(Area::AREA_CRONTAB);`
`85`	`83`
`86`	`84`	`$this->model->getConfigured();`
`87`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`*/`
`24`	`24`	`class PolicyRendererPoolTest extends TestCase`
`25`	`25`	`{`
`26`		`- const STUB_POLICY_ID = 'header';`
	`26`	`+ private const STUB_POLICY_ID = 'header';`
`27`	`27`
`28`	`28`	`/**`
`29`	`29`	`* @var PolicyRendererPool`