magento2-login-as-customer/issues/104: Global refactoring

- Builds fixes

Author: naydav

app/code/Magento/LoginAsCustomer/Model/ResourceModel/GetAuthenticationDataBySecret.php

@@ -12,7 +12,7 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\LoginAsCustomerApi\Api\ConfigInterface;
 use Magento\LoginAsCustomerApi\Api\Data\AuthenticationDataInterface;
-use Magento\LoginAsCustomerApi\Api\Data\AuthenticationDataInterfaceFactor;
+use Magento\LoginAsCustomerApi\Api\Data\AuthenticationDataInterfaceFactory;
 use Magento\LoginAsCustomerApi\Api\GetAuthenticationDataBySecretInterface;
 
 /**

app/code/Magento/LoginAsCustomerApi/Api/Data/AuthenticationDataInterface.php

@@ -33,7 +33,9 @@ public function getAdminId(): int;
     /**
      * Get extension attributes
      *
-     * @return AuthenticationDataExtensionInterface|null
+     * Fully qualified namespaces is needed for proper work of ccode generation
+     *
+     * @return \Magento\LoginAsCustomerApi\Api\Data\AuthenticationDataExtensionInterface|null
      */
     public function getExtensionAttributes(): ?AuthenticationDataExtensionInterface;
 }

app/code/Magento/LoginAsCustomerUi/Controller/Login/Index.php

@@ -7,19 +7,19 @@
 
 namespace Magento\LoginAsCustomerUi\Controller\Login;
 
+use Magento\Customer\Api\CustomerRepositoryInterface;
 use Magento\Framework\App\RequestInterface;
 use Magento\Framework\Controller\Result\Redirect;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Controller\ResultInterface;
-use Magento\Customer\Api\CustomerRepositoryInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\App\Action\HttpGetActionInterface;
 use Magento\Framework\Message\ManagerInterface;
-use Psr\Log\LoggerInterface;
 use Magento\LoginAsCustomerApi\Api\GetAuthenticationDataBySecretInterface;
 use Magento\LoginAsCustomerApi\Api\AuthenticateCustomerInterface;
 use Magento\LoginAsCustomerApi\Api\DeleteAuthenticationDataBySecretInterface;
+use Psr\Log\LoggerInterface;
 
 /**
  * Login As Customer storefront login action