Skip to content

Commit 77cd324

Browse files
committed
MAGETWO-59801: [Performance Bug] Tax Rules Form unusable with large # of tax rates
1 parent 71ba44e commit 77cd324

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

dev/tests/js/jasmine/tests/lib/mage/multiselect.test.js

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ define([
1111
'use strict';
1212

1313
describe('Test for mage/multiselect jQuery plugin', function () {
14-
var element = '<select size="10"><option value="1">1</option></select>',
14+
var element = '<select></select>',
1515
instance,
1616
options = {
1717
'nextPageUrl': '/url',
@@ -32,11 +32,11 @@ define([
3232
});
3333

3434
it('multiselect2 methods check', function () {
35-
expect(instance.data('multiselect2').onScroll).toBeDefined();
36-
expect(instance.data('multiselect2').onKeyUp).toBeDefined();
37-
expect(instance.data('multiselect2').onCheck).toBeDefined();
38-
expect(instance.data('multiselect2').onError).toBeDefined();
39-
expect(instance.data('multiselect2').onOptionsChange).toBeDefined();
35+
expect(instance.data('mage-multiselect2').onScroll).toBeDefined();
36+
expect(instance.data('mage-multiselect2').onKeyUp).toBeDefined();
37+
expect(instance.data('mage-multiselect2').onCheck).toBeDefined();
38+
expect(instance.data('mage-multiselect2').onError).toBeDefined();
39+
expect(instance.data('mage-multiselect2').onOptionsChange).toBeDefined();
4040
});
4141

4242
it('multiselect2 options check', function () {
@@ -49,7 +49,7 @@ define([
4949
});
5050

5151
it('multiselect2 loadOptions success case', function () {
52-
spyOn(instance.data('multiselect2'), 'appendOptions').and.callFake(function () {
52+
spyOn(instance.data('mage-multiselect2'), 'appendOptions').and.callFake(function () {
5353
return true;
5454
});
5555

@@ -63,16 +63,16 @@ define([
6363
return d.promise();
6464
});
6565

66-
instance.data('multiselect2').loadOptions();
66+
instance.data('mage-multiselect2').loadOptions();
6767

6868
expect($.get).toHaveBeenCalled();
69-
expect(instance.data('multiselect2').appendOptions).toHaveBeenCalled();
69+
expect(instance.data('mage-multiselect2').appendOptions).toHaveBeenCalled();
7070
});
7171

7272
it('multiselect2 loadOptions negative case', function () {
7373
var errorMessage = 'Something went wrong';
7474

75-
spyOn(instance.data('multiselect2'), 'onError').and.callFake(function () {
75+
spyOn(instance.data('mage-multiselect2'), 'onError').and.callFake(function () {
7676
return true;
7777
});
7878

@@ -87,21 +87,21 @@ define([
8787
return d.promise();
8888
});
8989

90-
instance.data('multiselect2').loadOptions();
90+
instance.data('mage-multiselect2').loadOptions();
9191

9292
expect($.get).toHaveBeenCalled();
93-
expect(instance.data('multiselect2').onError).toHaveBeenCalledWith(errorMessage);
93+
expect(instance.data('mage-multiselect2').onError).toHaveBeenCalledWith(errorMessage);
9494
});
9595

9696
it('multiselect2 onKeyUp check', function () {
97-
spyOn(instance.data('multiselect2'), 'getSearchCriteria').and.returnValue('some_string');
98-
spyOn(instance.data('multiselect2'), 'setFilter');
99-
spyOn(instance.data('multiselect2'), 'loadOptions');
97+
spyOn(instance.data('mage-multiselect2'), 'getSearchCriteria').and.returnValue('some_string');
98+
spyOn(instance.data('mage-multiselect2'), 'setFilter');
99+
spyOn(instance.data('mage-multiselect2'), 'loadOptions');
100100

101-
instance.data('multiselect2').onKeyUp();
101+
instance.data('mage-multiselect2').onKeyUp();
102102

103-
expect(instance.data('multiselect2').setFilter).toHaveBeenCalled();
104-
expect(instance.data('multiselect2').loadOptions).toHaveBeenCalledWith(1);
103+
expect(instance.data('mage-multiselect2').setFilter).toHaveBeenCalled();
104+
expect(instance.data('mage-multiselect2').loadOptions).toHaveBeenCalledWith(1);
105105
});
106106
});
107107
});

0 commit comments

Comments
 (0)