Clean expired quotes - Fix out of memory on huge quotes list

Author: ihor-sviziev

dev/tests/integration/testsuite/Magento/Sales/Cron/CleanExpiredQuotesTest.php

@@ -9,6 +9,7 @@
 
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Quote\Model\QuoteRepository;
+use Magento\Quote\Model\ResourceModel\Quote\CollectionFactory as QuoteCollectionFactory;
 use Magento\TestFramework\Helper\Bootstrap;
 
 /**
@@ -34,6 +35,11 @@ class CleanExpiredQuotesTest extends \PHPUnit\Framework\TestCase
      */
     private $searchCriteriaBuilder;
 
+    /**
+     * @var QuoteCollectionFactory
+     */
+    private $quoteCollectionFactory;
+
     /**
      * @inheritdoc
      */
@@ -43,6 +49,7 @@ protected function setUp()
         $this->cleanExpiredQuotes = $objectManager->get(CleanExpiredQuotes::class);
         $this->quoteRepository = $objectManager->get(QuoteRepository::class);
         $this->searchCriteriaBuilder = $objectManager->get(SearchCriteriaBuilder::class);
+        $this->quoteCollectionFactory = $objectManager->get(QuoteCollectionFactory::class);
     }
 
     /**
@@ -66,4 +73,24 @@ public function testExecute()
             $totalCount
         );
     }
+
+    /**
+     * Check if outdated quotes are deleted.
+     *
+     * @magentoConfigFixture default_store checkout/cart/delete_quote_after -365
+     * @magentoDataFixture Magento/Sales/_files/quotes_big_amount.php
+     */
+    public function testExecuteWithBigAmountOfQuotes()
+    {
+        //Initial count - should be equal to 1000
+        //Use collection getSize in order to get quick result
+        $this->assertEquals(1000, $this->quoteCollectionFactory->create()->getSize());
+
+        //Deleting expired quotes
+        $this->cleanExpiredQuotes->execute();
+        $totalCount = $this->quoteCollectionFactory->create()->getSize();
+
+        //There should be no quotes anymore
+        $this->assertEquals(0, $totalCount);
+    }
 }

dev/tests/integration/testsuite/Magento/Sales/_files/quotes_big_amount.php

@@ -0,0 +1,37 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Framework\App\Config;
+use Magento\Quote\Model\Quote;
+use Magento\Quote\Model\QuoteFactory;
+use Magento\Quote\Model\QuoteRepository;
+use Magento\Store\Model\Store;
+use Magento\Store\Model\StoreRepository;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
+
+/** @var $objectManager ObjectManager */
+$objectManager = Bootstrap::getObjectManager();
+/** @var  QuoteFactory $quoteFactory */
+$quoteFactory = $objectManager->get(QuoteFactory::class);
+/** @var QuoteRepository $quoteRepository */
+$quoteRepository = $objectManager->get(QuoteRepository::class);
+/** @var  StoreRepository $storeRepository */
+$storeRepository = $objectManager->get(StoreRepository::class);
+/** @var Config $appConfig */
+$appConfig = $objectManager->get(Config::class);
+$appConfig->clean();
+
+/** @var Store $defaultStore */
+$defaultStore = $storeRepository->getActiveStoreByCode('default');
+
+for ($i = 0; $i < 1000; $i++) {
+    /** @var Quote $quote */
+    $quote = $quoteFactory->create();
+    $quote->setStoreId($defaultStore->getId());
+    $quoteRepository->save($quote);
+}

dev/tests/integration/testsuite/Magento/Sales/_files/quotes_big_amount_rollback.php

@@ -0,0 +1,34 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Framework\Api\SearchCriteriaBuilder;
+use Magento\Framework\Registry;
+use Magento\Quote\Model\QuoteRepository;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
+
+/** @var ObjectManager $objectManager */
+$objectManager = Bootstrap::getObjectManager();
+
+/** @var Registry $registry */
+$registry = $objectManager->get(Registry::class);
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', true);
+
+/** @var QuoteRepository $quoteRepository */
+$quoteRepository = $objectManager->get(QuoteRepository::class);
+/** @var SearchCriteriaBuilder $searchCriteriaBuilder */
+$searchCriteriaBuilder = $objectManager->get(SearchCriteriaBuilder::class);
+$searchCriteria = $searchCriteriaBuilder->create();
+$items = $quoteRepository->getList($searchCriteria)
+    ->getItems();
+foreach ($items as $item) {
+    $quoteRepository->delete($item);
+}
+
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', false);