Skip to content

Commit 76e27e2

Browse files
committed
ACP2E-290: [Magento Cloud] NewRelic Alert: 'Error Rate Critical'
1 parent be9b1fe commit 76e27e2

File tree

2 files changed

+58
-161
lines changed

2 files changed

+58
-161
lines changed

app/code/Magento/Theme/Controller/Result/MessagePlugin.php

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,17 @@ public function afterRenderResult(
101101
ResultInterface $result
102102
) {
103103
if (!($subject instanceof Json)) {
104-
$this->setCookie($this->getMessages());
104+
$newMessages = $this->messageManager->getMessages(true)->getItems();
105+
if (!empty($newMessages)) {
106+
$messages = $this->getCookiesMessages();
107+
foreach ($newMessages as $message) {
108+
$messages[] = [
109+
'type' => $message->getType(),
110+
'text' => $this->interpretationStrategy->interpret($message),
111+
];
112+
}
113+
$this->setCookie($messages);
114+
}
105115
}
106116
return $result;
107117
}
@@ -166,24 +176,6 @@ private function convertMessageText(string $text): string
166176
return $text;
167177
}
168178

169-
/**
170-
* Return messages array and clean message manager messages
171-
*
172-
* @return array
173-
*/
174-
protected function getMessages()
175-
{
176-
$messages = $this->getCookiesMessages();
177-
/** @var MessageInterface $message */
178-
foreach ($this->messageManager->getMessages(true)->getItems() as $message) {
179-
$messages[] = [
180-
'type' => $message->getType(),
181-
'text' => $this->interpretationStrategy->interpret($message),
182-
];
183-
}
184-
return $messages;
185-
}
186-
187179
/**
188180
* Return messages stored in cookies
189181
*

0 commit comments

Comments
 (0)