ACP2E-813: Configurable Stock Not Updated After a Child is Back in Stock

Author: Anna Bukatar

dev/tests/integration/testsuite/Magento/CatalogInventory/Observer/SaveInventoryDataObserverTest.php

@@ -19,6 +19,8 @@
 use Magento\Framework\Exception\InputException;
 use Magento\Framework\Exception\StateException;
 use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\TestFramework\Fixture\DataFixtureStorage;
+use Magento\TestFramework\Fixture\DataFixtureStorageManager;
 
 /**
  * Test for SaveInventoryDataObserver
@@ -35,6 +37,11 @@ class SaveInventoryDataObserverTest extends TestCase
      */
     private $stockItemRepository;
 
+    /**
+     * @var DataFixtureStorage
+     */
+    private $fixtures;
+
     /**
      * @inheritDoc
      */
@@ -44,6 +51,7 @@ protected function setUp(): void
             ->get(ProductRepositoryInterface::class);
         $this->stockItemRepository = Bootstrap::getObjectManager()
             ->get(StockItemRepositoryInterface::class);
+        $this->fixtures = DataFixtureStorageManager::getStorage();
     }
 
     /**
@@ -66,7 +74,6 @@ public function testAutoChangingIsInStockForParent()
 
         /** @var ProductExtensionInterface $attributes*/
         $attributes = $product->getExtensionAttributes();
-
         /** @var StockItemInterface $stockItem */
         $stockItem = $attributes->getStockItem();
         $stockItem->setQty(0);
@@ -75,9 +82,29 @@ public function testAutoChangingIsInStockForParent()
         $product->setExtensionAttributes($attributes);
         $this->productRepository->save($product);
 
-        /** @var ProductInterface $product */
-        $parentProduct = $this->productRepository->get('configurable');
+         /** @var ProductInterface $product */
+         $parentProduct = $this->productRepository->get('configurable');
+
+         $parentProductStockItem = $this->stockItemRepository->get(
+             $parentProduct->getExtensionAttributes()->getStockItem()->getItemId()
+         );
+         $this->assertFalse($parentProductStockItem->getIsInStock());
+    }
 
+    /**
+     * Check that a configurable product will be created with out_of_stock status if no children in stock
+     *
+     * @magentoDataFixture Magento\Catalog\Test\Fixture\Product with:{"stock_item":{"qty": 0}} as:p1
+     * @magentoDataFixture Magento\ConfigurableProduct\Test\Fixture\Attribute as:attr
+     * @magentoDataFixture Magento\ConfigurableProduct\Test\Fixture\Product as:conf1
+     * @magentoDataFixtureDataProvider {"conf1":{"_options":["$attr$"],"_links":["$p1$"]}}
+     * @return void
+     */
+    public function testAutoChangingIsInStockForNewConfigurable(): void
+    {
+        $sku = $this->fixtures->get('conf1')->getSku();
+        /** @var ProductInterface $parentProduct */
+        $parentProduct = $this->productRepository->get($sku);
         $parentProductStockItem = $this->stockItemRepository->get(
             $parentProduct->getExtensionAttributes()->getStockItem()->getItemId()
         );

dev/tests/integration/testsuite/Magento/ConfigurableImportExport/Model/Import/Product/Type/ConfigurableTest.php

@@ -33,7 +33,7 @@ class ConfigurableTest extends TestCase
     /**
      * Configurable product test Type
      */
-    const TEST_PRODUCT_TYPE = 'configurable';
+    public const TEST_PRODUCT_TYPE = 'configurable';
 
     /**
      * @var \Magento\CatalogImportExport\Model\Import\Product
@@ -59,6 +59,39 @@ protected function setUp(): void
         $this->productMetadata = $metadataPool->getMetadata(ProductInterface::class);
     }
 
+    /**
+     * @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_products.php
+     */
+    public function testShouldUpdateConfigurableStockStatusIfChildProductsStockStatusChanged(): void
+    {
+        $sku = 'configurable';
+        /** @var ProductRepositoryInterface $productRepository */
+        $productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
+        /** @var ProductInterface $product */
+        $product = $productRepository->get($sku, true, null, true);
+        $stockItem = $this->getStockItem((int) $product->getId());
+        $this->assertNotNull($stockItem);
+        $this->assertTrue($stockItem->getIsInStock());
+
+        // Set all child product out of stock
+        $pathToFile = __DIR__ . '/../../_files/import_configurable_child_products_stock_item_status_out_of_stock.csv';
+        $errors = $this->doImport($pathToFile);
+        $this->assertEquals(0, $errors->getErrorsCount());
+
+        $stockItem = $this->getStockItem((int) $product->getId());
+        $this->assertNotNull($stockItem);
+        $this->assertFalse($stockItem->getIsInStock());
+
+        // Set some child product in stock
+        $pathToFile = __DIR__ . '/../../_files/import_configurable_child_products_stock_item_status_in_stock.csv';
+        $errors = $this->doImport($pathToFile);
+        $this->assertEquals(0, $errors->getErrorsCount());
+
+        $stockItem = $this->getStockItem((int) $product->getId());
+        $this->assertNotNull($stockItem);
+        $this->assertTrue($stockItem->getIsInStock());
+    }
+
     public function configurableImportDataProvider()
     {
         return [
@@ -202,39 +235,6 @@ public function testConfigurableImportWithStoreSpecifiedMainItem()
         }
     }
 
-    /**
-     * @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_products.php
-     */
-    public function testShouldUpdateConfigurableStockStatusIfChildProductsStockStatusChanged(): void
-    {
-        $sku = 'configurable';
-        /** @var ProductRepositoryInterface $productRepository */
-        $productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
-        /** @var ProductInterface $product */
-        $product = $productRepository->get($sku, true, null, true);
-        $stockItem = $this->getStockItem((int) $product->getId());
-        $this->assertNotNull($stockItem);
-        $this->assertTrue($stockItem->getIsInStock());
-
-        // Set all child product out of stock
-        $pathToFile = __DIR__ . '/../../_files/import_configurable_child_products_stock_item_status_out_of_stock.csv';
-        $errors = $this->doImport($pathToFile);
-        $this->assertEquals(0, $errors->getErrorsCount());
-
-        $stockItem = $this->getStockItem((int) $product->getId());
-        $this->assertNotNull($stockItem);
-        $this->assertFalse($stockItem->getIsInStock());
-
-        // Set some child product in stock
-        $pathToFile = __DIR__ . '/../../_files/import_configurable_child_products_stock_item_status_in_stock.csv';
-        $errors = $this->doImport($pathToFile);
-        $this->assertEquals(0, $errors->getErrorsCount());
-
-        $stockItem = $this->getStockItem((int) $product->getId());
-        $this->assertNotNull($stockItem);
-        $this->assertTrue($stockItem->getIsInStock());
-    }
-
     /**
      * @param int $productId
      * @return StockItemInterface|null