Skip to content

Commit 761059f

Browse files
author
Oleksandr Dubovyk
committed
MAGETWO-60127: [GITHUB] Number input fields have invalid 'maxlength' attribute #7125
1 parent ada45cc commit 761059f

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
<input type="number"
2121
name="qty"
2222
id="qty"
23-
maxlength="12"
2423
value="<?php /* @escapeNotVerified */ echo $block->getProductDefaultQty() * 1 ?>"
25-
title="<?php /* @escapeNotVerified */ echo __('Qty') ?>" class="input-text qty"
24+
title="<?php /* @escapeNotVerified */ echo __('Qty') ?>"
25+
class="input-text qty"
2626
data-validate="<?php echo $block->escapeHtml(json_encode($block->getQuantityValidators())) ?>"
2727
/>
2828
</div>
@@ -58,4 +58,4 @@
5858
}
5959
}
6060
</script>
61-
<?php endif; ?>
61+
<?php endif; ?>

app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,13 @@
1717
<div class="field qty">
1818
<label class="label" for="qty"><span><?php /* @escapeNotVerified */ echo __('Qty') ?></span></label>
1919
<div class="control">
20-
<input type="number" name="qty" id="qty" maxlength="12" value="" title="<?php /* @escapeNotVerified */ echo __('Qty') ?>" class="input-text qty" data-validate="{'required-number':true,digits:true}"/>
20+
<input type="number"
21+
name="qty"
22+
id="qty"
23+
value=""
24+
title="<?php /* @escapeNotVerified */ echo __('Qty') ?>"
25+
class="input-text qty"
26+
data-validate="{'required-number':true,digits:true}"/>
2127
</div>
2228
</div>
2329
<?php endif; ?>

app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ $canApplyMsrp = $helper->isShowBeforeOrderConfirm($product) && $helper->isMinima
9696
size="4"
9797
title="<?php echo $block->escapeHtml(__('Qty')); ?>"
9898
class="input-text qty"
99-
maxlength="12"
10099
data-validate="{required:true,'validate-greater-than-zero':true}"
101100
data-role="cart-item-qty"/>
102101
</div>

app/code/Magento/Checkout/view/frontend/web/template/minicart/item/default.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@
7979
}, value: qty"
8080
type="number"
8181
size="4"
82-
class="item-qty cart-item-qty"
83-
maxlength="12"/>
82+
class="item-qty cart-item-qty">
8483
<button data-bind="attr: {
8584
id: 'update-cart-item-'+item_id,
8685
'data-cart-item': item_id,

app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@
4646
<td data-th="<?php echo $block->escapeHtml(__('Qty')); ?>" class="col qty">
4747
<?php if ($_item->isSaleable()) : ?>
4848
<div class="control qty">
49-
<input type="number" name="super_group[<?php /* @escapeNotVerified */ echo $_item->getId() ?>]"
49+
<input type="number"
50+
name="super_group[<?php /* @escapeNotVerified */ echo $_item->getId() ?>]"
5051
data-selector="super_group[<?php /* @escapeNotVerified */ echo $_item->getId() ?>]"
51-
maxlength="12"
5252
value="<?php /* @escapeNotVerified */ echo $_item->getQty() * 1 ?>"
5353
title="<?php /* @escapeNotVerified */ echo __('Qty') ?>"
5454
class="input-text qty"

0 commit comments

Comments
 (0)