Skip to content

Commit 760d84c

Browse files
committed
PWA-1506: Billing address parameter 'same_as_shipping' cause error 'The shipping method is missing'
* Updated schema descriptions for "same_as_shipping" and "use_for_shipping"
1 parent 1b810ac commit 760d84c

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ input SetBillingAddressOnCartInput {
104104
input BillingAddressInput {
105105
customer_address_id: Int
106106
address: CartAddressInput
107-
use_for_shipping: Boolean @doc(description: "Deprecated: use `same_as_shipping` field instead")
108-
same_as_shipping: Boolean @doc(description: "Set billing address same as shipping")
107+
use_for_shipping: Boolean @doc(description: "Indicates whether to additionally set the shipping address based on the provided billing address")
108+
same_as_shipping: Boolean @doc(description: "Indicates whether to set the billing address based on the existing shipping address on the cart")
109109
}
110110

111111
input CartAddressInput {

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ public function testSetNewBillingAddress()
137137
/**
138138
* Tests that the "use_for_shipping" option sets the provided billing address for shipping as well.
139139
*
140-
* Note: the "use_for_shipping" option has been deprecated.
141-
*
142140
* @magentoApiDataFixture Magento/Customer/_files/customer.php
143141
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
144142
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetBillingAddressOnCartTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,6 @@ public function testSetNewBillingAddress()
9090
/**
9191
* Tests that the "use_for_shipping" option sets the provided billing address for shipping as well.
9292
*
93-
* Note: the "use_for_shipping" option has been deprecated.
94-
*
9593
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
9694
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
9795
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php

0 commit comments

Comments
 (0)