MAGETWO-36852: Code Coverage of South Modules

 - increase code coverage for Magento_Theme module

Author: AndriyNasinnyk

app/code/Magento/Theme/Test/Unit/Model/Theme/FileTest.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Theme\Test\Unit\Model\Theme;
 
+use Magento\Framework\View\Design\Theme\Customization\FileServiceFactory;
 use Magento\Framework\View\DesignInterface;
 use Magento\Theme\Model\Theme\File;
 
@@ -26,7 +27,7 @@ class FileTest extends \PHPUnit_Framework_TestCase
     protected $themeFactory;
 
     /**
-     * @var \Magento\Framework\View\Design\Theme\Customization\FileServiceFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var FileServiceFactory|\PHPUnit_Framework_MockObject_MockObject
      */
     protected $fileServiceFactory;
 

app/code/Magento/Theme/Test/Unit/Model/Theme/RegistrationTest.php

@@ -50,6 +50,11 @@ public function setUp()
         );
     }
 
+    /**
+     * @test
+     * @return void
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
     public function testRegister()
     {
         $image = 'preview.jpg';

app/code/Magento/Theme/Test/Unit/Model/Theme/ThemeProviderTest.php

@@ -62,8 +62,10 @@ public function testGetThemeCustomizations()
     {
         $collectionFactory = $this->getMockBuilder('Magento\Theme\Model\Resource\Theme\CollectionFactory')
             ->setMethods(['create'])
+            ->disableOriginalConstructor()
             ->getMock();
         $themeFactory = $this->getMockBuilder('Magento\Theme\Model\ThemeFactory')
+            ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();
         $collection = $this->getMockBuilder('Magento\Theme\Model\Resource\Theme\Collection')

app/code/Magento/Theme/Test/Unit/Model/ThemeTest.php

@@ -299,7 +299,7 @@ public function testAfterDelete()
         $this->resourceCollection->expects($this->at(0))
             ->method('addFieldToFilter')
             ->with('parent_id', 1)
-            ->willReturnSelf();;
+            ->willReturnSelf();
         $this->resourceCollection->expects($this->at(1))
             ->method('addFieldToFilter')
             ->with('type', Theme::TYPE_STAGING)
@@ -331,7 +331,7 @@ public function testGetStagingVersion()
         $this->resourceCollection->expects($this->at(0))
             ->method('addFieldToFilter')
             ->with('parent_id', 1)
-            ->willReturnSelf();;
+            ->willReturnSelf();
         $this->resourceCollection->expects($this->at(1))
             ->method('addFieldToFilter')
             ->with('type', Theme::TYPE_STAGING)

app/code/Magento/Theme/Test/Unit/Model/Wysiwyg/StorageTest.php

@@ -466,7 +466,6 @@ public function testDeleteFile()
     {
         $image = 'image.jpg';
         $storagePath = $this->_storageRoot;
-        $imagePath = $storagePath . '/' . $image;
 
         $this->_helperStorage->expects($this->once())
             ->method('getCurrentPath')