B2B-2606: Graphql Parser called at least 3 times per request

joanhe · joanhe · commit 758f2aa7182a · 2023-04-13T09:25:10.000-05:00
diff --git a/dev/tests/integration/testsuite/Magento/GraphQl/Controller/HttpRequestValidator/HttpVerbValidatorTest.php b/dev/tests/integration/testsuite/Magento/GraphQl/Controller/HttpRequestValidator/HttpVerbValidatorTest.php
@@ -17,7 +17,7 @@
 class HttpVerbValidatorTest extends TestCase
 {
     /**
-     * @var HttpVerbValidator|MockObject
+     * @var HttpVerbValidator
      */
     private $httpVerbValidator;
 
diff --git a/lib/internal/Magento/Framework/GraphQl/Query/QueryParser.php b/lib/internal/Magento/Framework/GraphQl/Query/QueryParser.php
@@ -32,7 +32,7 @@ public function parse(string $query): DocumentNode
     {
         $cacheKey = sha1($query);
         if (!isset($this->parsedQueries[$cacheKey])) {
-            $this->parsedQueries[$cacheKey] = Parser::parse(new Source($query ?: '', 'GraphQL'));
+            $this->parsedQueries[$cacheKey] = Parser::parse(new Source($query, 'GraphQL'));
         }
         return $this->parsedQueries[$cacheKey];
     }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`class HttpVerbValidatorTest extends TestCase`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`		`- * @var HttpVerbValidator\|MockObject`
	`20`	`+ * @var HttpVerbValidator`
`21`	`21`	`*/`
`22`	`22`	`private $httpVerbValidator;`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function parse(string $query): DocumentNode`
`32`	`32`	`{`
`33`	`33`	`$cacheKey = sha1($query);`
`34`	`34`	`if (!isset($this->parsedQueries[$cacheKey])) {`
`35`		`- $this->parsedQueries[$cacheKey] = Parser::parse(new Source($query ?: '', 'GraphQL'));`
	`35`	`+ $this->parsedQueries[$cacheKey] = Parser::parse(new Source($query, 'GraphQL'));`
`36`	`36`	`}`
`37`	`37`	`return $this->parsedQueries[$cacheKey];`
`38`	`38`	`}`