Skip to content

Commit 756be11

Browse files
committed
B2B-1876: New directories in pub/media do not get synced back to local filesystem from S3 Remote Storage
- address code review comment
1 parent 20ee0c8 commit 756be11

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

app/code/Magento/RemoteStorage/Model/Filesystem/Directory/WriteFactory.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use Magento\Framework\Filesystem\Directory\DenyListPathValidator;
1010
use Magento\Framework\Filesystem\Directory\PathValidator;
1111
use Magento\Framework\Filesystem\Directory\WriteFactory as BaseWriteFactory;
12+
use Magento\Framework\Filesystem\DriverPool as BaseDriverPool;
1213
use Magento\RemoteStorage\Driver\DriverPool;
1314
use Magento\Framework\ObjectManagerInterface;
1415

@@ -27,19 +28,19 @@ class WriteFactory extends BaseWriteFactory
2728
/**
2829
* Pool of filesystem drivers
2930
*
30-
* @var DriverPool
31+
* @var BaseDriverPool
3132
*/
3233
private $driverPool;
3334

3435
/**
3536
* WriteFactory constructor.
3637
*
3738
* @param ObjectManagerInterface $objectManager
38-
* @param DriverPool $driverPool
39+
* @param BaseDriverPool $driverPool
3940
*/
4041
public function __construct(
4142
ObjectManagerInterface $objectManager,
42-
DriverPool $driverPool
43+
BaseDriverPool $driverPool
4344
) {
4445
$this->objectManager = $objectManager;
4546
$this->driverPool = $driverPool;

app/code/Magento/RemoteStorage/etc/di.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<preference for="Magento\RemoteStorage\Driver\Adapter\CachedAdapterInterface" type="Magento\RemoteStorage\Driver\Adapter\CachedAdapter"/>
1111
<preference for="Magento\RemoteStorage\Driver\Adapter\MetadataProviderInterface" type="Magento\RemoteStorage\Driver\Adapter\MetadataProvider"/>
1212
<preference for="Magento\RemoteStorage\Driver\Adapter\MetadataProviderFactoryInterface" type="Magento\RemoteStorage\Driver\Adapter\MetadataProviderFactory"/>
13+
<preference for="Magento\Framework\Filesystem\DriverPool" type="Magento\RemoteStorage\Driver\DriverPool"/>
1314
<virtualType name="remoteWriteFactory" type="Magento\Framework\Filesystem\Directory\WriteFactory">
1415
<arguments>
1516
<argument name="driverPool" xsi:type="object">Magento\RemoteStorage\Driver\DriverPool</argument>
@@ -20,11 +21,6 @@
2021
<argument name="driverPool" xsi:type="object">Magento\RemoteStorage\Driver\DriverPool</argument>
2122
</arguments>
2223
</virtualType>
23-
<type name="Magento\Framework\Filesystem\Directory\ReadFactory">
24-
<arguments>
25-
<argument name="driverPool" xsi:type="object">Magento\RemoteStorage\Driver\DriverPool</argument>
26-
</arguments>
27-
</type>
2824
<type name="Magento\RemoteStorage\Filesystem">
2925
<arguments>
3026
<argument name="writeFactory" xsi:type="object">

0 commit comments

Comments
 (0)