🔃 [EngCom] Public Pull Requests - 2.3-develop

magento-engcom-team · web-flow · commit 75326202c7b8 · 2018-05-25T10:15:07.000+03:00
Accepted Public Pull Requests: - #15466: [Forwardport] typo correction (by @mzeis) - #15450: ADHOC: update the contribution templates to include a note on results (by @dmanners)
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -28,8 +28,8 @@
 
 ### Expected result
 <!--- Tell us what should happen -->
-1. [Screenshot, logs]
+1. [Screenshots, logs or description]
 
 ### Actual result
 <!--- Tell us what happens instead -->
-1. [Screenshot, logs]
+1. [Screenshots, logs or description]
diff --git a/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php b/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php
@@ -1570,7 +1570,7 @@ protected function getEntityPkName(\Magento\Eav\Model\Entity\AbstractEntity $ent
     }
 
     /**
-     * Add requere tax percent flag for product collection
+     * Add require tax percent flag for product collection
      *
      * @return $this
      */

Original file line number	Diff line number	Diff line change
`@@ -1570,7 +1570,7 @@ protected function getEntityPkName(\Magento\Eav\Model\Entity\AbstractEntity $ent`
`1570`	`1570`	`}`
`1571`	`1571`
`1572`	`1572`	`/**`
`1573`		`- * Add requere tax percent flag for product collection`
	`1573`	`+ * Add require tax percent flag for product collection`
`1574`	`1574`	`*`
`1575`	`1575`	`* @return $this`
`1576`	`1576`	`*/`