MAGETWO-31931: Implement ExtensionInterface Code Generator

- Added extension interface generator
- Refactored usages of _getFullyQualifiedClassName
- Fixed namespace name generation

Author: Alexander Paliarush

dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceFactory.php.sample

@@ -29,7 +29,7 @@ class SourceClassWithNamespaceFactory
      * @param \Magento\Framework\ObjectManagerInterface $objectManager
      * @param string $instanceName
      */
-    public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\\Framework\\Code\\GeneratorTest\\SourceClassWithNamespace')
+    public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = '\\Magento\\Framework\\Code\\GeneratorTest\\SourceClassWithNamespace')
     {
         $this->_objectManager = $objectManager;
         $this->_instanceName = $instanceName;

dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceProxy.php.sample

@@ -44,7 +44,7 @@ class Proxy extends \Magento\Framework\Code\GeneratorTest\SourceClassWithNamespa
      * @param string $instanceName
      * @param bool $shared
      */
-    public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\\Framework\\Code\\GeneratorTest\\SourceClassWithNamespace', $shared = true)
+    public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = '\\Magento\\Framework\\Code\\GeneratorTest\\SourceClassWithNamespace', $shared = true)
     {
         $this->_objectManager = $objectManager;
         $this->_instanceName = $instanceName;

dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php

@@ -14,6 +14,7 @@
 use Magento\Framework\ObjectManager\Code\Generator\Converter;
 use Magento\Framework\ObjectManager\Code\Generator\Factory;
 use Magento\Framework\ObjectManager\Code\Generator\Repository;
+use Magento\Framework\Api\Code\Generator\ObjectExtensionInterface;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -326,7 +327,9 @@ public function testConstructorIntegrity()
                 Repository::ENTITY_TYPE => 'Magento\Framework\ObjectManager\Code\Generator\Repository',
                 Converter::ENTITY_TYPE => 'Magento\Framework\ObjectManager\Code\Generator\Converter',
                 Mapper::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\Mapper',
-                SearchResults::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\SearchResults'
+                SearchResults::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\SearchResults',
+                ObjectExtensionInterface::ENTITY_TYPE =>
+                    'Magento\Framework\Api\Code\Generator\ObjectExtensionInterface'
             ]
         );
         $generationAutoloader = new \Magento\Framework\Code\Generator\Autoloader($generator);

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/ExtensionInterfaceGeneratorTest.php

@@ -0,0 +1,75 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Framework\Api\Code\Generator;
+
+class ExtensionInterfaceGeneratorTest extends \PHPUnit_Framework_TestCase
+{
+    public function testGenerate()
+    {
+        $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+        $configReaderMock = $this->getMockBuilder('Magento\Framework\Api\Config\Reader')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $configReaderMock->expects($this->any())
+            ->method('read')
+            ->willReturn(
+                [
+                    'Magento\Catalog\Api\Data\ProductInterface' => [
+                        'string_attribute' => 'string',
+                        'complex_object_attribute' => '\Magento\Bundle\Api\Data\OptionInterface[]'
+                    ],
+                    'Magento\Catalog\Api\Data\Product' => [
+                        'should_not_include' => 'string',
+                    ],
+                ]
+            );
+
+        /** @var \Magento\Framework\Api\Code\Generator\ObjectExtensionInterface $model */
+        $model = $objectManager->getObject(
+            'Magento\Framework\Api\Code\Generator\ObjectExtensionInterface',
+            [
+                'configReader' => $configReaderMock,
+                'sourceClassName' => '\Magento\Catalog\Api\Data\Product',
+                'resultClassName' => '\Magento\Catalog\Api\Data\ProductExtensionInterface',
+                'classGenerator' => null
+            ]
+        );
+        $expectedResult = file_get_contents(__DIR__ . '/_files/SampleExtensionInterface.txt');
+        $reflectionObject = new \ReflectionObject($model);
+        $reflectionMethod = $reflectionObject->getMethod('_generateCode');
+        $reflectionMethod->setAccessible(true);
+        $generatedCode = $reflectionMethod->invoke($model);
+        $this->assertEquals($expectedResult, $generatedCode);
+    }
+
+    public function testValidateException()
+    {
+        $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+        /** @var \Magento\Framework\Api\Code\Generator\ObjectExtensionInterface $model */
+        $model = $objectManager->getObject(
+            'Magento\Framework\Api\Code\Generator\ObjectExtensionInterface',
+            [
+                'sourceClassName' => '\Magento\Catalog\Api\Data\Product',
+                'resultClassName' => '\Magento\Catalog\Api\Data\ProductInterface'
+            ]
+        );
+        $reflectionObject = new \ReflectionObject($model);
+        $reflectionMethod = $reflectionObject->getMethod('_validateData');
+        $reflectionMethod->setAccessible(true);
+
+        $expectedValidationResult = false;
+        $this->assertEquals($expectedValidationResult, $reflectionMethod->invoke($model));
+        $this->assertTrue(
+            in_array(
+                'Invalid extension interface name [\Magento\Catalog\Api\Data\ProductInterface].'
+                    . ' Use \Magento\Catalog\Api\Data\ProductExtensionInterface',
+                $model->getErrors()
+            ),
+            'Expected validation error message is missing.'
+        );
+    }
+}

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/SampleBuilder.txt

@@ -1,4 +1,4 @@
-namespace \Magento\Framework\Api\Code\Generator;
+namespace Magento\Framework\Api\Code\Generator;
 
 /**
  * Builder class for @see \Magento\Framework\Api\Code\Generator\Sample

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/SampleExtensionInterface.txt

@@ -0,0 +1,17 @@
+namespace Magento\Catalog\Api\Data;
+
+/**
+ * ExtensionInterface class for @see \Magento\Catalog\Api\Data\ProductInterface
+ */
+interface ProductExtensionInterface
+{
+    /**
+     * @return string
+     */
+    public function getStringAttribute();
+
+    /**
+     * @return \Magento\Bundle\Api\Data\OptionInterface[]
+     */
+    public function getComplexObjectAttribute();
+}

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/SampleMapper.txt

@@ -1,4 +1,4 @@
-namespace \Magento\Framework\Api\Code\Generator;
+namespace Magento\Framework\Api\Code\Generator;
 
 /**
  * Mapper class for @see \Magento\Framework\Api\Code\Generator\Sample
@@ -13,7 +13,7 @@ class SampleMapper
     protected $sampleBuilder = null;
 
     /**
-     * Magento\Framework\Api\Code\Generator\Sample[]
+     * \Magento\Framework\Api\Code\Generator\Sample[]
      *
      * @var array
      */

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/SampleSearchResults.txt

@@ -1,4 +1,4 @@
-namespace \Magento\Framework\Api\Code\Generator;
+namespace Magento\Framework\Api\Code\Generator;
 
 class SampleSearchResults extends \Magento\Framework\Api\SearchResults
 {

dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/SampleSearchResultsBuilder.txt

@@ -1,4 +1,4 @@
-namespace \Magento\Framework\Api\Code\Generator;
+namespace Magento\Framework\Api\Code\Generator;
 
 /**
  * SearchResultsBuilder class for @see \Magento\Framework\Api\Code\Generator\Sample

dev/tests/unit/testsuite/Magento/Framework/Code/Generator/EntityAbstractTest.php

@@ -10,9 +10,9 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
     /**#@+
      * Source and result class parameters
      */
-    const SOURCE_CLASS = 'Magento\Framework\Object';
+    const SOURCE_CLASS = '\Magento\Framework\Object';
 
-    const RESULT_CLASS = 'Magento\Framework\Object_MyResult';
+    const RESULT_CLASS = '\Magento\Framework\Object_MyResult';
 
     const RESULT_FILE = 'MyResult/MyResult.php';