MAGETWO-31855: UI improvements

- removed mixins with rem dublicating functionality.

Author: Oleg Zinoviev

lib/web/css/source/lib/resets.less

@@ -43,10 +43,9 @@
 
     img {
         border: 0;
-        max-width: 100%;
-        height: auto;
     }
 
+    img,
     object,
     video,
     embed {

lib/web/css/source/lib/typography.less

@@ -23,10 +23,8 @@
 
 //  Rem font size
 .font-size(@sizeValue) when not (ispercentage(@sizeValue)) and not (@sizeValue = false) {
-    @value: unit(@sizeValue);
-    @remValue: (@value / @font-rem-ratio);
-    @pxValue: @value;
-    font-size: ~"@{remValue}rem";
+    .to-rem(@sizeValue);
+    font-size: @valueRem;
 }
 
 .font-size(@sizeValue) when (ispercentage(@sizeValue)) and not (@sizeValue = false) {
@@ -35,10 +33,8 @@
 
 //  Rem line height
 .line-height(@heightValue) when not (@heightValue = false) and not (ispercentage(@heightValue)) {
-    @value: unit(@heightValue);
-    @remValue: (@value / @font-rem-ratio);
-    @pxValue: @value;
-    line-height: ~"@{remValue}rem";
+    .to-rem(@heightValue);
+    line-height: @valueRem;
 }
 
 .line-height(@heightValue) when (ispercentage(@heightValue)) and not (@heightValue = false) {
@@ -147,7 +143,14 @@
         @@_line-height,
         @@_font-style
     );
-    .margin-vertical-rem(@@_margin-top, @@_margin-bottom);
+    & {
+        .to-rem(@@_margin-top);
+        margin-top: @valueRem;
+    }
+    & {
+        .to-rem(@@_margin-bottom);
+        margin-bottom: @valueRem;
+    }
 }
 
 //
@@ -165,7 +168,14 @@
     }
 
     p {
-        .margin-vertical-rem(@p-margin-top, @p-margin-bottom);
+        & {
+            .to-rem(@p-margin-top);
+            margin-top: @valueRem;
+        }
+        & {
+            .to-rem(@p-margin-bottom);
+            margin-bottom: @valueRem;
+        }
     }
 
     // Abbreviations and acronyms
@@ -279,10 +289,24 @@
 .typography-lists() {
     ul,
     ol {
-        .margin-vertical-rem(@list-margin-top, @list-margin-bottom);
+        & {
+            .to-rem(@list-margin-top);
+            margin-top: @valueRem;
+        }
+        & {
+            .to-rem(@list-margin-bottom);
+            margin-bottom: @valueRem;
+        }
         //.typography(@list-font-size-base, @list-color-base);
         > li {
-            .margin-vertical-rem(@list-item-margin-top, @list-item-margin-bottom);
+            & {
+                .to-rem(@list-item-margin-top);
+                margin-top: @valueRem;
+            }
+            & {
+                .to-rem(@list-item-margin-bottom);
+                margin-bottom: @valueRem;
+            }
         }
         ul,
         ol {

lib/web/css/source/lib/utilities.less

@@ -2,42 +2,11 @@
 //  * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
 //  */
 
-.margin-top-rem(
-    @value
-) when not (@value = false) and not (@value = '') {
-    @_value: unit(@value);
-    margin-top: @_value * 1rem / @font-rem-ratio;
-}
-
-.margin-bottom-rem(
-    @value
-) when not (@value = false) and not (@value = '') {
-    @_value: unit(@value);
-    margin-bottom: @_value * 1rem / @font-rem-ratio;
-}
-
-.margin-vertical-rem(@val-top, @val-bottom) {
-    .margin-top-rem(@val-top);
-    .margin-bottom-rem(@val-bottom);
-}
-
-.padding-top-rem(
-    @value
-) when not (@value = false) and not (@value = '') {
-    @_value: unit(@value);
-    padding-top: @_value * 1rem / @font-rem-ratio;
-}
-
-.padding-bottom-rem(
-    @value
-) when not (@value = false) and not (@value = '') {
-    @_value: unit(@value);
-    padding-bottom: @_value * 1rem / @font-rem-ratio;
-}
-
-.padding-vertical-rem(@val-top, @val-bottom) {
-    .padding-top-rem(@val-top);
-    .padding-bottom-rem(@val-bottom);
+// convert to rem
+.to-rem(
+    @_value
+) when not (@_value = false) and not (@_value = '') {
+    @valueRem: (unit(@_value) * 1rem) / @font-rem-ratio;
 }
 
 .visibility-hidden() {