Merge remote-tracking branch 'mainline/develop' into falcons-develop

Bohdan Korablov · Bohdan Korablov · commit 742e09782943 · 2016-07-27T12:11:17.000+03:00
diff --git a/app/code/Magento/Authorizenet/Controller/Directpost/Payment/Place.php b/app/code/Magento/Authorizenet/Controller/Directpost/Payment/Place.php
@@ -131,7 +131,10 @@ protected function placeCheckoutOrder()
             $result->setData('error_messages', $exception->getMessage());
         } catch (\Exception $exception) {
             $result->setData('error', true);
-            $result->setData('error_messages', __('Unable to place order. Please try again later.'));
+            $result->setData(
+                'error_messages',
+                __('An error occurred on the server. Please try to place the order again.')
+            );
         }
         if ($response instanceof Http) {
             $response->representJson($this->jsonHelper->jsonEncode($result));
diff --git a/app/code/Magento/Authorizenet/Test/Unit/Controller/Directpost/Payment/PlaceTest.php b/app/code/Magento/Authorizenet/Test/Unit/Controller/Directpost/Payment/PlaceTest.php
@@ -280,7 +280,10 @@ public function textExecuteFailedPlaceOrderDataProvider()
     {
         $objectFailed = new \Magento\Framework\DataObject();
         $objectFailed->setData('error', true);
-        $objectFailed->setData('error_messages', __('Unable to place order. Please try again later.'));
+        $objectFailed->setData(
+            'error_messages',
+            __('An error occurred on the server. Please try to place the order again.')
+        );
 
         return [
             [
diff --git a/app/code/Magento/Authorizenet/i18n/en_US.csv b/app/code/Magento/Authorizenet/i18n/en_US.csv
@@ -2,7 +2,7 @@
 "Order saving error: %1","Order saving error: %1"
 "Please choose a payment method.","Please choose a payment method."
 "We can\'t process your order right now. Please try again later.","We can\'t process your order right now. Please try again later."
-"Unable to place order. Please try again later.","Unable to place order. Please try again later."
+"An error occurred on the server. Please try to place the order again.","An error occurred on the server. Please try to place the order again."
 "Credit Card: xxxx-%1","Credit Card: xxxx-%1"
 "amount %1","amount %1"
 failed.,failed.
diff --git a/app/code/Magento/Checkout/Model/GuestPaymentInformationManagement.php b/app/code/Magento/Checkout/Model/GuestPaymentInformationManagement.php
@@ -80,7 +80,10 @@ public function savePaymentInformationAndPlaceOrder(
         try {
             $orderId = $this->cartManagement->placeOrder($cartId);
         } catch (\Exception $e) {
-            throw new CouldNotSaveException(__('Unable to place order. Please try again later.'), $e);
+            throw new CouldNotSaveException(
+                __('An error occurred on the server. Please try to place the order again.'),
+                $e
+            );
         }
         return $orderId;
     }
diff --git a/app/code/Magento/Checkout/Model/PaymentInformationManagement.php b/app/code/Magento/Checkout/Model/PaymentInformationManagement.php
@@ -68,7 +68,10 @@ public function savePaymentInformationAndPlaceOrder(
         try {
             $orderId = $this->cartManagement->placeOrder($cartId);
         } catch (\Exception $e) {
-            throw new CouldNotSaveException(__('Unable to place order. Please try again later.'), $e);
+            throw new CouldNotSaveException(
+                __('An error occurred on the server. Please try to place the order again.'),
+                $e
+            );
         }
         return $orderId;
     }
diff --git a/app/code/Magento/Checkout/Test/Unit/Model/GuestPaymentInformationManagementTest.php b/app/code/Magento/Checkout/Test/Unit/Model/GuestPaymentInformationManagementTest.php
@@ -93,7 +93,7 @@ public function testSavePaymentInformationAndPlaceOrder()
     }
 
     /**
-     * @expectedExceptionMessage Unable to place order. Please try again later.
+     * @expectedExceptionMessage An error occurred on the server. Please try to place the order again.
      * @expectedException \Magento\Framework\Exception\CouldNotSaveException
      */
     public function testSavePaymentInformationAndPlaceOrderException()
diff --git a/app/code/Magento/Checkout/Test/Unit/Model/PaymentInformationManagementTest.php b/app/code/Magento/Checkout/Test/Unit/Model/PaymentInformationManagementTest.php
@@ -70,7 +70,7 @@ public function testSavePaymentInformationAndPlaceOrder()
     }
 
     /**
-     * @expectedExceptionMessage Unable to place order. Please try again later.
+     * @expectedExceptionMessage An error occurred on the server. Please try to place the order again.
      * @expectedException \Magento\Framework\Exception\CouldNotSaveException
      */
     public function testSavePaymentInformationAndPlaceOrderException()
diff --git a/app/code/Magento/Checkout/i18n/en_US.csv b/app/code/Magento/Checkout/i18n/en_US.csv
@@ -40,7 +40,7 @@ Checkout,Checkout
 "This quote item does not exist.","This quote item does not exist."
 "Display number of items in cart","Display number of items in cart"
 "Display item quantities","Display item quantities"
-"Unable to place order. Please try again later.","Unable to place order. Please try again later."
+"An error occurred on the server. Please try to place the order again.","An error occurred on the server. Please try to place the order again."
 "Shipping address is not set","Shipping address is not set"
 "Unable to save address. Please check input data.","Unable to save address. Please check input data."
 "Carrier with such method not found: %1, %2","Carrier with such method not found: %1, %2"
diff --git a/app/code/Magento/Config/view/adminhtml/templates/page/system/config/robots/reset.phtml b/app/code/Magento/Config/view/adminhtml/templates/page/system/config/robots/reset.phtml
@@ -16,14 +16,14 @@ $jsonHelper = $this->helper('Magento\Framework\Json\Helper\Data');
 
 <script>
     require([
-        'prototype'
-    ], function () {
+        'jquery'
+    ], function ($) {
         window.resetRobotsToDefault = function(){
-            $('design_search_engine_robots_custom_instructions').value = <?php
+            $('#design_search_engine_robots_custom_instructions').val(<?php
                 /* @escapeNotVerified */ echo $jsonHelper->jsonEncode($block->getRobotsDefaultCustomInstructions())
-            ?>;
+            ?>);
         }
     });
 </script>
 
-<?php echo $block->getButtonHtml() ?>
+<?php echo $block->getButtonHtml(); ?>
diff --git a/app/code/Magento/Customer/Controller/Account/LoginPost.php b/app/code/Magento/Customer/Controller/Account/LoginPost.php
@@ -13,6 +13,7 @@
 use Magento\Framework\Exception\EmailNotConfirmedException;
 use Magento\Framework\Exception\AuthenticationException;
 use Magento\Framework\Data\Form\FormKey\Validator;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\State\UserLockedException;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 
@@ -179,6 +180,10 @@ public function execute()
                     $message = __('Invalid login or password.');
                     $this->messageManager->addError($message);
                     $this->session->setUsername($login['username']);
+                } catch (LocalizedException $e) {
+                    $message = $e->getMessage();
+                    $this->messageManager->addError($message);
+                    $this->session->setUsername($login['username']);
                 } catch (\Exception $e) {
                     // PA DSS violation: throwing or logging an exception here can disclose customer password
                     $this->messageManager->addError(
diff --git a/app/code/Magento/Customer/Controller/Ajax/Login.php b/app/code/Magento/Customer/Controller/Ajax/Login.php
@@ -12,6 +12,7 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Customer\Model\Account\Redirect as AccountRedirect;
 use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\Exception\LocalizedException;
 
 /**
  * Login controller
@@ -182,6 +183,11 @@ public function execute()
                 'errors' => true,
                 'message' => $e->getMessage()
             ];
+        } catch (LocalizedException $e) {
+            $response = [
+                'errors' => true,
+                'message' => $e->getMessage()
+            ];
         } catch (\Exception $e) {
             $response = [
                 'errors' => true,
diff --git a/app/code/Magento/Payment/view/frontend/templates/transparent/iframe.phtml b/app/code/Magento/Payment/view/frontend/templates/transparent/iframe.phtml
@@ -39,7 +39,7 @@ $params = $block->getParams();
                     var parent = window.top;
                     $(parent).trigger('clearTimeout');
                     globalMessageList.addErrorMessage({
-                        message: $t('Unable to place order. Please try again later.')
+                        message: $t('An error occurred on the server. Please try to place the order again.')
                     });
                 }
             );
diff --git a/app/code/Magento/Quote/Model/QuoteManagement.php b/app/code/Magento/Quote/Model/QuoteManagement.php
@@ -349,7 +349,9 @@ public function placeOrder($cartId, PaymentInterface $paymentMethod = null)
         $order = $this->submit($quote);
 
         if (null == $order) {
-            throw new LocalizedException(__('Unable to place order. Please try again later.'));
+            throw new LocalizedException(
+                __('An error occurred on the server. Please try to place the order again.')
+            );
         }
 
         $this->checkoutSession->setLastQuoteId($quote->getId());
diff --git a/app/code/Magento/Quote/i18n/en_US.csv b/app/code/Magento/Quote/i18n/en_US.csv
@@ -36,7 +36,7 @@ Subtotal,Subtotal
 "Cannot assign customer to the given cart. The cart belongs to different store.","Cannot assign customer to the given cart. The cart belongs to different store."
 "Cannot assign customer to the given cart. The cart is not anonymous.","Cannot assign customer to the given cart. The cart is not anonymous."
 "Cannot assign customer to the given cart. Customer already has active cart.","Cannot assign customer to the given cart. Customer already has active cart."
-"Unable to place order. Please try again later.","Unable to place order. Please try again later."
+"An error occurred on the server. Please try to place the order again.","An error occurred on the server. Please try to place the order again."
 "This item price or quantity is not valid for checkout.","This item price or quantity is not valid for checkout."
 "Please check the shipping address information. %1","Please check the shipping address information. %1"
 "Please specify a shipping method.","Please specify a shipping method."
diff --git a/app/code/Magento/Theme/view/frontend/templates/html/print.phtml b/app/code/Magento/Theme/view/frontend/templates/html/print.phtml
@@ -5,7 +5,14 @@
  */
 ?>
 <script>
-    jQuery(function() {
-        window.print();
-    });
+    require(
+        [
+            'jquery'
+        ],
+        function($) {
+            $(function() {
+                window.print();
+            });
+        }
+    );
 </script>
diff --git a/app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js b/app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js
@@ -380,7 +380,7 @@ define([
         },
 
         /**
-         * Change page to previos
+         * Change page to previous
          */
         previousPage: function () {
             this.currentPage(this.currentPage() - 1);
diff --git a/app/code/Magento/Ui/view/base/web/js/form/element/region.js b/app/code/Magento/Ui/view/base/web/js/form/element/region.js
@@ -36,7 +36,7 @@ define([
                 this.validation['required-entry'] = false;
                 this.required(false);
             } else {
-                if (!option['is_region_required']) {
+                if (option && !option['is_region_required']) {
                     this.error(false);
                     this.validation = _.omit(this.validation, 'required-entry');
                 } else {
diff --git a/app/code/Magento/Widget/view/adminhtml/templates/instance/js.phtml b/app/code/Magento/Widget/view/adminhtml/templates/instance/js.phtml
@@ -8,22 +8,19 @@
 require([
     'jquery',
     'mage/template',
-    'prototype'
-], function(jQuery, mageTemplate){
+], function($, mageTemplate){
 
 setSettings = function(urlTemplate, codeElement, themeElement) {
     var url;
 
-    if (!jQuery('#edit_form').valid()) {
+    if (!$('#edit_form').valid()) {
         return false;
     }
-    codeElement = $F(codeElement);
-    themeElement = $F(themeElement);
 
     url = mageTemplate(urlTemplate, {
         data: {
-            'code': codeElement,
-            'theme_id': themeElement
+            'code': $('#' + codeElement).val(),
+            'theme_id': $('#' + themeElement).val()
         }
     });
 
diff --git a/dev/tests/js/jasmine/tests/lib/mage/gallery.test.js b/dev/tests/js/jasmine/tests/lib/mage/gallery.test.js
@@ -99,7 +99,7 @@ define([
             expect($(navSelector + ':eq(1)').attr('data-active') === 'true').toBeTruthy();
         });
 
-        it('show previos', function () {
+        it('show previous', function () {
             galleryAPI.prev();
             expect($(navSelector + ':eq(0)').attr('data-active') === 'true').toBeTruthy();
         });
diff --git a/lib/web/mage/backend/validation.js b/lib/web/mage/backend/validation.js
@@ -202,7 +202,7 @@
          * @protected
          */
         _onError: function() {
-            this.trigger('processStop');
+            $('body').trigger('processStop');
             
             if (this.options.errorUrl) {
                 location.href = this.options.errorUrl;
diff --git a/lib/web/mage/gallery/gallery.html b/lib/web/mage/gallery/gallery.html
@@ -8,7 +8,7 @@
     <div data-gallery-role="fotorama__focusable-start" tabindex="-1"></div>
     <div class="fotorama__wrap fotorama__wrap--css3 fotorama__wrap--slide fotorama__wrap--toggle-arrows">
         <div class="fotorama__stage" data-fotorama-stage="fotorama__stage">
-            <div class="fotorama__arr fotorama__arr--prev" tabindex="0" role="button" aria-label="Previos" data-gallery-role="arrow">
+            <div class="fotorama__arr fotorama__arr--prev" tabindex="0" role="button" aria-label="Previous" data-gallery-role="arrow">
                 <div class="fotorama__arr__arr"></div>
             </div>
             <div class="fotorama__stage__shaft" tabindex="0" data-gallery-role="stage-shaft">
@@ -25,7 +25,7 @@
         <div class="fotorama__nav-wrap" data-gallery-role="nav-wrap">
             <div class="fotorama__nav fotorama__nav--thumbs">
                 <div class="fotorama__fullscreen-icon" data-gallery-role="fotorama__fullscreen-icon" tabindex="0" aria-label="Exit fullscreen" role="button"></div>
-                <div class="fotorama__thumb__arr fotorama__thumb__arr--left" role="button" aria-label="Previos" data-gallery-role="arrow" tabindex = "-1">
+                <div class="fotorama__thumb__arr fotorama__thumb__arr--left" role="button" aria-label="Previous" data-gallery-role="arrow" tabindex = "-1">
                     <div class="fotorama__thumb--icon"></div>
                 </div>
                 <div class="fotorama__nav__shaft">
diff --git a/lib/web/mage/utils/misc.js b/lib/web/mage/utils/misc.js
@@ -38,6 +38,7 @@ define([
         'EEEE': 'dddd',
         'EEE': 'ddd',
         'e': 'd',
+        'yyyy': 'YYYY',
         'y': 'YYYY',
         'a': 'A'
     };
diff --git a/lib/web/mage/validation.js b/lib/web/mage/validation.js
@@ -326,7 +326,7 @@
         ],
         "stripped-min-length": [
             function (value, element, param) {
-                return $(value).text().length >= param;
+                return value.length >= param;
             },
             'Please enter at least {0} characters'
         ],

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,10 @@ public function textExecuteFailedPlaceOrderDataProvider()`
`280`	`280`	`{`
`281`	`281`	`$objectFailed = new \Magento\Framework\DataObject();`
`282`	`282`	`$objectFailed->setData('error', true);`
`283`		`- $objectFailed->setData('error_messages', __('Unable to place order. Please try again later.'));`
	`283`	`+ $objectFailed->setData(`
	`284`	`+ 'error_messages',`
	`285`	`+ __('An error occurred on the server. Please try to place the order again.')`
	`286`	`+ );`
`284`	`287`
`285`	`288`	`return [`
`286`	`289`	`[`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,10 @@ public function savePaymentInformationAndPlaceOrder(`
`80`	`80`	`try {`
`81`	`81`	`$orderId = $this->cartManagement->placeOrder($cartId);`
`82`	`82`	`} catch (\Exception $e) {`
`83`		`- throw new CouldNotSaveException(__('Unable to place order. Please try again later.'), $e);`
	`83`	`+ throw new CouldNotSaveException(`
	`84`	`+ __('An error occurred on the server. Please try to place the order again.'),`
	`85`	`+ $e`
	`86`	`+ );`
`84`	`87`	`}`
`85`	`88`	`return $orderId;`
`86`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,10 @@ public function savePaymentInformationAndPlaceOrder(`
`68`	`68`	`try {`
`69`	`69`	`$orderId = $this->cartManagement->placeOrder($cartId);`
`70`	`70`	`} catch (\Exception $e) {`
`71`		`- throw new CouldNotSaveException(__('Unable to place order. Please try again later.'), $e);`
	`71`	`+ throw new CouldNotSaveException(`
	`72`	`+ __('An error occurred on the server. Please try to place the order again.'),`
	`73`	`+ $e`
	`74`	`+ );`
`72`	`75`	`}`
`73`	`76`	`return $orderId;`
`74`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public function testSavePaymentInformationAndPlaceOrder()`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`/**`
`96`		`- * @expectedExceptionMessage Unable to place order. Please try again later.`
	`96`	`+ * @expectedExceptionMessage An error occurred on the server. Please try to place the order again.`
`97`	`97`	`* @expectedException \Magento\Framework\Exception\CouldNotSaveException`
`98`	`98`	`*/`
`99`	`99`	`public function testSavePaymentInformationAndPlaceOrderException()`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function testSavePaymentInformationAndPlaceOrder()`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`/**`
`73`		`- * @expectedExceptionMessage Unable to place order. Please try again later.`
	`73`	`+ * @expectedExceptionMessage An error occurred on the server. Please try to place the order again.`
`74`	`74`	`* @expectedException \Magento\Framework\Exception\CouldNotSaveException`
`75`	`75`	`*/`
`76`	`76`	`public function testSavePaymentInformationAndPlaceOrderException()`