MAGETWO-95928: Remove RequestAwareBlockMethod

Author: Oleksandr Gorkun

app/code/Magento/Widget/Block/Adminhtml/Widget.php

@@ -16,8 +16,6 @@ class Widget extends \Magento\Backend\Block\Widget\Form\Container
 {
     /**
      * @inheritdoc
-     *
-     * @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
      */
     protected function _construct()
     {

dev/tests/static/framework/Magento/CodeMessDetector/Rule/Design/RequestAwareBlockMethod.php

@@ -54,37 +54,6 @@ class PostOrder implements ActionInterface
         ...
         return $response;
     }
-}
-            ]]>
-        </example>
-    </rule>
-    <rule name="RequestAwareBlockMethod"
-          class="Magento\CodeMessDetector\Rule\Design\RequestAwareBlockMethod"
-          message="{0} uses request object directly. Add user input validation and suppress this warning.">
-        <description>
-            <![CDATA[
-Blocks must not depend on being used with certain controllers.
-If you use request object in a block directly you must validate all user input inside the block.
-            ]]>
-        </description>
-        <priority>2</priority>
-        <properties />
-        <example>
-            <![CDATA[
-class MyOrder extends AbstractBlock
-{
-
-    .......
-
-    public function getOrder()
-    {
-        $orderId = $this->getRequest()->getParam('order_id');
-        //Validate customer having such order.
-        if (!$this->hasOrder($this->getCustomerId(), $orderId)) {
-            ...deny access...
-        }
-        .....
-    }
 }
             ]]>
         </example>

dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets/design.xml

@@ -48,6 +48,5 @@
     <!-- Magento Specific Rules -->
     <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/FinalImplementation" />
     <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/AllPurposeAction" />
-    <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/RequestAwareBlockMethod" />
 
 </ruleset>