MAGETWO-91737: Customer Address attribute value length is still validated when min/max length fields are not displayed at the backend

Author: Sergey Shvets

app/code/Magento/Customer/Model/Metadata/Form/Text.php

@@ -43,15 +43,15 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function extractValue(\Magento\Framework\App\RequestInterface $request)
     {
         return $this->_applyInputFilter($this->_getRequestValue($request));
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
@@ -88,23 +88,23 @@ public function validateValue($value)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function compactValue($value)
     {
         return $value;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function restoreValue($value)
     {
         return $this->compactValue($value);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function outputValue($format = \Magento\Customer\Model\Metadata\ElementFactory::OUTPUT_FORMAT_TEXT)
     {

app/code/Magento/Customer/Test/Unit/Controller/Address/FormPostTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Customer\Test\Unit\Controller\Address;
 
 use Magento\Customer\Api\AddressRepositoryInterface;
@@ -162,6 +163,9 @@ class FormPostTest extends \PHPUnit\Framework\TestCase
      */
     private $customerAddressMapper;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         $this->prepareContext();
@@ -230,7 +234,10 @@ protected function setUp()
         );
     }
 
-    protected function prepareContext()
+    /**
+     * Prepares context
+     */
+    protected function prepareContext(): void
     {
         $this->context = $this->getMockBuilder(\Magento\Framework\App\Action\Context::class)
             ->disableOriginalConstructor()
@@ -284,7 +291,10 @@ protected function prepareContext()
             ->willReturn($this->messageManager);
     }
 
-    protected function prepareAddress()
+    /**
+     * Prepare address
+     */
+    protected function prepareAddress(): void
     {
         $this->addressRepository = $this->getMockBuilder(\Magento\Customer\Api\AddressRepositoryInterface::class)
             ->getMockForAbstractClass();
@@ -303,7 +313,10 @@ protected function prepareAddress()
             ->willReturn($this->addressData);
     }
 
-    protected function prepareRegion()
+    /**
+     * Prepare region
+     */
+    protected function prepareRegion(): void
     {
         $this->region = $this->getMockBuilder(\Magento\Directory\Model\Region::class)
             ->disableOriginalConstructor()
@@ -335,7 +348,10 @@ protected function prepareRegion()
             ->willReturn($this->regionData);
     }
 
-    protected function prepareForm()
+    /**
+     * Prepare form
+     */
+    protected function prepareForm(): void
     {
         $this->form = $this->getMockBuilder(\Magento\Customer\Model\Metadata\Form::class)
             ->disableOriginalConstructor()
@@ -346,7 +362,10 @@ protected function prepareForm()
             ->getMock();
     }
 
-    public function testExecuteNoFormKey()
+    /**
+     * Test form without formKey
+     */
+    public function testExecuteNoFormKey(): void
     {
         $this->formKeyValidator->expects($this->once())
             ->method('validate')
@@ -361,7 +380,10 @@ public function testExecuteNoFormKey()
         $this->assertEquals($this->resultRedirect, $this->model->execute());
     }
 
-    public function testExecuteNoPostData()
+    /**
+     * Test executing without post data
+     */
+    public function testExecuteNoPostData(): void
     {
         $postValue = 'post_value';
         $url = 'url';
@@ -409,10 +431,11 @@ public function testExecuteNoPostData()
     }
 
     /**
+     * Tests executing
+     *
      * @param int $addressId
      * @param int $countryId
      * @param int $customerId
-     * @param bool $isRegionRequired
      * @param int $regionId
      * @param string $region
      * @param string $regionCode
@@ -433,7 +456,7 @@ public function testExecute(
         $newRegionId,
         $newRegion,
         $newRegionCode
-    ) {
+    ): void {
         $existingAddressData = [
             'country_id' => $countryId,
             'region_id' => $regionId,
@@ -517,7 +540,8 @@ public function testExecute(
             ->willReturnMap([
                 [
                     $this->regionData,
-                    $regionData, \Magento\Customer\Api\Data\RegionInterface::class,
+                    $regionData,
+                    \Magento\Customer\Api\Data\RegionInterface::class,
                     $this->dataObjectHelper,
                 ],
                 [
@@ -581,7 +605,7 @@ public function testExecute(
     /**
      * @return array
      */
-    public function dataProviderTestExecute()
+    public function dataProviderTestExecute(): array
     {
         return [
             [1, 1, 1, null, '', null, '', null, ''],
@@ -612,7 +636,10 @@ public function dataProviderTestExecute()
         ];
     }
 
-    public function testExecuteInputException()
+    /**
+     * Tests input exception
+     */
+    public function testExecuteInputException(): void
     {
         $addressId = 1;
         $postValue = 'post_value';
@@ -674,7 +701,10 @@ public function testExecuteInputException()
         $this->assertEquals($this->resultRedirect, $this->model->execute());
     }
 
-    public function testExecuteException()
+    /**
+     * Tests exception
+     */
+    public function testExecuteException(): void
     {
         $addressId = 1;
         $postValue = 'post_value';

app/code/Magento/Customer/Test/Unit/Model/Metadata/Form/TextTest.php

@@ -16,6 +16,9 @@ class TextTest extends AbstractFormTestCase
     /** @var \Magento\Framework\Stdlib\StringUtils */
     protected $stringHelper;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         parent::setUp();

app/code/Magento/Eav/Test/Unit/Model/Attribute/Data/MultilineTest.php

@@ -21,6 +21,9 @@ class MultilineTest extends \PHPUnit\Framework\TestCase
      */
     protected $stringMock;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         /** @var TimezoneInterface $timezoneMock */

app/code/Magento/Eav/Test/Unit/Model/Attribute/Data/TextTest.php

@@ -13,6 +13,9 @@ class TextTest extends \PHPUnit\Framework\TestCase
      */
     protected $_model;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         $locale = $this->createMock(\Magento\Framework\Stdlib\DateTime\TimezoneInterface::class);
@@ -33,27 +36,39 @@ protected function setUp()
         );
     }
 
+    /**
+     * {@inheritDoc}
+     */
     protected function tearDown()
     {
         $this->_model = null;
     }
 
-    public function testValidateValueString()
+    /**
+     * Test for string validation
+     */
+    public function testValidateValueString(): void
     {
         $inputValue = '0';
         $expectedResult = true;
         $this->assertEquals($expectedResult, $this->_model->validateValue($inputValue));
     }
 
-    public function testValidateValueInteger()
+    /**
+     * Test for integer validation
+     */
+    public function testValidateValueInteger(): void
     {
         $inputValue = 0;
         $expectedResult = ['"Test" is a required value.'];
         $result = $this->_model->validateValue($inputValue);
         $this->assertEquals($expectedResult, [(string)$result[0]]);
     }
 
-    public function testWithoutLengthValidation()
+    /**
+     * Test without length validation
+     */
+    public function testWithoutLengthValidation(): void
     {
         $expectedResult = true;
         $defaultAttributeData = [

app/code/Magento/Ui/Test/Unit/DataProvider/EavValidationRulesTest.php

@@ -30,6 +30,9 @@ class EavValidationRulesTest extends \PHPUnit\Framework\TestCase
      */
     protected $attributeMock;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         $this->objectManager = new ObjectManager($this);
@@ -43,11 +46,13 @@ protected function setUp()
     }
 
     /**
+     * @param string $attributeInputType
+     * @param mixed $validateRules
      * @param array $data
      * @param array $expected
      * @dataProvider buildDataProvider
      */
-    public function testBuild($attributeInputType, $validateRules, $data, $expected)
+    public function testBuild($attributeInputType, $validateRules, $data, $expected): void
     {
         $this->attributeMock->expects($this->once())->method('getFrontendInput')->willReturn($attributeInputType);
         $this->attributeMock->expects($this->any())->method('getValidateRules')->willReturn($validateRules);

dev/tests/integration/testsuite/Magento/Customer/Controller/AddressTest.php

@@ -18,6 +18,9 @@ class AddressTest extends \Magento\TestFramework\TestCase\AbstractController
     /** @var FormKey */
     private $formKey;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         parent::setUp();

dev/tests/integration/testsuite/Magento/Customer/Controller/Adminhtml/IndexTest.php

@@ -44,6 +44,9 @@ class IndexTest extends \Magento\TestFramework\TestCase\AbstractBackendControlle
     /** @var \Magento\TestFramework\ObjectManager */
     protected $objectManager;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         parent::setUp();
@@ -67,6 +70,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * {@inheritDoc}
+     */
     protected function tearDown()
     {
         /**
@@ -522,7 +528,10 @@ public function testEditAction()
         $this->assertContains('<h1 class="page-title">test firstname test lastname</h1>', $body);
     }
 
-    public function testNewAction()
+    /**
+     * Tests new action
+     */
+    public function testNewAction(): void
     {
         $this->dispatch('backend/customer/index/edit');
         $body = $this->getResponse()->getBody();