MC-42448: [Magento Cloud] Issue with uploading same vimeo video for multiple products.

loganadhan-palanisamy · loganadhan-palanisamy · commit 733932459629 · 2021-06-15T18:49:33.000+05:30
- Append extension to the filename only when path has an extension.
diff --git a/lib/internal/Magento/Framework/File/Uploader.php b/lib/internal/Magento/Framework/File/Uploader.php
@@ -803,7 +803,8 @@ public static function getNewFileName($destinationFile)
         $fileInfo = pathinfo($destinationFile);
         $index = 1;
         while ($fileExists($fileInfo['dirname'] . '/' . $fileInfo['basename'])) {
-            $fileInfo['basename'] = $fileInfo['filename'] . '_' . $index++ . '.' . $fileInfo['extension'];
+            $fileInfo['basename'] = $fileInfo['filename'] . '_' . ($index++);
+            $fileInfo['basename'] .= isset($fileInfo['extension']) ? '.' . $fileInfo['extension'] : '';
         }
 
         return $fileInfo['basename'];

Original file line number	Diff line number	Diff line change
`@@ -803,7 +803,8 @@ public static function getNewFileName($destinationFile)`
`803`	`803`	`$fileInfo = pathinfo($destinationFile);`
`804`	`804`	`$index = 1;`
`805`	`805`	`while ($fileExists($fileInfo['dirname'] . '/' . $fileInfo['basename'])) {`
`806`		`- $fileInfo['basename'] = $fileInfo['filename'] . '_' . $index++ . '.' . $fileInfo['extension'];`
	`806`	`+ $fileInfo['basename'] = $fileInfo['filename'] . '_' . ($index++);`
	`807`	`+ $fileInfo['basename'] .= isset($fileInfo['extension']) ? '.' . $fileInfo['extension'] : '';`
`807`	`808`	`}`
`808`	`809`
`809`	`810`	`return $fileInfo['basename'];`