AC-11496:Fix for import/export tax rates

Devika-GL · Devika-GL · commit 72932f3bd7f5 · 2024-06-17T16:46:46.000+05:30
diff --git a/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate.php b/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate.php
@@ -3,6 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\TaxImportExport\Controller\Adminhtml;
 
 /**
@@ -15,7 +18,7 @@ abstract class Rate extends \Magento\Backend\App\Action
      *
      * @see _isAllowed()
      */
-    const ADMIN_RESOURCE = 'Magento_Tax::manage_tax';
+    public const ADMIN_RESOURCE = 'Magento_Tax::manage_tax';
 
     /**
      * @var \Magento\Framework\App\Response\Http\FileFactory
@@ -33,4 +36,19 @@ public function __construct(
         $this->fileFactory = $fileFactory;
         parent::__construct($context);
     }
+
+    /**
+     * Check ACL permission
+     *
+     * @return bool
+     */
+    protected function _isAllowed(): bool
+    {
+        return match (strtolower($this->getRequest()->getActionName())) {
+            'importexport','importpost','exportcsv','exportxml', 'exportpost' =>
+            $this->_authorization->isAllowed('Magento_TaxImportExport::import_export'),
+            default =>
+            $this->_authorization->isAllowed(self::ADMIN_RESOURCE),
+        };
+    }
 }
diff --git a/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate/ExportPost.php b/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate/ExportPost.php
@@ -3,6 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\TaxImportExport\Controller\Adminhtml\Rate;
 
 use Magento\Framework\App\Filesystem\DirectoryList;
@@ -86,16 +89,4 @@ public function execute()
 
         return $this->fileFactory->create('tax_rates.csv', $fileContent, DirectoryList::VAR_DIR);
     }
-
-    /**
-     * @return bool
-     */
-    protected function _isAllowed()
-    {
-        return $this->_authorization->isAllowed(
-            'Magento_Tax::manage_tax'
-        ) || $this->_authorization->isAllowed(
-            'Magento_TaxImportExport::import_export'
-        );
-    }
 }
diff --git a/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate/ImportPost.php b/app/code/Magento/TaxImportExport/Controller/Adminhtml/Rate/ImportPost.php
@@ -3,14 +3,17 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\TaxImportExport\Controller\Adminhtml\Rate;
 
 use Magento\Framework\Controller\ResultFactory;
 
 class ImportPost extends \Magento\TaxImportExport\Controller\Adminhtml\Rate
 {
     /**
-     * import action from import/export tax
+     * Import action from import/export tax
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
@@ -39,16 +42,4 @@ public function execute()
         $resultRedirect->setUrl($this->_redirect->getRedirectUrl());
         return $resultRedirect;
     }
-
-    /**
-     * @return bool
-     */
-    protected function _isAllowed()
-    {
-        return $this->_authorization->isAllowed(
-            'Magento_Tax::manage_tax'
-        ) || $this->_authorization->isAllowed(
-            'Magento_TaxImportExport::import_export'
-        );
-    }
 }
diff --git a/app/code/Magento/TaxImportExport/view/adminhtml/layout/tax_rule_edit.xml b/app/code/Magento/TaxImportExport/view/adminhtml/layout/tax_rule_edit.xml
@@ -8,7 +8,8 @@
 <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
     <body>
         <referenceBlock name="content">
-            <block class="Magento\TaxImportExport\Block\Adminhtml\Rate\ImportExport" name="tax-rate-importExport" template="Magento_TaxImportExport::importExport.phtml"/>
+            <block class="Magento\TaxImportExport\Block\Adminhtml\Rate\ImportExport" name="tax-rate-importExport"
+                   template="Magento_TaxImportExport::importExport.phtml"  aclResource="Magento_TaxImportExport::import_export"/>
         </referenceBlock>
     </body>
 </page>
