MTA-1594: Re-factor Functional tests which are not end-to-end

- CR Changes

Author: orykh

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Action/Attribute.php

@@ -15,13 +15,6 @@
  */
 class Attribute extends Form
 {
-    /**
-     * CSS selector for 'save' button.
-     *
-     * @var string
-     */
-    protected $saveButton = '[data-ui-id="page-actions-toolbar-save-button"]';
-
     /**
      * Fill the root form.
      *
@@ -33,7 +26,7 @@ public function fill(FixtureInterface $fixture, SimpleElement $element = null)
     {
         $data = $fixture->getData();
         foreach ($data as $name => $dataValue) {
-            $fields['toggle_' . $name ] = 'Yes';
+            $fields['toggle_' . $name] = 'Yes';
             $fields[$name] = $dataValue;
         }
         $mapping = $this->dataMapping($fields);

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/FormPageActions.php renamed to dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Action/FormPageActions.php

@@ -4,7 +4,7 @@
  * See COPYING.txt for license details.
  */
 
-namespace Magento\Catalog\Test\Block\Adminhtml\Product\Attribute;
+namespace Magento\Catalog\Test\Block\Adminhtml\Product\Edit\Action;
 
 /**
  * Form action.

dev/tests/functional/tests/app/Magento/Catalog/Test/Page/Adminhtml/CatalogProductActionAttributeEdit.xml

@@ -6,8 +6,8 @@
  */
  -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/pages.xsd">
-    <page name="CatalogProductActionAttributeEdit" area="Product" mca="catalog/product_action_attribute/edit" module="Magento_Catalog">
+    <page name="CatalogProductActionAttributeEdit" area="Adminhtml" mca="catalog/product_action_attribute/edit" module="Magento_Catalog">
         <block name="attributesBlockForm" class="Magento\Catalog\Test\Block\Adminhtml\Product\Edit\Action\Attribute" locator="body" strategy="css selector" />
-        <block name="formPageActions" class="Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\FormPageActions" locator=".page-main-actions" strategy="css selector" />
+        <block name="formPageActions" class="Magento\Catalog\Test\Block\Adminhtml\Product\Edit\Action\FormPageActions" locator=".page-main-actions" strategy="css selector" />
     </page>
 </config>

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/MassProductPriceUpdateTest.php renamed to dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/MassProductUpdateTest.php

@@ -9,7 +9,7 @@
 use Magento\Mtf\TestCase\Injectable;
 use Magento\Catalog\Test\Fixture\CatalogProductSimple;
 use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
-use Magento\Catalog\Test\Page\Product\CatalogProductActionAttributeEdit;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductActionAttributeEdit;
 
 /**
  * Precondition:
@@ -22,7 +22,7 @@
  * 3. Find Product (from preconditions) in Products grid.
  * 4. Select Product's check-box.
  * 5. Select "Update Attributes" value in "Select Product Actions" drop-down list.
- * 6. Click on the "Submit" button. "Attributes" page is opened (/catalog/product_action_attribute/edit/).
+ * 6. Click on the "Submit" button.
  * 7. Open "Attributes" tab.
  * 8. Fill data.
  * 9. Click on the "Save" button.
@@ -31,7 +31,7 @@
  * @group Products_(MX)
  * @ZephyrId MAGETWO-21128
  */
-class MassProductPriceUpdateTest extends Injectable
+class MassProductUpdateTest extends Injectable
 {
     /* tags */
     const MVP = 'yes';
@@ -99,7 +99,6 @@ public function test(CatalogProductSimple $initialProduct, CatalogProductSimple
         $this->productGrid->getProductGrid()->updateAttributes([['sku' => $initialProduct->getSku()]]);
         $this->attributeMassActionPage->getAttributesBlockForm()->fill($product);
         $this->attributeMassActionPage->getFormPageActions()->save();
-        $this->productGrid->getMessagesBlock()->waitSuccessMessage();
         $data = array_merge($initialProduct->getData(), $product->getData());
         $product = $this->objectManager->create(
             'Magento\Catalog\Test\Fixture\CatalogProductSimple',

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/MassProductPriceUpdateTest.xml renamed to dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/MassProductUpdateTest.xml

@@ -6,7 +6,7 @@
  */
  -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/variations.xsd">
-    <testCase name="Magento\Catalog\Test\TestCase\Product\MassProductPriceUpdateTest">
+    <testCase name="Magento\Catalog\Test\TestCase\Product\MassProductUpdateTest">
         <variation name="MassProductPriceUpdateTestVariation1">
             <data name="configData" xsi:type="string">product_flat</data>
             <data name="initialProduct/dataSet" xsi:type="string">simple_10_dollar</data>