Skip to content

Commit 724ccef

Browse files
committed
MC-18280: Dynamic Block based on segment not displaying correctly for visitor
1 parent 5a82cc9 commit 724ccef

File tree

3 files changed

+33
-3
lines changed

3 files changed

+33
-3
lines changed

app/code/Magento/Widget/Test/Mftf/ActionGroup/AdminCreateAndSaveWidgetActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<annotations>
1313
<description>EXTENDS: AdminCreateWidgetActionGroup. Clicks on Save. Validates that the Success Message is present and correct.</description>
1414
</annotations>
15-
15+
1616
<click selector="{{AdminMainActionsSection.save}}" stepKey="clickSaveWidget"/>
1717
<see selector="{{AdminMessagesSection.successMessage}}" userInput="The widget instance has been saved" stepKey="seeSuccess"/>
1818
</actionGroup>

app/code/Magento/Widget/Test/Mftf/ActionGroup/AdminCreateWidgetActionGroup.xml

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,32 @@
3030
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
3131
<click selector="{{AdminNewWidgetSection.widgetOptions}}" stepKey="clickWidgetOptions"/>
3232
</actionGroup>
33-
33+
<actionGroup name="AdminFillSpecificPageWidgetMainFieldsActionGroup">
34+
<annotations>
35+
<description>Fill widget main fields and widget layout by index for specified page DisplayOn option</description>
36+
</annotations>
37+
<arguments>
38+
<argument name="widget" type="entity" defaultValue="ProductsListWidget"/>
39+
<argument name="index" type="string" defaultValue="0"/>
40+
</arguments>
41+
<selectOption selector="{{AdminNewWidgetSection.widgetType}}" userInput="{{widget.type}}" stepKey="setWidgetType"/>
42+
<selectOption selector="{{AdminNewWidgetSection.widgetDesignTheme}}" userInput="{{widget.design_theme}}" stepKey="setWidgetDesignTheme"/>
43+
<click selector="{{AdminNewWidgetSection.continue}}" stepKey="clickContinue"/>
44+
<waitForPageLoad stepKey="waitForPageLoad"/>
45+
<fillField selector="{{AdminNewWidgetSection.widgetTitle}}" userInput="{{widget.name}}" stepKey="fillTitle"/>
46+
<selectOption selector="{{AdminNewWidgetSection.widgetStoreIds}}" userInput="{{widget.store_ids[0]}}" stepKey="setWidgetStoreIds"/>
47+
<fillField selector="{{AdminNewWidgetSection.widgetSortOrder}}" userInput="{{widget.sort_order}}" stepKey="fillSortOrder"/>
48+
<click selector="{{AdminNewWidgetSection.addLayoutUpdate}}" stepKey="clickAddLayoutUpdate"/>
49+
<waitForElementVisible selector="{{AdminNewWidgetSection.selectDisplayOn}}" stepKey="waitForSelectElement"/>
50+
<selectOption selector="{{AdminNewWidgetSection.displayOnByIndex(index)}}" userInput="{{widget.display_on}}" stepKey="setDisplayOn"/>
51+
<waitForAjaxLoad stepKey="waitForAjaxLoad"/>
52+
<selectOption selector="{{AdminNewWidgetSection.layoutByIndex(index)}}" userInput="{{widget.page}}" stepKey="selectPage"/>
53+
<selectOption selector="{{AdminNewWidgetSection.templateByIndex(index)}}" userInput="{{widget.template}}" stepKey="selectTemplate"/>
54+
<scrollTo selector="{{AdminNewWidgetSection.containerByIndex(index)}}" stepKey="scrollToSelectContainerElement"/>
55+
<waitForAjaxLoad stepKey="waitForAjaxLoad1"/>
56+
<selectOption selector="{{AdminNewWidgetSection.containerByIndex(index)}}" userInput="{{widget.container}}" stepKey="setContainer"/>
57+
<waitForAjaxLoad stepKey="waitForAjaxLoad2"/>
58+
</actionGroup>
3459
<!--Create Product List Widget-->
3560
<actionGroup name="AdminCreateProductsListWidgetActionGroup" extends="AdminCreateWidgetActionGroup">
3661
<annotations>
@@ -54,7 +79,7 @@
5479
<annotations>
5580
<description>EXTENDS: AdminCreateWidgetActionGroup. Creates a Dynamic Block Rotate Widget.</description>
5681
</annotations>
57-
82+
5883
<selectOption selector="{{AdminNewWidgetSection.displayMode}}" userInput="{{widget.display_mode}}" stepKey="selectDisplayMode"/>
5984
<selectOption selector="{{AdminNewWidgetSection.restrictTypes}}" userInput="{{widget.restrict_type}}" stepKey="selectRestrictType"/>
6085
<click selector="{{AdminNewWidgetSection.saveAndContinue}}" stepKey="clickSaveWidget"/>

app/code/Magento/Widget/Test/Mftf/Section/AdminNewWidgetSection.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,14 @@
1414
<element name="continue" type="button" selector="#continue_button"/>
1515
<element name="widgetTitle" type="input" selector="#title"/>
1616
<element name="widgetStoreIds" type="select" selector="#store_ids"/>
17+
<element name="widgetSortOrder" type="input" selector="#sort_order"/>
1718
<element name="addLayoutUpdate" type="button" selector=".action-default.scalable.action-add"/>
1819
<element name="selectDisplayOn" type="select" selector="#widget_instance[0][page_group]"/>
1920
<element name="selectContainer" type="select" selector="#all_pages_0>table>tbody>tr>td:nth-child(1)>div>div>select"/>
21+
<element name="displayOnByIndex" type="select" selector="select[name='widget_instance[{{index}}][page_group]']" parameterized="true"/>
22+
<element name="layoutByIndex" type="select" selector="select[name='widget_instance[{{index}}][pages][layout_handle]']" parameterized="true"/>
23+
<element name="containerByIndex" type="select" selector="select[name='widget_instance[{{index}}][pages][block]']" parameterized="true"/>
24+
<element name="templateByIndex" type="select" selector="select[name='widget_instance[{{index}}][pages][template]']" parameterized="true"/>
2025
<element name="selectTemplate" type="select" selector=".widget-layout-updates .block_template_container .select"/>
2126
<element name="widgetOptions" type="select" selector="#widget_instace_tabs_properties_section"/>
2227
<element name="addNewCondition" type="select" selector=".rule-param.rule-param-new-child"/>

0 commit comments

Comments
 (0)