Fixed Static test issues

Author: glo80326

app/code/Magento/Cms/Ui/Component/Listing/Column/BlockActions.php

@@ -20,9 +20,9 @@ class BlockActions extends Column
     /**
      * Url path
      */
-    const URL_PATH_EDIT = 'cms/block/edit';
-    const URL_PATH_DELETE = 'cms/block/delete';
-    const URL_PATH_DETAILS = 'cms/block/details';
+    public const URL_PATH_EDIT = 'cms/block/edit';
+    public const URL_PATH_DELETE = 'cms/block/delete';
+    public const URL_PATH_DETAILS = 'cms/block/details';
 
     /**
      * @var UrlInterface

app/code/Magento/Integration/Model/Oauth/Token.php

@@ -51,11 +51,11 @@ class Token extends \Magento\Framework\Model\AbstractModel
     /**#@+
      * Token types
      */
-    const TYPE_REQUEST = 'request';
+    public const TYPE_REQUEST = 'request';
 
-    const TYPE_ACCESS = 'access';
+    public const TYPE_ACCESS = 'access';
 
-    const TYPE_VERIFIER = 'verifier';
+    public const TYPE_VERIFIER = 'verifier';
 
     /**#@- */
 

app/code/Magento/Theme/Controller/Adminhtml/System/Design/Theme/Save.php

@@ -8,6 +8,7 @@
 
 /**
  * Class Save use to save Theme data
+ * @SuppressWarnings(PHPMD.AllPurposeAction)
  * @deprecated 100.2.0
  */
 class Save extends \Magento\Theme\Controller\Adminhtml\System\Design\Theme
@@ -79,8 +80,9 @@ public function execute()
             $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
         }
         $redirectBack
-            ? $this->_redirect('adminhtml/*/edit', ['id' => $theme->getId()])
-            : $this->_redirect('adminhtml/*/');
+            //phpstan:ignore
+            ? $this->_redirect('adminhtml/*/edit', ['id' => $theme->getId()]) //phpcs:ignore
+            : $this->_redirect('adminhtml/*/'); //phpcs:ignore
     }
 
     /**

app/code/Magento/Theme/Model/Theme/Image/Path.php

@@ -17,11 +17,9 @@ class Path implements \Magento\Framework\View\Design\Theme\Image\PathInterface
     /**
      * Default theme preview image
      */
-    const DEFAULT_PREVIEW_IMAGE = 'Magento_Theme::theme/default_preview.jpg';
+    public const DEFAULT_PREVIEW_IMAGE = 'Magento_Theme::theme/default_preview.jpg';
 
     /**
-     * Media Directory
-     *
      * @var \Magento\Framework\Filesystem\Directory\ReadInterface
      */
     protected $mediaDirectory;

app/code/Magento/Ui/Component/Filters/Type/Select.php

@@ -17,9 +17,9 @@
  */
 class Select extends AbstractFilter
 {
-    const NAME = 'filter_select';
+    public const NAME = 'filter_select';
 
-    const COMPONENT = 'select';
+    public const COMPONENT = 'select';
 
     /**
      * UI Component

app/code/Magento/Ui/Component/Listing/Columns/Column.php

@@ -16,7 +16,7 @@
  */
 class Column extends AbstractComponent implements ColumnInterface
 {
-    const NAME = 'column';
+    public const NAME = 'column';
 
     /**
      * UI component

lib/internal/Magento/Framework/Oauth/Helper/Request.php

@@ -16,15 +16,15 @@ class Request
     /**#@+
      * HTTP Response Codes
      */
-    const HTTP_OK = 200;
+    public const HTTP_OK = 200;
 
-    const HTTP_BAD_REQUEST = 400;
+    public const HTTP_BAD_REQUEST = 400;
 
-    const HTTP_UNAUTHORIZED = 401;
+    public const HTTP_UNAUTHORIZED = 401;
 
-    const HTTP_METHOD_NOT_ALLOWED = 405;
+    public const HTTP_METHOD_NOT_ALLOWED = 405;
 
-    const HTTP_INTERNAL_ERROR = 500;
+    public const HTTP_INTERNAL_ERROR = 500;
 
     /**#@-*/
 

lib/internal/Magento/Framework/Oauth/OauthInterface.php

@@ -18,41 +18,41 @@ interface OauthInterface
     /**#@+
      * OAuth result statuses
      */
-    const ERR_OK = 0;
+    public const ERR_OK = 0;
 
-    const ERR_VERSION_REJECTED = 1;
+    public const ERR_VERSION_REJECTED = 1;
 
-    const ERR_PARAMETER_ABSENT = 2;
+    public const ERR_PARAMETER_ABSENT = 2;
 
-    const ERR_PARAMETER_REJECTED = 3;
+    public const ERR_PARAMETER_REJECTED = 3;
 
-    const ERR_TIMESTAMP_REFUSED = 4;
+    public const ERR_TIMESTAMP_REFUSED = 4;
 
-    const ERR_NONCE_USED = 5;
+    public const ERR_NONCE_USED = 5;
 
-    const ERR_SIGNATURE_METHOD_REJECTED = 6;
+    public const ERR_SIGNATURE_METHOD_REJECTED = 6;
 
-    const ERR_SIGNATURE_INVALID = 7;
+    public const ERR_SIGNATURE_INVALID = 7;
 
-    const ERR_CONSUMER_KEY_REJECTED = 8;
+    public const ERR_CONSUMER_KEY_REJECTED = 8;
 
-    const ERR_TOKEN_USED = 9;
+    public const ERR_TOKEN_USED = 9;
 
-    const ERR_TOKEN_EXPIRED = 10;
+    public const ERR_TOKEN_EXPIRED = 10;
 
-    const ERR_TOKEN_REVOKED = 11;
+    public const ERR_TOKEN_REVOKED = 11;
 
-    const ERR_TOKEN_REJECTED = 12;
+    public const ERR_TOKEN_REJECTED = 12;
 
-    const ERR_VERIFIER_INVALID = 13;
+    public const ERR_VERIFIER_INVALID = 13;
 
-    const ERR_PERMISSION_UNKNOWN = 14;
+    public const ERR_PERMISSION_UNKNOWN = 14;
 
-    const ERR_PERMISSION_DENIED = 15;
+    public const ERR_PERMISSION_DENIED = 15;
 
-    const ERR_METHOD_NOT_ALLOWED = 16;
+    public const ERR_METHOD_NOT_ALLOWED = 16;
 
-    const ERR_CONSUMER_KEY_INVALID = 17;
+    public const ERR_CONSUMER_KEY_INVALID = 17;
 
     /**#@-*/
 
@@ -63,9 +63,9 @@ interface OauthInterface
      * @deprecated SHA1 is deprecated
      * @see SIGNATURE_SHA256
      */
-    const SIGNATURE_SHA1 = 'HMAC-SHA1';
+    public const SIGNATURE_SHA1 = 'HMAC-SHA1';
 
-    const SIGNATURE_SHA256 = 'HMAC-SHA256';
+    public const SIGNATURE_SHA256 = 'HMAC-SHA256';
 
     /**#@-*/