🔃 [Magento Community Engineering] Community Contributions - 2.3-develop daily delivery

Accepted Community Pull Requests:
 - #24291: 23279: Implementation of integration tests for ProductAlert Stock notifications  (by @yuriichayka)
 - #24638: Consistent capitalization of the word 'ID' in comments of db_schema.xml files (by @psdevhh)
 - #24602: Fix whats this scroll top (by @vinidziuba)
 - #24590: fixed schedule currency_rates_update cron job not working (by @brunoroeder)
 - #24679: Update Magento_Braintree module ReadMe (by @diazwatson)
 - #24431: Resolved select from gallery option not working in theme design configuration #24430 (by @rani-webkul)
 - #24595: Added description discount  for each summary(cart, order) (by @MaxSouza)
 - #24675: Fix the error message of folder not writable. (by @Hailong)


Fixed GitHub Issues:
 - #23279: Integration test for unsubscribing from 'Back in stock notification' (reported by @yuriichayka) has been fixed in #24291 by @yuriichayka in 2.3-develop branch
   Related commits:
     1. b089cc2
     2. 36c00d2
     3. 665aad5
     4. f590127

 - #24511: Click "What 's this" link scroll to the top of page (reported by @edenduong) has been fixed in #24602 by @vinidziuba in 2.3-develop branch
   Related commits:
     1. 056b9ea
     2. 407649f
     3. 60d1ce2
     4. 397ce47

 - #23846: Schedule currency_rates_update cron job not working (reported by @krzysztofkuzniar) has been fixed in #24590 by @brunoroeder in 2.3-develop branch
   Related commits:
     1. b63fd5e
     2. 42b9141
     3. 9fb9ce9
     4. 7f44d6d
     5. 7dbd2cd
     6. 126a974
     7. 5494064

 - #24430: Select from gallery option not working in theme design configuration (reported by @rani-webkul) has been fixed in #24431 by @rani-webkul in 2.3-develop branch
   Related commits:
     1. 6b8c7ee
     2. d8e8233

 - #3594: Discount Description does not get displayed on cart page (reported by @parekhreena) has been fixed in #24595 by @MaxSouza in 2.3-develop branch
   Related commits:
     1. 23382ed
     2. 217ab79
     3. 83a84a3
     4. 7ec7d65
     5. 42edfaf
     6. fb5c663
     7. 7eed116
     8. afd489b
     9. c1d4190
     10. 57247f8

 - #24623: Subfolder string is used as scheme in generating sitemap error message. (reported by @Hailong) has been fixed in #24675 by @Hailong in 2.3-develop branch
   Related commits:
     1. 3adb1eb

Author: magento-engcom-team

app/code/Magento/AdminNotification/etc/db_schema.xml

@@ -9,7 +9,7 @@
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
     <table name="adminnotification_inbox" resource="default" engine="innodb" comment="Adminnotification Inbox">
         <column xsi:type="int" name="notification_id" padding="10" unsigned="true" nullable="false" identity="true"
-                comment="Notification id"/>
+                comment="Notification ID"/>
         <column xsi:type="smallint" name="severity" padding="5" unsigned="true" nullable="false" identity="false"
                 default="0" comment="Problem type"/>
         <column xsi:type="timestamp" name="date_added" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
@@ -35,7 +35,7 @@
         </index>
     </table>
     <table name="admin_system_messages" resource="default" engine="innodb" comment="Admin System Messages">
-        <column xsi:type="varchar" name="identity" nullable="false" length="100" comment="Message id"/>
+        <column xsi:type="varchar" name="identity" nullable="false" length="100" comment="Message ID"/>
         <column xsi:type="smallint" name="severity" padding="5" unsigned="true" nullable="false" identity="false"
                 default="0" comment="Problem type"/>
         <column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"

app/code/Magento/AdvancedSearch/etc/db_schema.xml

@@ -9,11 +9,11 @@
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
     <table name="catalogsearch_recommendations" resource="default" engine="innodb"
            comment="Advanced Search Recommendations">
-        <column xsi:type="int" name="id" padding="10" unsigned="true" nullable="false" identity="true" comment="Id"/>
+        <column xsi:type="int" name="id" padding="10" unsigned="true" nullable="false" identity="true" comment="ID"/>
         <column xsi:type="int" name="query_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Query Id"/>
+                default="0" comment="Query ID"/>
         <column xsi:type="int" name="relation_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Relation Id"/>
+                default="0" comment="Relation ID"/>
         <constraint xsi:type="primary" referenceId="PRIMARY">
             <column name="id"/>
         </constraint>

app/code/Magento/Braintree/README.md

@@ -1 +1,47 @@
-Module Magento\Braintree implements integration with the Braintree payment system.
+# Magento_Braintree module
+
+The Magento_Braintree module implements integration with the Braintree payment system.
+
+## Extensibility
+
+Extension developers can interact with the Magento_Braintree module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.3/extension-dev-guide/plugins.html).
+
+[The Magento dependency injection mechanism](https://devdocs.magento.com/guides/v2.3/extension-dev-guide/depend-inj.html) enables you to override the functionality of the Magento_Braintree module.
+
+### Events
+
+This module observes the following events:
+
+ - `payment_method_assign_data_braintree` event in `Magento\Braintree\Observer\DataAssignObserver` file.
+ - `payment_method_assign_data_braintree_paypal` event in `Magento\Braintree\Observer\DataAssignObserver` file.
+ - `shortcut_buttons_container` event in `Magento\Braintree\Observer\AddPaypalShortcuts` file.
+
+For information about an event in Magento 2, see [Events and observers](https://devdocs.magento.com/guides/v2.3/extension-dev-guide/events-and-observers.html#events).
+
+### Layouts
+
+This module interacts with the following layouts and layout handles in the `view/adminhtml/layout` directory:
+
+- `braintree_paypal_review`
+- `checkout_index_index`
+- `multishipping_checkout_billing`
+- `vault_cards_listaction`
+
+This module interacts with the following layout handles in the `view/frontend/layout` directory:
+
+- `adminhtml_system_config_edit`
+- `braintree_report_index`
+- `sales_order_create_index`
+- `sales_order_create_load_block_billing_method`
+
+For more information about layouts in Magento 2, see the [Layout documentation](https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/layout-overview.html).
+
+### UI components
+
+You can extend admin notifications using the `view/adminhtml/ui_component/braintree_report.xml` configuration file.
+
+For information about UI components in Magento 2, see [Overview of UI components](https://devdocs.magento.com/guides/v2.3/ui_comp_guide/bk-ui_comps.html).
+
+## Additional information
+
+For information about significant changes in patch releases, see [2.3.x Release information](https://devdocs.magento.com/guides/v2.3/release-notes/bk-release-notes.html).

app/code/Magento/Bundle/etc/db_schema.xml

@@ -10,9 +10,9 @@
     <table name="catalog_product_bundle_option" resource="default" engine="innodb"
            comment="Catalog Product Bundle Option">
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="true"
-                comment="Option Id"/>
+                comment="Option ID"/>
         <column xsi:type="int" name="parent_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Parent Id"/>
+                comment="Parent ID"/>
         <column xsi:type="smallint" name="required" padding="5" unsigned="true" nullable="false" identity="false"
                 default="0" comment="Required"/>
         <column xsi:type="int" name="position" padding="10" unsigned="true" nullable="false" identity="false"
@@ -31,14 +31,14 @@
     <table name="catalog_product_bundle_option_value" resource="default" engine="innodb"
            comment="Catalog Product Bundle Option Value">
         <column xsi:type="int" name="value_id" padding="10" unsigned="true" nullable="false" identity="true"
-                comment="Value Id"/>
+                comment="Value ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Option Id"/>
+                comment="Option ID"/>
         <column xsi:type="smallint" name="store_id" padding="5" unsigned="true" nullable="false" identity="false"
-                comment="Store Id"/>
+                comment="Store ID"/>
         <column xsi:type="varchar" name="title" nullable="true" length="255" comment="Title"/>
         <column xsi:type="int" name="parent_product_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Parent Product Id"/>
+                comment="Parent Product ID"/>
         <constraint xsi:type="primary" referenceId="PRIMARY">
             <column name="value_id"/>
         </constraint>
@@ -54,13 +54,13 @@
     <table name="catalog_product_bundle_selection" resource="default" engine="innodb"
            comment="Catalog Product Bundle Selection">
         <column xsi:type="int" name="selection_id" padding="10" unsigned="true" nullable="false" identity="true"
-                comment="Selection Id"/>
+                comment="Selection ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Option Id"/>
+                comment="Option ID"/>
         <column xsi:type="int" name="parent_product_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Parent Product Id"/>
+                comment="Parent Product ID"/>
         <column xsi:type="int" name="product_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Product Id"/>
+                comment="Product ID"/>
         <column xsi:type="int" name="position" padding="10" unsigned="true" nullable="false" identity="false"
                 default="0" comment="Position"/>
         <column xsi:type="smallint" name="is_default" padding="5" unsigned="true" nullable="false" identity="false"
@@ -92,15 +92,15 @@
     <table name="catalog_product_bundle_selection_price" resource="default" engine="innodb"
            comment="Catalog Product Bundle Selection Price">
         <column xsi:type="int" name="selection_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Selection Id"/>
+                comment="Selection ID"/>
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
-                comment="Website Id"/>
+                comment="Website ID"/>
         <column xsi:type="smallint" name="selection_price_type" padding="5" unsigned="true" nullable="false"
                 identity="false" default="0" comment="Selection Price Type"/>
         <column xsi:type="decimal" name="selection_price_value" scale="6" precision="20" unsigned="false"
                 nullable="false" default="0" comment="Selection Price Value"/>
         <column xsi:type="int" name="parent_product_id" padding="10" unsigned="true" nullable="false" identity="false"
-                comment="Parent Product Id"/>
+                comment="Parent Product ID"/>
         <constraint xsi:type="primary" referenceId="PK_CATALOG_PRODUCT_BUNDLE_SELECTION_PRICE">
             <column name="selection_id"/>
             <column name="parent_product_id"/>
@@ -122,7 +122,7 @@
         <column xsi:type="int" name="entity_id" padding="10" unsigned="true" nullable="false" identity="false"
                 comment="Entity ID"/>
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
-                comment="Website Id"/>
+                comment="Website ID"/>
         <column xsi:type="int" name="customer_group_id" padding="10" unsigned="true" nullable="false" identity="false"
                 comment="Customer Group ID"/>
         <column xsi:type="decimal" name="min_price" scale="6" precision="20" unsigned="false" nullable="false"
@@ -159,7 +159,7 @@
         <column xsi:type="smallint" name="stock_id" padding="5" unsigned="true" nullable="false" identity="false"
                 comment="Stock ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Option Id"/>
+                default="0" comment="Option ID"/>
         <column xsi:type="smallint" name="stock_status" padding="6" unsigned="false" nullable="true" identity="false"
                 default="0" comment="Stock Status"/>
         <constraint xsi:type="primary" referenceId="PRIMARY">
@@ -246,9 +246,9 @@
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
                 comment="Website ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Option Id"/>
+                default="0" comment="Option ID"/>
         <column xsi:type="int" name="selection_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Selection Id"/>
+                default="0" comment="Selection ID"/>
         <column xsi:type="smallint" name="group_type" padding="5" unsigned="true" nullable="true" identity="false"
                 default="0" comment="Group Type"/>
         <column xsi:type="smallint" name="is_required" padding="5" unsigned="true" nullable="true" identity="false"
@@ -274,9 +274,9 @@
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
                 comment="Website ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Option Id"/>
+                default="0" comment="Option ID"/>
         <column xsi:type="int" name="selection_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Selection Id"/>
+                default="0" comment="Selection ID"/>
         <column xsi:type="smallint" name="group_type" padding="5" unsigned="true" nullable="true" identity="false"
                 default="0" comment="Group Type"/>
         <column xsi:type="smallint" name="is_required" padding="5" unsigned="true" nullable="true" identity="false"
@@ -302,7 +302,7 @@
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
                 comment="Website ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Option Id"/>
+                default="0" comment="Option ID"/>
         <column xsi:type="decimal" name="min_price" scale="6" precision="20" unsigned="false" nullable="true"
                 comment="Min Price"/>
         <column xsi:type="decimal" name="alt_price" scale="6" precision="20" unsigned="false" nullable="true"
@@ -329,7 +329,7 @@
         <column xsi:type="smallint" name="website_id" padding="5" unsigned="true" nullable="false" identity="false"
                 comment="Website ID"/>
         <column xsi:type="int" name="option_id" padding="10" unsigned="true" nullable="false" identity="false"
-                default="0" comment="Option Id"/>
+                default="0" comment="Option ID"/>
         <column xsi:type="decimal" name="min_price" scale="6" precision="20" unsigned="false" nullable="true"
                 comment="Min Price"/>
         <column xsi:type="decimal" name="alt_price" scale="6" precision="20" unsigned="false" nullable="true"