AC-2457: Checkout Improvements

* Message changes

Author: nvshivakumar

app/code/Magento/Checkout/Controller/Sidebar/UpdateItemQty.php

@@ -74,7 +74,7 @@ public function execute()
         $itemQty = (int)$this->getRequest()->getParam('item_qty');
 
         if ($itemQty <= 0) {
-            return  $this->jsonResponse(__('A non-numeric value found'));
+            return  $this->jsonResponse(__('Invalid Item Quantity Requested.'));
         }
         $itemQty = $this->quantityProcessor->prepareQuantity($itemQty);
 
@@ -98,6 +98,7 @@ public function execute()
      */
     protected function jsonResponse($error = '')
     {
+
         return $this->getResponse()->representJson(
             $this->jsonHelper->jsonEncode($this->sidebar->getResponseData($error))
         );

app/code/Magento/Checkout/Test/Unit/Controller/Sidebar/UpdateItemQtyTest.php

@@ -250,36 +250,30 @@ public function testExecuteWithException(): void
      */
     public function testExecuteWithNonNumericItemQty(): void
     {
+        $error = [
+            'success' => false,
+            'error_message' => 'Invalid Item Quantity Requested.'
+        ];
+        $jsonResult = json_encode($error);
         $this->requestMock
             ->method('getParam')
             ->withConsecutive(['item_id', null], ['item_qty', null])
             ->willReturnOnConsecutiveCalls('1', '{{7+2}}');
 
         $this->sidebarMock->expects($this->once())
             ->method('getResponseData')
-            ->with('A non-numeric value found')
-            ->willReturn(
-                [
-                    'success' => false,
-                    'error_message' => 'A non-numeric value found'
-                ]
-            );
+            ->with('Invalid Item Quantity Requested.')
+            ->willReturn($error);
 
         $this->jsonHelperMock->expects($this->once())
             ->method('jsonEncode')
-            ->with(
-                [
-                    'success' => false,
-                    'error_message' => 'A non-numeric value found'
-                ]
-            )
-            ->willReturn('json encoded');
+            ->with($error)
+            ->willReturn($jsonResult);
 
         $this->responseMock->expects($this->once())
             ->method('representJson')
-            ->with('json encoded')
-            ->willReturn('json represented');
+            ->willReturn($jsonResult);
 
-        $this->assertEquals('json represented', $this->updateItemQty->execute());
+        $this->assertEquals($jsonResult, $this->updateItemQty->execute());
     }
 }

app/code/Magento/Checkout/i18n/en_US.csv

@@ -186,3 +186,4 @@ Payment,Payment
 "Show Cross-sell Items in the Shopping Cart","Show Cross-sell Items in the Shopping Cart"
 "You added %1 to your <a href=""%2"">shopping cart</a>.","You added %1 to your <a href=""%2"">shopping cart</a>."
 "The shipping method is missing. Select the shipping method and try again.","The shipping method is missing. Select the shipping method and try again."
+"Invalid Item Quantity Requested.","Invalid Item Quantity Requested."