MC-19672: Simple product disappearing in the configurable grid after qty set to 0

Author: dhorytskyi

app/code/Magento/ConfigurableProduct/Model/Plugin/UsedProductsCache.php

@@ -14,6 +14,7 @@
 use Magento\Catalog\Model\Product\Gallery\ReadHandler as GalleryReadHandler;
 use Magento\ConfigurableProduct\Model\Product\Type\Collection\SalableProcessor;
 use Magento\Framework\App\ObjectManager;
+use Magento\Framework\App\State as AppState;
 use Magento\Framework\EntityManager\MetadataPool;
 
 /**
@@ -194,6 +195,11 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
      */
     private $salableProcessor;
 
+    /**
+     * @var AppState
+     */
+    private $appState;
+
     /**
      * @codingStandardsIgnoreStart/End
      *
@@ -217,6 +223,7 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
      * @param \Magento\Framework\Serialize\Serializer\Json $serializer
      * @param ProductInterfaceFactory $productFactory
      * @param SalableProcessor $salableProcessor
+     * @param AppState|null $appState
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -241,7 +248,8 @@ public function __construct(
         \Magento\Customer\Model\Session $customerSession = null,
         \Magento\Framework\Serialize\Serializer\Json $serializer = null,
         ProductInterfaceFactory $productFactory = null,
-        SalableProcessor $salableProcessor = null
+        SalableProcessor $salableProcessor = null,
+        AppState $appState = null
     ) {
         $this->typeConfigurableFactory = $typeConfigurableFactory;
         $this->_eavAttributeFactory = $eavAttributeFactory;
@@ -256,6 +264,7 @@ public function __construct(
         $this->productFactory = $productFactory ?: ObjectManager::getInstance()
             ->get(ProductInterfaceFactory::class);
         $this->salableProcessor = $salableProcessor ?: ObjectManager::getInstance()->get(SalableProcessor::class);
+        $this->appState = $appState ?? ObjectManager::getInstance()->get(AppState::class);
         parent::__construct(
             $catalogProductOption,
             $eavConfig,
@@ -1232,23 +1241,25 @@ public function isPossibleBuyFromList($product)
     /**
      * Returns array of sub-products for specified configurable product
      *
-     * $requiredAttributeIds - one dimensional array, if provided
      * Result array contains all children for specified configurable product
      *
-     * @param \Magento\Catalog\Model\Product $product
-     * @param array $requiredAttributeIds
+     * @param  \Magento\Catalog\Model\Product $product
+     * @param  array $requiredAttributeIds
      * @return ProductInterface[]
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getUsedProducts($product, $requiredAttributeIds = null)
     {
-        if (!$product->hasData($this->_usedProducts)) {
-            $collection = $this->getConfiguredUsedProductCollection($product, false);
-            $usedProducts = array_values($collection->getItems());
-            $product->setData($this->_usedProducts, $usedProducts);
-        }
-
-        return $product->getData($this->_usedProducts);
+        $metadata = $this->getMetadataPool()->getMetadata(ProductInterface::class);
+        $keyParts = [
+            __METHOD__,
+            $product->getData($metadata->getLinkField()),
+            $product->getStoreId(),
+            $this->getCustomerSession()->getCustomerGroupId(),
+            $this->appState->getAreaCode(),
+            $requiredAttributeIds
+        ];
+        $cacheKey = $this->getUsedProductsCacheKey($keyParts);
+        return $this->loadUsedProducts($product, $cacheKey);
     }
 
     /**

app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php

@@ -262,15 +262,4 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\ConfigurableProduct\Model\Plugin\UsedProductsCache">
-        <arguments>
-            <argument name="cache" xsi:type="object">Magento\Framework\App\Cache\Type\Collection</argument>
-        </arguments>
-        <arguments>
-            <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Json</argument>
-        </arguments>
-    </type>
-    <type name="Magento\ConfigurableProduct\Model\Product\Type\Configurable">
-        <plugin name="used_products_cache" type="Magento\ConfigurableProduct\Model\Plugin\UsedProductsCache" />
-    </type>
 </config>