34441: fix unit tests failures

Author: karyna-t

app/code/Magento/Config/Test/Unit/Block/System/Config/Form/Field/Select/AllowspecificTest.php

@@ -87,6 +87,8 @@ public function testGetAfterElementHtml()
         $afterHtmlCode = 'after html';
         $this->_object->setData('after_element_html', $afterHtmlCode);
         $this->_object->setForm($this->_formMock);
+        $this->_object->setId('test');
+        $this->_object->setData('html_id', 'spec_element');
 
         $actual = $this->_object->getAfterElementHtml();
 

app/code/Magento/Customer/Ui/Component/Listing/Column/AccountLock.php

@@ -42,7 +42,7 @@ public function prepareDataSource(array $dataSource)
         if (isset($dataSource['data']['items'])) {
             foreach ($dataSource['data']['items'] as & $item) {
                 if (array_key_exists('lock_expires', $item)) {
-                    $lockExpires = new \DateTime($item['lock_expires']);
+                    $lockExpires = new \DateTime($item['lock_expires'] ?? 'now');
                     if ($lockExpires > new \DateTime()) {
                         $item['lock_expires'] =  __('Locked');
                     } else {

app/code/Magento/Paypal/Test/Unit/Model/PayflowlinkTest.php

@@ -9,6 +9,7 @@
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\DataObject;
+use Magento\Framework\Math\Random;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
 use Magento\Payment\Model\Method\ConfigInterfaceFactory;
 use Magento\Paypal\Block\Payment\Info;
@@ -51,6 +52,9 @@ class PayflowlinkTest extends TestCase
     /** @var ScopeConfigInterface|MockObject */
     protected $scopeConfigMock;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp(): void
     {
         $this->store = $this->createMock(Store::class);
@@ -109,6 +113,7 @@ protected function setUp(): void
                 'configFactory' => $configFactoryMock,
                 'requestFactory' => $requestFactory,
                 'gateway' => $this->gatewayMock,
+                'mathRandom' => new Random()
             ]
         );
         $this->model->setInfoInstance($this->infoInstance);

app/code/Magento/Sales/Model/Order.php

@@ -2074,7 +2074,7 @@ public function addRelatedObject(\Magento\Framework\Model\AbstractModel $object)
     public function getCreatedAtFormatted($format)
     {
         return $this->timezone->formatDateTime(
-            new \DateTime($this->getCreatedAt()),
+            new \DateTime($this->getCreatedAt() ?? 'now'),
             $format,
             $format,
             $this->localeResolver->getDefaultLocale(),

lib/internal/Magento/Framework/Code/Generator/ClassGenerator.php

@@ -226,6 +226,10 @@ protected function createMethodGenerator()
      */
     public function getNamespaceName()
     {
-        return ltrim(parent::getNamespaceName(), '\\') ?: null;
+        $namespaceName = parent::getNamespaceName();
+        if ($namespaceName !== null) {
+            $namespaceName = ltrim(parent::getNamespaceName(), '\\') ?: null;
+        }
+        return $namespaceName;
     }
 }

lib/internal/Magento/Framework/Stdlib/StringUtils.php

@@ -207,7 +207,7 @@ public function strrev($str)
      * @param int $offset
      * @return int|bool
      */
-    public function strpos($haystack, $needle, $offset = null)
+    public function strpos($haystack, $needle, $offset = 0)
     {
         return mb_strpos($haystack, $needle, $offset, self::ICONV_CHARSET);
     }

lib/internal/Magento/Framework/View/Test/Unit/Asset/Bundle/ManagerTest.php

@@ -118,6 +118,8 @@ public function testAddAssetWithExcludedFile()
         $this->asset->expects($this->atLeastOnce())
             ->method('getFilePath')
             ->willReturn('source/file.min.js');
+        $this->asset->method('getPath')
+            ->willReturn('');   // PHP 8.1. compatibility
         $this->filesystem->expects($this->once())
             ->method('getDirectoryRead')
             ->with(DirectoryList::APP)
@@ -171,6 +173,8 @@ public function testAddAssetWithExcludedDirectory()
         $this->asset->expects($this->atLeastOnce())
             ->method('getContext')
             ->willReturn($context);
+        $this->asset->method('getPath')
+            ->willReturn('');   // PHP 8.1. compatibility
         $this->bundleConfig->expects($this->atLeastOnce())
             ->method('getConfig')
             ->with($context)
@@ -201,6 +205,8 @@ public function testAddAsset()
             ->method('getDirectoryRead')
             ->with(DirectoryList::APP)
             ->willReturn($dirRead);
+        $dirRead->method('getAbsolutePath')
+            ->willReturn('some/excluded/file');
         $this->asset->expects($this->atLeastOnce())
             ->method('getSourceFile')
             ->willReturn('/path/to/source/file.min.js');

lib/internal/Magento/Framework/View/Test/Unit/Asset/BundleTest.php

@@ -109,18 +109,14 @@ public function testMinSuffix()
         $assetMock = $this->getMockBuilder(LocalInterface::class)
             ->setMethods(['getContentType', 'getContext'])
             ->getMockForAbstractClass();
-        $assetMock
-            ->expects($this->any())
-            ->method('getContext')
+        $assetMock->method('getContext')
             ->willReturn($contextMock);
-        $assetMock
-            ->expects($this->any())
-            ->method('getContentType')
+        $assetMock->method('getContentType')
             ->willReturn('js');
-        $assetMock
-            ->expects($this->any())
-            ->method('getFilePath')
+        $assetMock->method('getFilePath')
             ->willReturn('onefile.js');
+        $assetMock->method('getContent')
+            ->willReturn('');   // PHP 8.1 compatibility
 
         $writeMock = $this->getMockBuilder(WriteInterface::class)
             ->getMockForAbstractClass();

lib/internal/Magento/Framework/View/Test/Unit/Design/Theme/ImageTest.php

@@ -300,6 +300,9 @@ public function testUploadPreviewImage(): void
     {
         $scope = 'test_scope';
         $tmpFilePath = '/media_path/tmp/temporary.png';
+
+        $this->_imageMock->method('getImageType')
+            ->willReturn(0);   // PHP 8.1 compatibility
         $this->_themeMock->method('getPreviewImage')->willReturn('test.png');
         $this->_uploaderMock->expects($this->once())
             ->method('uploadPreviewImage')