MC-42025: Bad performance and outages after upgrade to MariaDB 10.2.34

Author: dhorytskyi

app/code/Magento/Sales/Model/Grid/LastUpdateTimeCache.php

@@ -0,0 +1,75 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Sales\Model\Grid;
+
+use Magento\Framework\App\CacheInterface;
+
+/**
+ * Cache for last grid update time.
+ */
+class LastUpdateTimeCache
+{
+    /**
+     * Prefix for cache key.
+     */
+    private const CACHE_PREFIX = 'LAST_GRID_UPDATE_TIME';
+
+    /**
+     * @var CacheInterface
+     */
+    private $cache;
+
+    /**
+     * @param CacheInterface $cache
+     */
+    public function __construct(CacheInterface $cache)
+    {
+        $this->cache = $cache;
+    }
+
+    /**
+     * Save last grid update time.
+     *
+     * @param string $gridTableName
+     * @param string $lastUpdatedAt
+     * @return void
+     */
+    public function save(string $gridTableName, string $lastUpdatedAt): void
+    {
+        $this->cache->save(
+            $lastUpdatedAt,
+            $this->getCacheKey($gridTableName),
+            [],
+            3600
+        );
+    }
+
+    /**
+     * Get last grid update time.
+     *
+     * @param string $gridTableName
+     * @return string|null
+     */
+    public function get(string $gridTableName): ?string
+    {
+        $lastUpdatedAt = $this->cache->load($this->getCacheKey($gridTableName));
+
+        return $lastUpdatedAt ?: null;
+    }
+
+    /**
+     * Generate cache key.
+     *
+     * @param string $gridTableName
+     * @return string
+     */
+    private function getCacheKey(string $gridTableName): string
+    {
+        return self::CACHE_PREFIX . $gridTableName;
+    }
+}

app/code/Magento/Sales/Model/ResourceModel/Grid.php

@@ -8,10 +8,11 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\Framework\Model\ResourceModel\Db\Context;
+use Magento\Sales\Model\Grid\LastUpdateTimeCache;
 use Magento\Sales\Model\ResourceModel\Provider\NotSyncedDataProviderInterface;
 
 /**
- * Class Grid
+ * Sales order grid resource model.
  */
 class Grid extends AbstractGrid
 {
@@ -45,6 +46,11 @@ class Grid extends AbstractGrid
      */
     private $notSyncedDataProvider;
 
+    /**
+     * @var LastUpdateTimeCache
+     */
+    private $lastUpdateTimeCache;
+
     /**
      * Order grid rows batch size
      */
@@ -58,7 +64,8 @@ class Grid extends AbstractGrid
      * @param array $joins
      * @param array $columns
      * @param string $connectionName
-     * @param NotSyncedDataProviderInterface $notSyncedDataProvider
+     * @param NotSyncedDataProviderInterface|null $notSyncedDataProvider
+     * @param LastUpdateTimeCache|null $lastUpdateTimeCache
      */
     public function __construct(
         Context $context,
@@ -68,15 +75,19 @@ public function __construct(
         array $joins = [],
         array $columns = [],
         $connectionName = null,
-        NotSyncedDataProviderInterface $notSyncedDataProvider = null
+        NotSyncedDataProviderInterface $notSyncedDataProvider = null,
+        LastUpdateTimeCache $lastUpdateTimeCache = null
     ) {
         $this->mainTableName = $mainTableName;
         $this->gridTableName = $gridTableName;
         $this->orderIdField = $orderIdField;
         $this->joins = $joins;
         $this->columns = $columns;
-        $this->notSyncedDataProvider =
-            $notSyncedDataProvider ?: ObjectManager::getInstance()->get(NotSyncedDataProviderInterface::class);
+        $this->notSyncedDataProvider = $notSyncedDataProvider ??
+            ObjectManager::getInstance()->get(NotSyncedDataProviderInterface::class);
+        $this->lastUpdateTimeCache = $lastUpdateTimeCache ??
+            ObjectManager::getInstance()->get(LastUpdateTimeCache::class);
+
         parent::__construct($context, $connectionName);
     }
 
@@ -118,6 +129,7 @@ public function refresh($value, $field = null)
      */
     public function refreshBySchedule()
     {
+        $lastUpdatedAt = null;
         $notSyncedIds = $this->notSyncedDataProvider->getIds($this->mainTableName, $this->gridTableName);
         foreach (array_chunk($notSyncedIds, self::BATCH_SIZE) as $bunch) {
             $select = $this->getGridOriginSelect()->where($this->mainTableName . '.entity_id IN (?)', $bunch);
@@ -127,6 +139,12 @@ public function refreshBySchedule()
                 $fetchResult,
                 array_keys($this->columns)
             );
+
+            $lastUpdatedAt = max(array_column($fetchResult, 'updated_at'));
+        }
+
+        if ($lastUpdatedAt) {
+            $this->lastUpdateTimeCache->save($this->gridTableName, $lastUpdatedAt);
         }
     }
 

app/code/Magento/Sales/Model/ResourceModel/Provider/UpdatedAtListProvider.php

@@ -7,6 +7,7 @@
 
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\Sales\Model\Grid\LastUpdateTimeCache;
 
 /**
  * Retrieves ID's of not synced by `updated_at` column entities.
@@ -25,13 +26,22 @@ class UpdatedAtListProvider implements NotSyncedDataProviderInterface
      */
     private $connection;
 
+    /**
+     * @var LastUpdateTimeCache
+     */
+    private $lastUpdateTimeCache;
+
     /**
      * @param ResourceConnection $resourceConnection
+     * @param LastUpdateTimeCache $lastUpdateTimeCache
      */
-    public function __construct(ResourceConnection $resourceConnection)
-    {
+    public function __construct(
+        ResourceConnection $resourceConnection,
+        LastUpdateTimeCache $lastUpdateTimeCache
+    ) {
         $this->connection = $resourceConnection->getConnection('sales');
         $this->resourceConnection = $resourceConnection;
+        $this->lastUpdateTimeCache = $lastUpdateTimeCache;
     }
 
     /**
@@ -55,6 +65,11 @@ public function getIds($mainTableName, $gridTableName)
                 []
             );
 
+        $lastUpdatedAt = $this->lastUpdateTimeCache->get($gridTableName);
+        if ($lastUpdatedAt) {
+            $select->where($mainTableName . '.updated_at > ?', $lastUpdatedAt);
+        }
+
         return $this->connection->fetchAll($select, [], \Zend_Db::FETCH_COLUMN);
     }
 }