MAGETWO-36426: Magento\Quote\Api\GuestCartTotalRepository

- Refactor GuestCartTotalRepository to use composition instead of inheritance
- Modify unit test to match changes

Author: Bryant Luk

app/code/Magento/Quote/Model/GuestCart/GuestCartTotalRepository.php

@@ -6,38 +6,38 @@
 
 namespace Magento\Quote\Model\GuestCart;
 
+use Magento\Quote\Api\CartTotalRepositoryInterface;
 use Magento\Quote\Api\GuestCartTotalRepositoryInterface;
-use Magento\Quote\Model\Cart\CartTotalRepository;
-use Magento\Quote\Model\QuoteRepository;
 use Magento\Quote\Model\QuoteIdMask;
 use Magento\Quote\Model\QuoteIdMaskFactory;
 
 /**
  * Cart totals repository class for guest carts.
  */
-class GuestCartTotalRepository extends CartTotalRepository implements GuestCartTotalRepositoryInterface
+class GuestCartTotalRepository implements GuestCartTotalRepositoryInterface
 {
     /**
      * @var QuoteIdMaskFactory
      */
     private $quoteIdMaskFactory;
 
+    /**
+     * @var CartTotalRepositoryInterface
+     */
+    private $cartTotalRepository;
+
     /**
      * Constructs a cart totals data object.
      *
-     * @param \Magento\Quote\Api\Data\TotalsInterfaceFactory $totalsFactory Cart totals factory.
-     * @param QuoteRepository $quoteRepository Quote repository.
-     * @param \Magento\Framework\Api\DataObjectHelper $dataObjectHelper
+     * @param CartTotalRepositoryInterface $cartTotalRepository
      * @param QuoteIdMaskFactory $quoteIdMaskFactory
      */
     public function __construct(
-        \Magento\Quote\Api\Data\TotalsInterfaceFactory $totalsFactory,
-        QuoteRepository $quoteRepository,
-        \Magento\Framework\Api\DataObjectHelper $dataObjectHelper,
+        CartTotalRepositoryInterface $cartTotalRepository,
         QuoteIdMaskFactory $quoteIdMaskFactory
     ) {
+        $this->cartTotalRepository = $cartTotalRepository;
         $this->quoteIdMaskFactory = $quoteIdMaskFactory;
-        parent::__construct($totalsFactory, $quoteRepository, $dataObjectHelper);
     }
 
     /**
@@ -47,6 +47,6 @@ public function get($cartId)
     {
         /** @var $quoteIdMask QuoteIdMask */
         $quoteIdMask = $this->quoteIdMaskFactory->create()->load($cartId, 'masked_id');
-        return parent::get($quoteIdMask->getId());
+        return $this->cartTotalRepository->get($quoteIdMask->getId());
     }
 }

app/code/Magento/Quote/Test/Unit/Model/GuestCart/GuestCartTotalRepositoryTest.php

@@ -21,96 +21,70 @@ class GuestCartTotalRepositoryTest extends \PHPUnit_Framework_TestCase
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    private $quoteRepositoryMock;
+    protected $cartTotalRepository;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    private $quoteMock;
-
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
-     */
-    private $totalsFactoryMock;
+    protected $quoteIdMaskFactoryMock;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $addressMock;
-
-    /**
-     * @var \Magento\Framework\Api\DataObjectHelper|\PHPUnit_Framework_MockObject_MockObject
-     */
-    private $dataObjectHelperMock;
+    protected $quoteIdMaskMock;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
+     * @var string
      */
-    protected $quoteIdMaskFactoryMock;
+    protected $maskedCartId = 'f216207248d65c789b17be8545e0aa73';
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
+     * @var int
      */
-    protected $quoteIdMaskMock;
+    protected $cartId = 12;
 
     public function setUp()
     {
         $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
-        $this->totalsFactoryMock = $this->getMock(
-            'Magento\Quote\Api\Data\TotalsInterfaceFactory',
-            ['create'],
-            [],
-            '',
-            false
-        );
-        $this->quoteMock = $this->getMock('Magento\Quote\Model\Quote', [], [], '', false);
-        $this->quoteRepositoryMock = $this->getMock('Magento\Quote\Model\QuoteRepository', [], [], '', false);
-        $this->addressMock = $this->getMock('Magento\Quote\Model\Quote\Address', [], [], '', false);
-        $this->dataObjectHelperMock = $this->getMockBuilder('\Magento\Framework\Api\DataObjectHelper')
+
+        $this->quoteIdMaskFactoryMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMaskFactory')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->quoteIdMaskMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMask')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->cartTotalRepository = $this->getMockBuilder('Magento\Quote\Api\CartTotalRepositoryInterface')
             ->disableOriginalConstructor()
             ->getMock();
-        $this->quoteIdMaskFactoryMock = $this->getMock('Magento\Quote\Model\QuoteIdMaskFactory', [], [], '', false);
-        $this->quoteIdMaskMock = $this->getMock('Magento\Quote\Model\QuoteIdMask', [], [], '', false);
 
         $this->model = $this->objectManager->getObject(
             'Magento\Quote\Model\GuestCart\GuestCartTotalRepository',
             [
-                'totalsFactory' => $this->totalsFactoryMock,
-                'quoteRepository' => $this->quoteRepositoryMock,
-                'dataObjectHelper' => $this->dataObjectHelperMock,
-                'quoteIdMaskFactory' => $this->quoteIdMaskFactoryMock
+                'cartTotalRepository' => $this->cartTotalRepository,
+                'quoteIdMaskFactory' => $this->quoteIdMaskFactoryMock,
             ]
         );
-    }
-
-    public function testGetTotals()
-    {
-        $maskedCartId = 'f216207248d65c789b17be8545e0aa73';
-        $cartId = 12;
 
-        $this->quoteIdMaskFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteIdMaskMock);
+        $this->quoteIdMaskFactoryMock->expects($this->once())
+            ->method('create')
+            ->willReturn($this->quoteIdMaskMock);
         $this->quoteIdMaskMock->expects($this->once())
             ->method('load')
-            ->with($maskedCartId, 'masked_id')
+            ->with($this->maskedCartId, 'masked_id')
             ->willReturn($this->quoteIdMaskMock);
         $this->quoteIdMaskMock->expects($this->once())
             ->method('getId')
-            ->willReturn($cartId);
-
-        $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
-            ->will($this->returnValue($this->quoteMock));
-        $this->quoteMock->expects($this->once())->method('getShippingAddress')->willReturn($this->addressMock);
-        $this->addressMock->expects($this->once())->method('getData')->willReturn(['addressData']);
-        $this->quoteMock->expects($this->once())->method('getData')->willReturn(['quoteData']);
-
-        $item = $this->getMock('Magento\Quote\Model\Quote\Item', [], [], '', false);
-        $this->quoteMock->expects($this->once())->method('getAllItems')->will($this->returnValue([$item]));
+            ->willReturn($this->cartId);
+    }
 
-        $totals = $this->getMock('Magento\Quote\Model\Cart\Totals', ['setItems'], [], '', false);
-        $this->totalsFactoryMock->expects($this->once())->method('create')->willReturn($totals);
-        $this->dataObjectHelperMock->expects($this->once())->method('populateWithArray');
-        $totals->expects($this->once())->method('setItems');
+    public function testGetTotals()
+    {
+        $retValue = 'retValue';
 
-        $this->model->get($maskedCartId);
+        $this->cartTotalRepository->expects($this->once())
+            ->method('get')
+            ->with($this->cartId)
+            ->will($this->returnValue($retValue));
+        $this->assertSame($retValue, $this->model->get($this->maskedCartId));
     }
 }