ENGCOM-5694: Resolve error when call getRssUrl() method #24274

Author: sidolov

app/code/Magento/Wishlist/Helper/Data.php

@@ -3,6 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\Wishlist\Helper;
 
 use Magento\Framework\App\ActionInterface;
@@ -117,6 +120,9 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
      * @param \Magento\Customer\Helper\View $customerViewHelper
      * @param WishlistProviderInterface $wishlistProvider
      * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository
+     * @param Escaper $escaper
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         \Magento\Framework\App\Helper\Context $context,
@@ -127,7 +133,8 @@ public function __construct(
         \Magento\Framework\Data\Helper\PostHelper $postDataHelper,
         \Magento\Customer\Helper\View $customerViewHelper,
         WishlistProviderInterface $wishlistProvider,
-        \Magento\Catalog\Api\ProductRepositoryInterface $productRepository
+        \Magento\Catalog\Api\ProductRepositoryInterface $productRepository,
+        Escaper $escaper = null
     ) {
         $this->_coreRegistry = $coreRegistry;
         $this->_customerSession = $customerSession;
@@ -137,7 +144,7 @@ public function __construct(
         $this->_customerViewHelper = $customerViewHelper;
         $this->wishlistProvider = $wishlistProvider;
         $this->productRepository = $productRepository;
-        $this->escaper = ObjectManager::getInstance()->get(Escaper::class);
+        $this->escaper = $escaper ?? ObjectManager::getInstance()->get(Escaper::class);
         parent::__construct($context);
     }
 
@@ -352,7 +359,6 @@ public function getAddParams($item, array $params = [])
      * Retrieve params for adding product to wishlist
      *
      * @param int $itemId
-     *
      * @return string
      */
     public function getMoveFromCartParams($itemId)
@@ -366,7 +372,6 @@ public function getMoveFromCartParams($itemId)
      * Retrieve params for updating product in wishlist
      *
      * @param \Magento\Catalog\Model\Product|\Magento\Wishlist\Model\Item $item
-     *
      * @return string|false
      */
     public function getUpdateParams($item)
@@ -541,6 +546,7 @@ public function getCustomerName()
      */
     public function getRssUrl($wishlistId = null)
     {
+        $params = [];
         $customer = $this->_getCurrentCustomer();
         if ($customer) {
             $key = $customer->getId() . ',' . $customer->getEmail();
@@ -574,6 +580,7 @@ public function getDefaultWishlistName()
 
     /**
      * Calculate count of wishlist items and put value to customer session.
+     *
      * Method called after wishlist modifications and trigger 'wishlist_items_renewed' event.
      * Depends from configuration.
      *

app/code/Magento/Wishlist/Test/Unit/Helper/DataTest.php

@@ -18,6 +18,7 @@
 use Magento\Wishlist\Controller\WishlistProviderInterface;
 use Magento\Wishlist\Model\Item as WishlistItem;
 use Magento\Wishlist\Model\Wishlist;
+use Magento\Customer\Model\Session;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -63,6 +64,9 @@ class DataTest extends \PHPUnit\Framework\TestCase
     /** @var  Context |\PHPUnit_Framework_MockObject_MockObject */
     protected $context;
 
+    /** @var  Session |\PHPUnit_Framework_MockObject_MockObject */
+    protected $customerSession;
+
     /**
      * Set up mock objects for tested class
      *
@@ -121,12 +125,13 @@ protected function setUp()
 
         $this->wishlistItem = $this->getMockBuilder(\Magento\Wishlist\Model\Item::class)
             ->disableOriginalConstructor()
-            ->setMethods([
-                'getProduct',
-                'getWishlistItemId',
-                'getQty',
-            ])
-            ->getMock();
+            ->setMethods(
+                [
+                    'getProduct',
+                    'getWishlistItemId',
+                    'getQty',
+                ]
+            )->getMock();
 
         $this->wishlist = $this->getMockBuilder(\Magento\Wishlist\Model\Wishlist::class)
             ->disableOriginalConstructor()
@@ -136,11 +141,16 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->getMock();
 
+        $this->customerSession = $this->getMockBuilder(\Magento\Customer\Model\Session::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
         $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
         $this->model = $objectManager->getObject(
             \Magento\Wishlist\Helper\Data::class,
             [
                 'context' => $this->context,
+                'customerSession' => $this->customerSession,
                 'storeManager' => $this->storeManager,
                 'wishlistProvider' => $this->wishlistProvider,
                 'coreRegistry' => $this->coreRegistry,
@@ -431,4 +441,20 @@ public function testGetSharedAddAllToCartUrl()
 
         $this->assertEquals($url, $this->model->getSharedAddAllToCartUrl());
     }
+
+    public function testGetRssUrlWithCustomerNotLogin()
+    {
+        $url = 'result url';
+
+        $this->customerSession->expects($this->once())
+            ->method('isLoggedIn')
+            ->willReturn(false);
+
+        $this->urlBuilder->expects($this->once())
+            ->method('getUrl')
+            ->with('wishlist/index/rss', [])
+            ->willReturn($url);
+
+        $this->assertEquals($url, $this->model->getRssUrl());
+    }
 }