MAGETWO-66402: Backward Incompatible Change

- fix integration test and add optimizations to use getAllIds where possible

Author: cpartica

app/code/Magento/Ui/Component/MassAction/Filter.php

@@ -99,6 +99,7 @@ public function getCollection(AbstractDb $collection)
                 throw new LocalizedException(__('Please select item(s).'));
             }
         }
+        /** @var \Magento\Customer\Model\ResourceModel\Customer\Collection $collection */
         $idsArray = $this->getFilterIds();
         if (!empty($idsArray)) {
             $collection->addFieldToFilter(
@@ -220,14 +221,21 @@ private function getFilterIds()
         $idsArray = [];
         $this->applySelectionOnTargetProvider();
         if ($this->getDataProvider() instanceof \Magento\Ui\DataProvider\AbstractDataProvider) {
-            // Use collection's getItems for optimization purposes
-            return $this->getDataProvider()->getAllIds();
+            // Use collection's getItems for optimization purposes.
+            $idsArray = $this->getDataProvider()->getAllIds();
         } else {
             $searchResult = $this->getDataProvider()->getSearchResult();
-            // Use compatible search api getItems when searchResult is not a collection.
-            foreach ($searchResult->getItems() as $item) {
-                /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
-                $idsArray[] = $item->getId();
+            if ($searchResult instanceof \Magento\Eav\Model\Entity\Collection\AbstractCollection
+                || $searchResult instanceof \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection
+            ) {
+                // Use collection's getItems for optimization purposes.
+                $idsArray = $searchResult->getAllIds();
+            } else {
+                // Use compatible search api getItems when searchResult is not a collection.
+                foreach ($searchResult->getItems() as $item) {
+                    /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
+                    $idsArray[] = $item->getId();
+                }
             }
         }
         return  $idsArray;

app/code/Magento/Ui/DataProvider/AbstractDataProvider.php

@@ -281,24 +281,12 @@ public function setConfigData($config)
     }
 
     /**
-     * Retrieve all ids from Search Result
+     * Retrieve all ids from collection
      *
      * @return int[]
      */
     public function getAllIds()
     {
-        $idsArray = [];
-        $searchResult = $this->getSearchResult();
-        if ($searchResult instanceof \Magento\Eav\Model\Entity\Collection\AbstractCollection
-            || $searchResult instanceof \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection
-        ) {
-            $idsArray = $searchResult->getAllIds();
-        } else {
-            foreach ($searchResult->getItems() as $item) {
-                /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
-                $idsArray[] = $item->getId();
-            }
-        }
-        return $idsArray;
+        return  $this->collection->getAllIds();
     }
 }