MC-33699: Stabilize MFTF tests

fix for AdminAddSelectedProductToOrderTest

Author: zakdma

app/code/Magento/Sales/Test/Mftf/ActionGroup/AddSimpleProductToOrderActionGroup.xml

@@ -25,6 +25,6 @@
         <fillField selector="{{AdminOrderFormItemsSection.rowQty('1')}}" userInput="{{productQty}}" stepKey="fillProductQty"/>
         <scrollTo selector="{{AdminOrderFormItemsSection.addSelected}}" x="0" y="-100" stepKey="scrollToAddSelectedButton"/>
         <click selector="{{AdminOrderFormItemsSection.addSelected}}" stepKey="clickAddSelectedProducts"/>
-        <wait time="5" stepKey="waitForOptionsToLoad"/>
+        <waitForLoadingMaskToDisappear stepKey="waitForOptionsToLoad"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Sales/Test/Mftf/ActionGroup/AssertAdminItemOrderedErrorNotVisibleActionGroup.xml

@@ -17,5 +17,6 @@
             <argument name="message" defaultValue="The requested qty is not available" type="string"/>
         </arguments>
         <dontSee userInput="{{message}}" selector="{{AdminOrderFormItemsOrderedSection.productMessage(productName, messageType)}}" stepKey="assertItemErrorNotVisible"/>
+        <dontSee userInput="{{message}}" selector="{{AdminOrderFormMessagesSection.messageByType(messageType)}}" stepKey="assertOrderErrorNotVisible"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Sales/Test/Mftf/Section/AdminOrderFormMessagesSection.xml

@@ -11,5 +11,6 @@
     <section name="AdminOrderFormMessagesSection">
         <element name="success" type="text" selector="#order-message div.message-success"/>
         <element name="error" type="text" selector="#order-message div.message-error"/>
+        <element name="messageByType" type="text" selector="#order-message div.message-{{messageType}}" parameterized="true"/>
     </section>
 </sections>

app/code/Magento/Sales/Test/Mftf/Test/AdminAddSelectedProductToOrderTest.xml

@@ -70,9 +70,6 @@
             <argument name="productQty" value="1"/>
         </actionGroup>
         <!-- Check that error remains -->
-        <actionGroup ref="AssertAdminItemOrderedErrorActionGroup" stepKey="assertProductErrorRemains">
-            <argument name="productName" value="$simpleProduct.name$"/>
-            <argument name="messageType" value="error"/>
-        </actionGroup>
+        <see userInput="The requested qty is not available" selector="{{AdminOrderFormMessagesSection.error}}" stepKey="assertProductErrorRemains"/>
     </test>
 </tests>