Skip to content

Commit 6f5522f

Browse files
committed
Merge remote-tracking branch 'mainline/2.1-develop' into MAGETWO-63226
2 parents 27d74d4 + fa59b15 commit 6f5522f

File tree

7 files changed

+25
-13
lines changed

7 files changed

+25
-13
lines changed

app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@
109109
<argument name="at_call" xsi:type="string">getDescription</argument>
110110
<argument name="at_code" xsi:type="string">description</argument>
111111
<argument name="css_class" xsi:type="string">description</argument>
112-
<argument name="at_label" xsi:type="string">none</argument>
112+
<argument name="at_label" translate="true" xsi:type="string">none</argument>
113113
<argument name="title" translate="true" xsi:type="string">Details</argument>
114114
</arguments>
115115
</block>

app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ if ($_attributeType && $_attributeType == 'text') {
3434

3535
<?php if ($_attributeValue): ?>
3636
<div class="product attribute <?php /* @escapeNotVerified */ echo $_className?>">
37-
<?php if ($_attributeLabel != 'none'): ?><strong class="type"><?php /* @escapeNotVerified */ echo $_attributeLabel?></strong><?php endif; ?>
37+
<?php if ($_attributeLabel != __('none')): ?><strong class="type"><?php /* @escapeNotVerified */ echo $_attributeLabel?></strong><?php endif; ?>
3838
<div class="value" <?php /* @escapeNotVerified */ echo $_attributeAddAttribute;?>><?php /* @escapeNotVerified */ echo $_attributeValue; ?></div>
3939
</div>
4040
<?php endif; ?>

app/design/frontend/Magento/blank/web/css/source/_layout.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
.lib-vendor-prefix-flex-basis(100%);
2222
.lib-vendor-prefix-flex-grow(1);
2323
.lib-vendor-prefix-order(1);
24+
width: 100%;
2425
}
2526

2627
.sidebar-main {

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Order/View/Tab/Shipments/Grid.php

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,29 @@
66

77
namespace Magento\Sales\Test\Block\Adminhtml\Order\View\Tab\Shipments;
88

9+
use Magento\Ui\Test\Block\Adminhtml\DataGrid;
10+
911
/**
10-
* Class Grid
11-
* Shipments grid on order view page
12+
* Shipments grid on order view page.
1213
*/
13-
class Grid extends \Magento\Backend\Test\Block\Widget\Grid
14+
class Grid extends DataGrid
1415
{
1516
/**
16-
* Locator value for link in action column
17+
* Locator value for link in action column.
1718
*
1819
* @var string
1920
*/
2021
protected $editLink = '[data-column="real_shipment_id"]';
2122

2223
/**
23-
* Locator for shipment ids
24+
* Locator for shipment ids.
2425
*
2526
* @var string
2627
*/
2728
protected $shipmentId = 'tbody td:nth-child(2)';
2829

2930
/**
30-
* Filters array mapping
31+
* Filters array mapping.
3132
*
3233
* @var array
3334
*/
@@ -44,12 +45,13 @@ class Grid extends \Magento\Backend\Test\Block\Widget\Grid
4445
];
4546

4647
/**
47-
* Get shipment ids
48+
* Get shipment ids.
4849
*
4950
* @return array
5051
*/
5152
public function getIds()
5253
{
54+
$this->waitLoader();
5355
$result = [];
5456
$shipmentIds = $this->_rootElement->getElements($this->shipmentId);
5557
foreach ($shipmentIds as $shipmentId) {

dev/tests/functional/tests/app/Magento/Shipping/Test/Block/Adminhtml/Shipment/Grid.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ class Grid extends GridInterface
3333
'selector' => 'input[name="order_increment_id"]',
3434
],
3535
'total_qty_from' => [
36-
'selector' => 'input[name="total_qty[from]"',
36+
'selector' => 'input[name="total_qty[from]"]',
3737
],
3838
'total_qty_to' => [
39-
'selector' => 'input[name="total_qty][to]"',
39+
'selector' => 'input[name="total_qty[to]"]',
4040
],
4141
];
4242
}

dev/tests/functional/tests/app/Magento/Shipping/Test/Constraint/AssertShipmentInShipmentsTab.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,21 @@ public function processAssert(
3939

4040
foreach ($ids['shipmentIds'] as $key => $shipmentId) {
4141
$filter = [
42+
'id' => $shipmentId,
43+
'qty' => number_format($totalQty[$key], 4, '.', ''),
44+
];
45+
$filterQty = [
4246
'id' => $shipmentId,
4347
'qty_from' => $totalQty[$key],
4448
'qty_to' => $totalQty[$key],
4549
];
50+
$salesOrderView->getOrderForm()->getTab('shipments')->getGridBlock()->search($filterQty);
4651
\PHPUnit_Framework_Assert::assertTrue(
47-
$salesOrderView->getOrderForm()->getTab('shipments')->getGridBlock()->isRowVisible($filter),
52+
$salesOrderView
53+
->getOrderForm()
54+
->getTab('shipments')
55+
->getGridBlock()
56+
->isRowVisible($filter, false),
4857
'Shipment is absent on shipments tab.'
4958
);
5059
}

dev/tests/functional/tests/app/Magento/UrlRewrite/Test/TestCase/UpdateCustomUrlRewriteEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<data name="initialRewrite/dataset" xsi:type="string">default</data>
1212
<data name="urlRewrite/data/store_id" xsi:type="string">Main Website/Main Website Store/Default Store View</data>
1313
<data name="urlRewrite/data/request_path" xsi:type="string">wishlist/%isolation%</data>
14-
<data name="urlRewrite/data/target_path/entity" xsi:type="string">https://www.magentocommerce.com/magento-connect/</data>
14+
<data name="urlRewrite/data/target_path/entity" xsi:type="string">https://marketplace.magento.com/</data>
1515
<data name="urlRewrite/data/redirect_type" xsi:type="string">Permanent (301)</data>
1616
<data name="urlRewrite/data/description" xsi:type="string">test_description_relative path</data>
1717
<constraint name="Magento\UrlRewrite\Test\Constraint\AssertUrlRewriteSaveMessage" />

0 commit comments

Comments
 (0)