ENGCOM-8178: change error to code is reserved key instead of code already exists #28663

 - Merge Pull Request #28663 from AbdulRahmanAbouzaid/magento2:change_error_messages_for_28479_issue
 - Merged commits:
   1. 580ffe5
   2. 9bc6cc9
   3. 74aaccd
   4. 9c38339
   5. f9374c8
   6. 86f0c6b
   7. e95d5d2
   8. d396c0a
   9. 1d0b91b
   10. c9a1afa
   11. 804a049
   12. 1ea5d75
   13. 2206f77

Author: magento-engcom-team

app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Validate.php

@@ -33,6 +33,7 @@
 class Validate extends AttributeAction implements HttpGetActionInterface, HttpPostActionInterface
 {
     const DEFAULT_MESSAGE_KEY = 'message';
+    private const RESERVED_ATTRIBUTE_CODES = ['product_type', 'type_id'];
 
     /**
      * @var JsonFactory
@@ -145,11 +146,16 @@ public function execute()
             );
         }
 
-        if ($attribute->getId() && !$attributeId || $attributeCode === 'product_type' || $attributeCode === 'type_id') {
+        if (in_array($attributeCode, self::RESERVED_ATTRIBUTE_CODES, true)) {
+            $message = __('Code (%1) is a reserved key and cannot be used as attribute code.', $attributeCode);
+            $this->setMessageToResponse($response, [$message]);
+            $response->setError(true);
+        }
+
+        if ($attribute->getId() && !$attributeId) {
             $message = strlen($this->getRequest()->getParam('attribute_code'))
                 ? __('An attribute with this code already exists.')
                 : __('An attribute with the same code (%1) already exists.', $attributeCode);
-
             $this->setMessageToResponse($response, [$message]);
 
             $response->setError(true);

app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml

@@ -385,6 +385,20 @@
         <data key="default_store_label" unique="suffix">Attribute Store label &lt;span&gt; </data>
         <data key="frontend_input">text</data>
     </entity>
+    <entity name="ProductTypeIdAttribute" type="ProductAttribute">
+        <data key="frontend_label">Type id</data>
+        <data key="attribute_code">type_id</data>
+        <data key="frontend_input">text</data>
+        <data key="is_required">No</data>
+        <data key="is_required_admin">No</data>
+    </entity>
+    <entity name="ProductProductTypeAttribute" type="ProductAttribute">
+        <data key="frontend_label">Product type</data>
+        <data key="attribute_code">product_type</data>
+        <data key="frontend_input">text</data>
+        <data key="is_required">No</data>
+        <data key="is_required_admin">No</data>
+    </entity>
     <!-- Product attribute from file "export_import_configurable_product.csv" -->
     <entity name="ProductAttributeWithTwoOptionsForExportImport" extends="productAttributeDropdownTwoOptions" type="ProductAttribute">
         <data key="attribute_code">attribute</data>

app/code/Magento/Catalog/Test/Mftf/Test/CreateProductAttributeEntityTest/CreateProductAttributeEntityWithReservedKeysTest.xml

@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="CreateProductAttributeEntityWithReservedKeysTest">
+        <annotations>
+            <features value="Catalog"/>
+            <stories value="Create Product Attributes"/>
+            <title value="Attributess with reserved codes should not be created"/>
+            <description value="Admin should not be able to create product attribute with reserved codes"/>
+            <severity value="MINOR"/>
+            <testCaseId value="MC-37806"/>
+            <group value="catalog"/>
+        </annotations>
+
+        <before>
+            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
+        </before>
+        <after>
+            <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
+        </after>
+
+        <!--Navigate to Stores > Attributes > Product.-->
+        <amOnPage url="{{AdminProductAttributeGridPage.url}}" stepKey="goToProductAttributesGrid"/>
+
+        <!--Create new Product Attribute as TextField, with type_id code.-->
+        <actionGroup ref="CreateProductAttributeActionGroup" stepKey="createAttribute">
+            <argument name="attribute" value="ProductTypeIdAttribute"/>
+        </actionGroup>
+        <see stepKey="seeErrorMessage" selector="{{AdminMessagesSection.errorMessage}}" userInput="Code (type_id) is a reserved key and cannot be used as attribute code."/>
+
+        <!--Navigate to Stores > Attributes > Product.-->
+        <amOnPage url="{{AdminProductAttributeGridPage.url}}" stepKey="backToProductAttributesGrid"/>
+
+        <!--Create new Product Attribute as TextField, with product_type code.-->
+        <actionGroup ref="CreateProductAttributeActionGroup" stepKey="createAttribute2">
+            <argument name="attribute" value="ProductProductTypeAttribute"/>
+        </actionGroup>
+
+        <see stepKey="seeErrorMessage2" selector="{{AdminMessagesSection.errorMessage}}" userInput="Code (product_type) is a reserved key and cannot be used as attribute code."/>
+    </test>
+</tests>

app/code/Magento/Catalog/i18n/en_US.csv

@@ -209,6 +209,7 @@ Catalog,Catalog
 "You saved the product attribute.","You saved the product attribute."
 "An attribute with this code already exists.","An attribute with this code already exists."
 "An attribute with the same code (%1) already exists.","An attribute with the same code (%1) already exists."
+"Code (%1) is a reserved key and cannot be used as attribute code.","Code (%1) is a reserved key and cannot be used as attribute code."
 "The value of Admin must be unique.","The value of Admin must be unique."
 "The value of Admin scope can't be empty.","The value of Admin scope can't be empty."
 "You duplicated the product.","You duplicated the product."