MAGETWO-92720: E-mail admin users when a new administrator is created.

Author: Oleksandr Gorkun

app/code/Magento/User/Controller/Adminhtml/Auth/Forgotpassword.php

@@ -10,6 +10,9 @@
 use Magento\Security\Model\SecurityManager;
 use Magento\User\Model\Spi\NotificatorInterface;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class Forgotpassword extends \Magento\User\Controller\Adminhtml\Auth
 {
     /**

app/code/Magento/User/Controller/Adminhtml/User/Save.php

@@ -9,7 +9,7 @@
 use Magento\Framework\Exception\AuthenticationException;
 use Magento\Framework\Exception\State\UserLockedException;
 use Magento\Security\Model\SecurityCookie;
-use Magento\User\Model\Spi\NotificationException;
+use Magento\User\Model\Spi\NotificationExceptionInterface;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -99,7 +99,7 @@ public function execute()
                 \Magento\Security\Model\AdminSessionsManager::LOGOUT_REASON_USER_LOCKED
             );
             $this->_redirect('adminhtml/*/');
-        } catch (NotificationException $exception) {
+        } catch (NotificationExceptionInterface $exception) {
             $this->messageManager->addErrorMessage($exception->getMessage());
         } catch (\Magento\Framework\Exception\AuthenticationException $e) {
             $this->messageManager->addError(

app/code/Magento/User/Model/Notificator.php

@@ -18,9 +18,12 @@
 use Magento\Framework\Mail\Template\TransportBuilder;
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Backend\App\Area\FrontNameResolver;
+use Magento\Email\Model\BackendTemplate;
 
 /**
  * @inheritDoc
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Notificator implements NotificatorInterface
 {
@@ -81,7 +84,7 @@ private function sendNotification(
     ): void {
         $transport = $this->transportBuilder
             ->setTemplateIdentifier($this->config->getValue($templateConfigId))
-            ->setTemplateModel(\Magento\Email\Model\BackendTemplate::class)
+            ->setTemplateModel(BackendTemplate::class)
             ->setTemplateOptions([
                 'area' => FrontNameResolver::AREA_CODE,
                 'store' => Store::DEFAULT_STORE_ID
@@ -188,5 +191,4 @@ public function sendUpdated(UserInterface $user, array $changed): void
             );
         }
     }
-
 }

app/code/Magento/User/Model/NotificatorException.php

@@ -9,12 +9,12 @@
 namespace Magento\User\Model;
 
 use Magento\Framework\Exception\MailException;
-use Magento\User\Model\Spi\NotificationException;
+use Magento\User\Model\Spi\NotificationExceptionInterface;
 
 /**
  * When notificator cannot send an email.
  */
-class NotificatorException extends MailException implements NotificationException
+class NotificatorException extends MailException implements NotificationExceptionInterface
 {
 
 }

app/code/Magento/User/Model/Spi/NotificationException.php renamed to app/code/Magento/User/Model/Spi/NotificationExceptionInterface.php

@@ -11,7 +11,7 @@
 /**
  * When a notification cannot be sent.
  */
-interface NotificationException extends \Throwable
+interface NotificationExceptionInterface extends \Throwable
 {
 
 }

app/code/Magento/User/Model/Spi/NotificatorInterface.php

@@ -19,7 +19,7 @@ interface NotificatorInterface
      * Send notification when a user requests password reset.
      *
      * @param UserInterface $user User that requested password reset.
-     * @throws NotificationException
+     * @throws NotificationExceptionInterface
      *
      * @return void
      */
@@ -29,7 +29,7 @@ public function sendForgotPassword(UserInterface $user): void;
      * Send a notification when a new user is created.
      *
      * @param UserInterface $user The new user.
-     * @throws NotificationException
+     * @throws NotificationExceptionInterface
      *
      * @return void
      */
@@ -40,7 +40,7 @@ public function sendCreated(UserInterface $user): void;
      *
      * @param UserInterface $user The user updated.
      * @param string[] List of changed properties.
-     * @throws NotificationException
+     * @throws NotificationExceptionInterface
      *
      * @return void
      */

app/code/Magento/User/Model/User.php

@@ -12,7 +12,7 @@
 use Magento\Framework\Exception\AuthenticationException;
 use Magento\Framework\Serialize\Serializer\Json;
 use Magento\User\Api\Data\UserInterface;
-use Magento\User\Model\Spi\NotificationException;
+use Magento\User\Model\Spi\NotificationExceptionInterface;
 use Magento\User\Model\Spi\NotificatorInterface;
 
 /**
@@ -446,7 +446,7 @@ public function sendPasswordResetNotificationEmail()
     /**
      * Check changes and send notification emails.
      *
-     * @throws NotificationException
+     * @throws NotificationExceptionInterface
      * @return $this
      * @since 100.1.0
      */
@@ -495,7 +495,7 @@ protected function createChangesDescriptionString()
      *
      * @param string $changes
      * @param string $email
-     * @throws NotificationException
+     * @throws NotificationExceptionInterface
      * @return $this
      * @since 100.1.0
      * @deprecated

app/code/Magento/User/Test/Unit/Model/UserTest.php

@@ -44,7 +44,6 @@ protected function setUp()
         );
     }
 
-
     /**
      * @return void
      */