Skip to content

Commit 6e81326

Browse files
authored
ENGCOM-7501: Correct height for media gallery images #28048
2 parents 0048794 + ddf97f5 commit 6e81326

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,35 @@
77
/** @var $block \Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Files */
88

99
$_width = $block->getImagesWidth();
10-
$_height = $block->getImagesHeight();
1110

1211
?>
13-
<?php if ($block->getFilesCount() > 0) : ?>
14-
<?php foreach ($block->getFiles() as $file) : ?>
12+
<?php if ($block->getFilesCount() > 0): ?>
13+
<?php foreach ($block->getFiles() as $file): ?>
14+
<?php
15+
$src = $block->getFileThumbUrl($file);
16+
$width = $block->getFileWidth($file);
17+
$height = $block->getFileHeight($file);
18+
$filename = $block->getFileName($file);
19+
?>
1520
<div
1621
data-row="file"
1722
class="filecnt"
1823
id="<?= $block->escapeHtmlAttr($block->getFileId($file)) ?>"
1924
data-size="<?= $block->escapeHtmlAttr($file->getSize()) ?>"
2025
data-mime-type="<?= $block->escapeHtmlAttr($file->getMimeType()) ?>"
2126
>
22-
<p class="nm" style="height:<?= $block->escapeHtmlAttr($_height) ?>px;">
23-
<?php if ($block->getFileThumbUrl($file)) : ?>
24-
<img src="<?= $block->escapeHtmlAttr($block->getFileThumbUrl($file)) ?>" alt="<?= $block->escapeHtmlAttr($block->getFileName($file)) ?>"/>
27+
<p class="nm">
28+
<?php if ($block->getFileThumbUrl($file)): ?>
29+
<img src="<?= $block->escapeHtmlAttr($src) ?>" alt="<?= $block->escapeHtmlAttr($filename) ?>"/>
2530
<?php endif; ?>
2631
</p>
27-
<?php if ($block->getFileWidth($file)) : ?>
28-
<small><?= $block->escapeHtml($block->getFileWidth($file)) ?>x<?= $block->escapeHtml($block->getFileHeight($file)) ?> <?= $block->escapeHtml(__('px.')) ?></small><br/>
32+
<?php if ($block->getFileWidth($file)): ?>
33+
<small><?= $block->escapeHtmlAttr($width) ?>x<?= $block->escapeHtmlAttr($height) ?>
34+
<?= $block->escapeHtml(__('px.')) ?></small><br/>
2935
<?php endif; ?>
3036
<small><?= $block->escapeHtml($block->getFileShortName($file)) ?></small>
3137
</div>
3238
<?php endforeach; ?>
33-
<?php else : ?>
39+
<?php else: ?>
3440
<div class="empty"><?= $block->escapeHtml(__('No files found')) ?></div>
3541
<?php endif; ?>

app/design/adminhtml/Magento/backend/web/css/source/components/_file-insertion.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
}
5353

5454
p {
55+
min-height: 72px;
5556
text-align: center;
5657
}
5758
}

0 commit comments

Comments
 (0)